gnucash unstable: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Tue Oct 31 20:25:36 EDT 2017
Updated via https://github.com/Gnucash/gnucash/commit/a6f4ea65 (commit)
via https://github.com/Gnucash/gnucash/commit/f4acb6c0 (commit)
via https://github.com/Gnucash/gnucash/commit/3913c528 (commit)
via https://github.com/Gnucash/gnucash/commit/46b3e1ca (commit)
via https://github.com/Gnucash/gnucash/commit/85e56512 (commit)
via https://github.com/Gnucash/gnucash/commit/9c7ba523 (commit)
via https://github.com/Gnucash/gnucash/commit/2fcd1efd (commit)
via https://github.com/Gnucash/gnucash/commit/3c8eeb8b (commit)
from https://github.com/Gnucash/gnucash/commit/a8407484 (commit)
commit a6f4ea65e94efd11f6dc495660b4fc19c48ba9ab
Merge: a840748 f4acb6c
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 31 17:24:44 2017 -0700
Merge J. Marino's 'fix/report-net-barchart' into unstable
commit f4acb6c00071a8c4e900bf0f2ee479826c5eb372
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Wed Oct 18 14:44:54 2017 -0600
report/category-barchart: fix unit test to work with gnc-monetary
The unit test for category-barchart did not initialize html stylesheets.
Without any stylesheets available, the renderer defaults to a
trivial renderer. This works fine if the table in the report is
populated by doubles. However, now it is populated by gnc-monetary
and they need a stylesheet to be properly formatted.
This commit makes sure to initialize the html stylesheet code in
the unit test and adapts the parsing code to the new formatting.
commit 3913c528f10200e3bc1e5c46fa47c828a41d4b42
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Wed Oct 18 14:32:25 2017 -0600
report/category-barchart: calculate using gnc-monetary instead of double
Perform and store all calculations using gnc-monetary instead of double.
Conversion to double is only needed as a last step when adding data
to the chart (using new local function "monetary->double").
When a table is displayed, since the values are gnc-monetary, they are
properly formatted as monetary values.
commit 46b3e1caad3b585727803cd46e6f8d9d20a65d81
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Wed Oct 18 09:53:09 2017 -0600
report/net-linechart: fix unit test to work with gnc-monetary
The unit test for net-linechart did not initialize html stylesheets.
Without any stylesheets available, the renderer defaults to a
trivial renderer. This works fine if the table in the net-linechart
report is populated by doubles. However, now it is populated by
gnc-monetary and they need a stylesheet to be properly formatted.
This commit makes sure to initialize the html stylesheet code in
the unit test and adapts the parsing code to the new formatting.
commit 85e56512023f67bf6b8843625c427a836ec5eb88
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Wed Oct 18 09:46:50 2017 -0600
report/net-linechart: calculate using gnc-monetary instead of double
Perform and store all calculations using gnc-monetary instead of double.
Conversion to double is only needed as a last step when adding data
to the chart (using new function "monetary->double").
If the table is displayed, its values are properly formatted as monetary
values since they are gnc-monetary instead of doubles.
commit 9c7ba5231526914d922bcaf944fbe379a202e054
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Tue Oct 17 15:09:20 2017 -0600
report/net-barchart: fix unit test to work with gnc-monetary
The unit test for net-barchart did not initialize html stylesheets.
Without any stylesheets available, the renderer defaults to a
trivial renderer. This works fine if the table in the net-barchart
report is populated by doubles. However, now it is populated by
gnc-monetary and they need a stylesheet to be properly formatted.
Using doubles and the trivial renderer, a table cell looks like:
<td class="number-cell"><number> 6.0</td>
Using gnc-monetary and the trivial renderer, a table cell looks like:
<td class="number-cell"><gnc-monetary> #[unknown]</td>
Initializing the html stylesheets, the table cell looks like:
<td class="number-cell">$6.00</td>
This commit makes sure to initialize the html stylesheet code in
the unit test and adapts the parsing code to the new formatting.
commit 2fcd1efd6dc1a157143a8e010b9d59de5b628ccd
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Tue Oct 17 14:51:52 2017 -0600
report/net-barchart: default to list of zeros instead of empty list
This was the original behavior before the change to gnc-monetary.
commit 3c8eeb8b3bdb54683fe5a804aa35d87b60693657
Author: Jose Marino <jmarino at users.noreply.github.com>
Date: Fri Oct 13 10:40:52 2017 -0600
report/net-barchart: calculate using gnc-monetary instead of double
Perform and store all calculations using gnc-monetary instead of double.
Conversion to double is only needed as a last step when adding data
to the chart (using new function "monetary->double").
When a table is displayed, since the values are gnc-monetary, they are
properly formatted as monetary values.
Summary of changes:
.../report/standard-reports/category-barchart.scm | 101 +++++++++++++++------
gnucash/report/standard-reports/net-barchart.scm | 52 +++++++----
gnucash/report/standard-reports/net-linechart.scm | 56 +++++++-----
.../test/test-generic-category-report.scm | 23 ++---
.../test/test-generic-net-barchart.scm | 41 +++++----
.../test/test-generic-net-linechart.scm | 25 ++---
6 files changed, 185 insertions(+), 113 deletions(-)
More information about the gnucash-patches
mailing list