gnucash maint: Multiple changes pushed

Fri Aug 31 17:58:08 EDT 2018

Updated	 via  https://github.com/Gnucash/gnucash/commit/bf00330e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/131df821 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2dcb3162 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fd750a22 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8ad6e045 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3456596a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/67ee1d99 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/aabae1ca (commit)
	 via  https://github.com/Gnucash/gnucash/commit/dd49756f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/995e6b0f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/39b24325 (commit)
	from  https://github.com/Gnucash/gnucash/commit/caaf9edc (commit)


commit bf00330eedba3543e66417224788dcfc1406b96d
Merge: 131df82 995e6b0
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Fri Aug 31 23:55:01 2018 +0200

    Merge branch 'Bug796725' of https://github.com/Bob-IT/gnucash into maint

commit 131df82135e67fa5b5b941b9a5f60b6545071b6d
Merge: caaf9ed 2dcb316
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Fri Aug 31 22:01:45 2018 +0200

    Merge branch 'date-bugs' of https://github.com/Bob-IT/gnucash into maint

commit 2dcb31628094636219a0a3e5466d7d802b117e0d
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sat Aug 25 11:08:32 2018 +0100

    White space removal and change tabs to spaces in qofbook.cpp/h

commit fd750a22ebe34fad3ec78a7fb69e51537cd3eaec
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Fri Aug 24 16:57:58 2018 +0100

    Cache the number of days read only value
    
    The KVP value for the qof_book_get_num_days_autoreadonly was being
    called many times so it makes sense to cache it in the book to avoid
    the KVP lookup.

commit 8ad6e04549e8f971ad76baee29fabfaa9240cb4a
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Fri Aug 24 16:52:17 2018 +0100

    Book Options did not raise when already open
    
    If you open File->Properties and the dialogue gets hidden and you go to
    open it again the existing dialogue was not being raised to the front.
    This was due to a bad cast.

commit 3456596a1c006b5ec317e4482b9455548ef0a579
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Aug 22 20:40:17 2018 +0100

    Bug 796814 - Changing a book's read-only threshold doesn't immediately affect open registers
    
    Add test for change of read-only threshold to helper function for the
    gnc_book_options_dialog_apply_cb which will then do a gui refresh.

commit 67ee1d99a4e7b226c98ab84a04864ed390ba9f2f
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Aug 22 20:38:36 2018 +0100

    Bug 796812 - gnc_date_cell_get_date and gnc_date_cell_get_date_gdate have different date validation behaviour - part 2
    
    Change the two register get_help functions to use gnc_date_cell_get_date
    with the warn parameter FALSE, this way we only get one warning when the
    date is out of range.
    
    Also as no functions use gnc_date_cell_get_date_gdate it can be removed.

commit aabae1caf9e0cbf70266ecf8a265c97ffb3326a0
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Aug 22 20:36:51 2018 +0100

    Bug 796812 - gnc_date_cell_get_date and gnc_date_cell_get_date_gdate have different date validation behaviour - part 1
    
    Add gboolean parameter to gnc_date_cell_get_date to enable warning for
    the date out of range dialogue and update every occurrence accordingly.

commit dd49756f4ebdbdb9e9d57f089206dc1a0068e278
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Aug 22 20:35:54 2018 +0100

    Bug 796813 - Date validation inconsistent
    
    Change gnc_split_register_save_date_cell function and the equivalent one
     in gncEntryLedgerModel to use time64 version of gnc_date_cell_get_date
    which includes the warning for dates out of range.

commit 995e6b0f956a876a3c4f3b8a60b09dd94a5cf81b
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Aug 16 11:23:30 2018 +0100

    White space and tabs changed in search-date.c

commit 39b24325d92b080ef69e4f18e7f5d03d398deafe
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Aug 16 11:22:44 2018 +0100

    Bug 796725 - 4 of 6 Date Posted options fail to return
     matching transactions.
    
    gnc_date_edit_get_date returns the time64 value set to 00:00:00 for the
    day entered so for the LTE and GT options gnc_date_edit_get_date_end
    needs to be used for 23:59:59. For finding transactions on the date,
    the use of QOF_DATE_MATCH_DAY needs to be used.


Summary of changes:
 gnucash/gnome-search/search-date.c                 |  46 ++++---
 gnucash/gnome-utils/gnc-main-window.c              |  24 +++-
 gnucash/register/ledger-core/gncEntryLedgerModel.c |  19 +--
 .../register/ledger-core/split-register-control.c  |   2 +-
 .../ledger-core/split-register-model-save.c        |  14 +-
 .../register/ledger-core/split-register-model.c    |  11 +-
 gnucash/register/ledger-core/split-register.c      |   4 +-
 gnucash/register/register-core/datecell.h          |   9 +-
 gnucash/register/register-gnome/datecell-gnome.c   |  22 +---
 libgnucash/engine/qofbook.cpp                      | 146 +++++++++++++--------
 libgnucash/engine/qofbook.h                        |  21 ++-
 11 files changed, 187 insertions(+), 131 deletions(-)