gnucash maint: Multiple changes pushed

Geert Janssens gjanssens at code.gnucash.org
Thu Dec 27 16:56:04 EST 2018


Updated	 via  https://github.com/Gnucash/gnucash/commit/692e2266 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d22e1db3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/74ed802e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/aaa71f22 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4b398325 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/06da9e97 (commit)
	from  https://github.com/Gnucash/gnucash/commit/e61d5c47 (commit)



commit 692e22668bac261f4bd9183bdc4e961c358f06df
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Dec 27 22:55:54 2018 +0100

    Silence deprecation warnings in the gui
    
    We only want warnings for our own deprecated functions in libgnucash.

commit d22e1db340e3107dfd152829b6ab736e24db5e3a
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Dec 27 22:28:29 2018 +0100

    gnc-uri - refer to 'scheme' instead of 'protocol' as that's the more formal term used in uris
    
    This involves renaming 3 functions:
    gnc_uri_get_protocol -> gnc_uri_get_scheme
    gnc_uri_is_known_protocol -> gnc_uri_is_known_scheme
    gnc_uri_is_file_protocol -> gnc_uri_is_file_scheme
    
    The *_protocol variants are marked as deprecated.
    Additionally a number of local variables have been renamed from
    protocol to scheme to support this change.

commit 74ed802eae9862ac79a24678cdb5d7c3403edd59
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Dec 27 22:25:18 2018 +0100

    Show warnings for deprecated declarations
    
    We're about to announce our own set of deprecated functions in libgnucash.
    That would be pretty pointless if we also would silence all deprecation warnings
    at the same time...

commit aaa71f2250fca753d6f44c10d1d04081b2be5026
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Dec 27 20:53:15 2018 +0100

    Fix memory leaks in dialog-file-acces.c:geturl

commit 4b398325eac49bdd16b9de216ebb636245c1fa77
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Dec 27 20:45:43 2018 +0100

    Redesign gnc-uri-utils
    
    - gnc_uri_get_components will now return NULL as protocol if the input is a normal
      file system path instead of a uri (it used to return 'file')
    - gnc_uri_get_protocol will now return NULL if the input is a normal
      file system path instead of a uri (it used to return 'file')
    - gnc_uri_is_file_protocol now returns FALSE if protocol is NULL (it used to return TRUE)
    - gnc_uri_is_file_uri now returns FALSE if input is a normal file
      system path instead of a uri (it used to return TRUE)
    - a new function gnc_uri_targets_local_fs will return TRUE only if its input
      is either a file uri or a normal file system path. This function is now mostly
      used instead of gnc_uri_is_file_uri in the current code base
    - a new function gnc_uri_is_uri is added to check whether its input
      is a valid uri (has protocol, path and hostname for non-file uris)

commit 06da9e9712b66d3b1e3deb034f5a7f21329d1e02
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Dec 27 20:52:38 2018 +0100

    Enable gnc-uri test suite
    
    It was there but never run :(



Summary of changes:
 CMakeLists.txt                                     |   4 +-
 common/platform.h                                  |   1 +
 gnucash/gnome-utils/CMakeLists.txt                 |   1 +
 gnucash/gnome-utils/dialog-file-access.c           |  44 ++---
 gnucash/gnome-utils/gnc-file.c                     |  77 ++++----
 gnucash/gnome-utils/gnc-main-window.c              |   4 +-
 gnucash/gnome-utils/gnc-plugin-file-history.c      |   4 +-
 libgnucash/app-utils/gnc-state.c                   |  10 +-
 libgnucash/backend/dbi/gnc-backend-dbi.cpp         |   8 +-
 .../backend/dbi/test/test-backend-dbi-basic.cpp    |   8 +-
 libgnucash/engine/gnc-uri-utils.c                  | 204 +++++++++++++-------
 libgnucash/engine/gnc-uri-utils.h                  | 209 +++++++++++++++------
 libgnucash/engine/test/test-engine.c               |   2 +
 libgnucash/engine/test/test-gnc-uri-utils.c        |  22 +--
 14 files changed, 384 insertions(+), 214 deletions(-)



More information about the gnucash-patches mailing list