gnucash unstable: Multiple changes pushed

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/e3cd9f88 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bdd7cc73 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bc8ad896 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/97e415fd (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b261eb18 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/276a7d24 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/88b34462 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6004b55d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3749ca52 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/12f3099f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/01e604d8 (commit)
	from  https://github.com/Gnucash/gnucash/commit/611ead2b (commit)



commit e3cd9f88c94c3c2b5e8fcdbc5457908446879df2
Merge: 611ead2 bdd7cc7
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 17 23:22:23 2018 +0100

    Merge branch 'unstable-TR-progress' of https://github.com/christopherlam/gnucash into unstable

commit bdd7cc73ef6ca8f844e908fbc35718ae73bfc543
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Feb 11 23:31:53 2018 +0800

    GSTR: Restore some strings

commit bc8ad8961a0158b483c87032ee0367bc47f313fa
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Feb 7 23:13:58 2018 +0800

    TR & GSTReport: Improve comments
    
    This commit only improves the comments for
    both reports, and uses gnc:error calls as
    advised. The reordering in GST Report now
    reflects the logical transformation of a
    split into column amount.

commit 97e415fdf3fe0d9ccc7f68f5b4ffa5ef26455323
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Feb 7 22:00:39 2018 +0800

    GSTReport: filter out some transactions
    
    This commit restores filtering for closing, link
    and payment transactions.

commit b261eb18b3b6c8be5b92c4610979b3a2bb8af7a5
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Feb 7 19:56:24 2018 +0800

    Revert options.scm lookup-options renaming
    
    and use (gnc:error) as advised

commit 276a7d24d2d0380cda24f5f0f7f159ea897101a5
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jan 12 16:45:03 2018 +1100

    REWRITE income-gst-statement.scm
    
    This commit rewrites income-gst-statement.scm to be a derivation
    of transaction.scm, modifying the options database and passing
    custom arguments to the trep-renderer.
    
    This should hopefully reduce risk of errors.

commit 88b3446299bda0b7706e47dc1c2c440f8c769e4b
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Jan 7 23:15:57 2018 +1100

    ADD-API: gnc:option-make-internal!,  gnc:unregister-option
    
    This commit adds 2 additional helper calls, primarily useful for
    derived reports.
    
    gnc:option-make-internal! will hide an existing option. e.g.
    a derived report can set the value for a Display/* option and
    hide it from the user.
    
    gnc:unregister-option will unregister option. This is primarily
    useful for derived options e.g. another report copies from
    transaction.scm and removes some options and recreates them with
    different parameters.
    
    For example, unregister existing option from section "Accounts"
    name "Accounts", and recreate with different parameters e.g.
    limited account types.

commit 6004b55d16a0dc4a3b52baed6dd16d70281c054f
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jan 27 21:46:42 2018 +0800

    TR: remove unnecessary no-account-after-filtering step
    
    This merges the initial 'no-account' warning and the
    'no-account-after-filtering' warning. This reduces
    the number of strings required.
    
    The user can select some accounts, set an account name
    filter which produces no accounts, and will see a
    blank report with the gnc:render-options-changed
    confirming that options were set, and the blank
    filter is caused by the filter.
    
    Example: http://i.imgur.com/eqq1Bpa.png

commit 3749ca528be1925d9ae648f9002e42ebe49d26eb
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Jan 28 07:29:44 2018 +0800

    TR: omit display of $0 in subtotals in other currencies.
    
    Previously in dual-subtotal columns, the dual-subtotal would
    attempt to print all commodities in the row. This meant
    if user chose common-currency thereby triggering additional
    commodities, the dual-subtotal would attempt to add amounts
    in other commodities which would be 0, and display the 0
    amount. This commit will modify the the dual-subtotal strategy
    to only add column where a value actually exists.
    
    This commit is a continuation of previous TR enhancement
    (multiple data columns) where I have now understood how
    to disable these $0 amounts in subtotals.
    
    From: http://i.imgur.com/sqAHsPQ.png
    To:   http://i.imgur.com/n0R7xeV.png

commit 12f3099f59cac59e9dfde98492c5c122991736aa
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jan 12 16:45:22 2018 +1100

    (infobox)->(gnc:render-options-changed) in options.scm
    
    This commit will change (infobox) to a general-purpose
    renderer for "all options changed by user" in options.scm
    and can be inserted into any report. It reduces the
    number of strings required.

commit 01e604d8eebf2ac262ea550e2f292bbafa2ef042
Author: christopherlam <christopher.lck at gmail.com>
Date:   Thu Feb 1 15:08:28 2018 +0800

    Use xaccSplitGetReconcile instead of (zero? date)
    
    (zero? date) not a good test for reconcile status.
    Use xaccSplitGetReconcile(split)=='y'.
    This is a better test.



Summary of changes:
 .../standard-reports/income-gst-statement.scm      | 1957 ++------------------
 gnucash/report/standard-reports/transaction.scm    |  268 ++-
 libgnucash/app-utils/app-utils.scm                 |    4 +-
 libgnucash/app-utils/options.scm                   |   82 +-
 4 files changed, 402 insertions(+), 1909 deletions(-)