gnucash maint: Bug 796756 - OFX import fails to recognize associated income accounts.

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/9db7d894 (commit)
	from  https://github.com/Gnucash/gnucash/commit/983c7ce0 (commit)



commit 9db7d89474ce8133bf8459b514297ab081881c7b
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jul 13 11:46:50 2018 -0700

    Bug 796756 - OFX import fails to recognize associated income accounts.
    
    Because qof_instance_set and qof_instance_get were being called with the
    KVP key instead of the property name.
    
    Since we don't really want references to KVP outside of engine and since
    the two functions are called exactly once each in qof-ofx-import.c move
    them inside qof-ofx-import.c and get rid of gnc-ofx-kvp.[ch] as well as
    fix the bug.



Summary of changes:
 gnucash/import-export/ofx/CMakeLists.txt   |  2 --
 gnucash/import-export/ofx/gnc-ofx-import.c | 37 ++++++++++++++++---
 gnucash/import-export/ofx/gnc-ofx-kvp.c    | 57 ------------------------------
 gnucash/import-export/ofx/gnc-ofx-kvp.h    | 38 --------------------
 4 files changed, 33 insertions(+), 101 deletions(-)
 delete mode 100644 gnucash/import-export/ofx/gnc-ofx-kvp.c
 delete mode 100644 gnucash/import-export/ofx/gnc-ofx-kvp.h