gnucash master: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Sun Jun 3 13:31:37 EDT 2018


Updated	 via  https://github.com/Gnucash/gnucash/commit/eb67baba (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0064dafb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/333a14c0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3b3074c2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f8045b27 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/537fd995 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9db60ca6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bc605d20 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/04836eb6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/709f69db (commit)
	 via  https://github.com/Gnucash/gnucash/commit/51093e43 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3e052e8d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e23769f0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f504e39d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/464fdeeb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f77e6e34 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5ff642e3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2a28c682 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6730d142 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/15ab1ef3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/74cbde2d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/69c81565 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/174752e2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/aa086893 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5c0f56b0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6b5ee8f5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/075021a8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/243bf8af (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5708707f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/396c955f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5389aa22 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fcabf6bb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8b1b25ae (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2e8df198 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/519ce9fb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5f5ad968 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3ac0f4a3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/53a17fe7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/324c9adf (commit)
	from  https://github.com/Gnucash/gnucash/commit/61071b9f (commit)



commit eb67baba5b18dc4eaba7f29bf306e9091a1ff1d7
Merge: 0064daf 69c8156
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Jun 3 10:26:52 2018 -0700

    Merge Keve Mueller's 'xea-fixes' into maint

commit 0064dafbad30d1146688e7329274cc10714919b3
Merge: 333a14c bc605d2
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Jun 3 10:10:11 2018 -0700

    Merge Bob Fewell's Bug Fixes 5 into maint.

commit 333a14c0fd69324fe2586324e54e2bc74cedcef8
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 2 17:57:42 2018 -0700

    Fix ubuntu build failure.
    
    %$^%$ C++11 initializer list behavior.

commit 3b3074c28d39ab5cfae93261978cad17ed3dc73e
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 2 16:21:49 2018 -0700

    Bug 796117 - Connecting 3.1 to an existing mysql db drops all data
    
    Provide a backup recovery function that instead of dropping primaries
    and restoring backups merges the primaries and backups. This should
    handle a worst-case safe-save failure where the backup tables don't
    have a complete set of rows for some reason.

commit f8045b27355e105e6c4513ac2c3cdeab9f91bb9d
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 2 16:21:05 2018 -0700

    A wee bit of C++ style.

commit 537fd995a3221db3ca5ec785a3247851b5464c40
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 2 16:20:36 2018 -0700

    Ensure full precision of doubles is saved to SQL.
    
    std::iostream's operator<<(double) uses only 6 digits of precision
    by default. We want 12 digits when saving.

commit 9db60ca63c12eca99c6ea893b22617e934b8943b
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 2 16:16:41 2018 -0700

    Make float database operations more consistent.
    
    We don't use floats in GnuCash, we use doubles (and those as little as
    possible), but dbd-sqlite3 is broken in that it stores only floats.
    Simply casting floats to doubles introduces bogus additional digits
    that can cause round-trip tests to fail. Instead convert floats to
    doubles by multiplying by 10E6, rounding, then dividing by 10E6.

commit bc605d200ee3bf6b4aa2f03bb2d7ba95b583b1fb
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sat Jun 2 11:24:53 2018 +0100

    Prevent crash in gnc-tree-view.c
    
    When getting information from the state file, protect against the key
    not having a '_' which is used to split the string.

commit 04836eb6719b4d2e09d5e29eb3d554fd0b9687d4
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sat Jun 2 11:24:20 2018 +0100

    Add the full account name to the saved register settings
    
    If you need to delete the layout for a register in the settings file,
    the only thing identifying it is the account guid. To make it easier
    for humans, add the full account name also.

commit 709f69db3219831e81dfabf0500222770372c7e5
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sat Jun 2 11:23:40 2018 +0100

    When register pages are restored it uses the full account name.
    
    When register pages are restored, the account is found from the full
    name so if the separator changes it will fail. Instead, also save the
    account guid and use that as default to find the account falling back
    to the full name.

commit 51093e43badb504c248373716918f6c0f2f34f0b
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sat Jun 2 11:22:58 2018 +0100

    Bug 796256 - Closing Gnucash when minimized on windows
    
    Closing Gnucash on Windows when minimized causes the window position to
    be saved as -32000,-32000 and on restart the window can not be seen. To
    fix this the previous retrieved position is saved and used if on exit
    the window is minimized.

commit 3e052e8dac87b8b38af73bf68e5cdd03c56930f2
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jun 1 14:12:56 2018 -0700

    [DBI Backend] Rework backup-table management.
    
    Removes a public function, GncDbiSqlConnection::table_manage_backup that
    should have been private in the first place.
    
    Better encapsulates table renames and drops with private functions and
    handles cases where there exist some primary tables and some backup tables.

commit e23769f078041ac9be787f85aa83723c15c18045
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jun 1 14:02:29 2018 -0700

    [DBI Backend] If there's a set error value use that to set the backend error.

commit f504e39d7818f0f8e74b00aeb838366540afd931
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jun 1 14:00:52 2018 -0700

    Correct the type of error variables.
    
    C++ doesn't like interchanging enums and ints.

commit 464fdeeb262ae5153b19e7b884790f5cb210c7aa
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jun 1 13:59:06 2018 -0700

    [DBI Backend] Remove unused TableOpTypes.

commit f77e6e34c41a12a29d0f9047bf8ef97c00178bb5
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 31 12:02:28 2018 +0100

    Bug 796083 - Reconcile view toggle not being drawn correctly
    
    Out of site toggles on selected rows may not appear correctly drawn so
    queue a draw for the tree view widget after the model has been updated.

commit 5ff642e3a3982eef2bc2f91b1f753086c756ef80
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 31 10:51:16 2018 +0100

    Remove some white space from gnc-budget-view.c

commit 2a28c682a90ccbda49fe03125ea3417e05b5f26c
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 31 10:48:36 2018 +0100

    Adjust Budget editor totals column width
    
    Totals column width is based on the larger of header title or column
    content so with a header of "Total" and a column value of 700.00 there
    is not much space between the previous column and the totals column so
    set a minimum width based on the previous column header.

commit 6730d1420c3b26db02b61f1fffaefde0e48d2f27
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 31 09:51:44 2018 +0100

    Budget editor total column label alignment
    
    Align the column header label to that of the column.

commit 15ab1ef33039f280a6933771a3e580ccfb9f5847
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 31 09:44:31 2018 +0100

    Bug 795471 - Budget editor resize problems
    
    In the original configuration, if you start with a wide account column
    and drag it smaller and then make entry it pings back. The reason for
    this is that the space is added to the total column to compensate as
    the table width can not shrink. This can be fixed by removing the
    viewport and stacking two scroll windows in a vbox and linking the
    horizontal scrollbars.

commit 74cbde2d4f8822c330e0eb75777d3e6c1758a58b
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon May 28 08:56:01 2018 -0700

    normalize date formats the C++ way.

commit 69c81565682880df118e71143c0103739ab78294
Author: Keve Müller <keve.mueller at gmail.com>
Date:   Mon May 28 12:15:31 2018 +0200

    Small XML related fixes removing ambiguity improving uniformity
    
    acctchrt_common:
    there is a gratituous "i"
    
    acctchrt_full (ja):
    the Retirement and Spouse's retirement accounts have two parents
    (Investment as well as ROOT), removed ROOT.
    
    uk-vat:
    the root account was pasted a line too high 7y ago. all other files have
    the header block continuous

commit 174752e28c83787eeb15f0ccfc77f60b7a3087f4
Merge: aa08689 8b1b25a
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat May 26 18:10:02 2018 -0700

    Merge Bill Nottingham's 'bad-dates' into maint

commit aa08689371bce86590ab7557d9cd81040d354a50
Merge: 5c0f56b 396c955
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat May 26 16:35:58 2018 -0700

    Merge Paul Wassi's "Fix Permanent Storage" PR into maint.

commit 5c0f56b05538c9085b537c35f9841b2275819000
Merge: 6b5ee8f 075021a
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat May 26 10:39:48 2018 -0700

    Merge Ryan Schmidt's 'case-sensitive' into maint

commit 6b5ee8f5e89837588267bf1f4eb94addcd181d2c
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat May 26 10:32:14 2018 -0700

    Bug 796409 - Incorrect Current Value for Stocks
    
    This is in the register summary bar. Missed calculating the value in
    8877f86.

commit 075021a88d2001546754097de8880251a7e085a0
Author: Ryan Schmidt <git at ryandesign.com>
Date:   Sat May 26 11:45:45 2018 -0500

    Fix build on case-sensitive filesystems

commit 243bf8afce7b19dcb1bc869f708ad5c99bd53275
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri May 25 12:58:39 2018 -0700

    Bug 796369 - Notes lost or perhaps just not displaying when using...
    
    SQLite backend.
    
    Release Note: This bug caused data loss if you saved your SQLite3
    database to a different file or database.
    
    The problem is that in SQLite3 (though not in MySQL or PgSQL) the
    subquery ((SELECT DISTINCT guid FROM transactions)) (note the double
    parentheses) returns only the first guid in the subquery's results.
    
    Some transactions are loaded by special queries and those queries are
    also used to retrieve the transaction's slots so they weren't affected.

commit 5708707f6c30702e1382d1e528298ae0472c7360
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri May 25 09:18:06 2018 -0700

    Fix misplaced try block that caused unhandled exception if year out of range.

commit 396c955fd59516e2f80f4252f062cb26a9f8f182
Author: Paul Wassi <p.wassi at gmx.at>
Date:   Fri May 25 01:53:32 2018 +0200

    Fix permanent storage of vendor details.
    
    Since the data types did not match for the billterms and taxtable,
    those references/guids were not saved to the database.

commit 5389aa22ab8c161eabcba4714e350344cd00478b
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu May 24 18:54:44 2018 +0200

    Update invoice reports to use totals calculate by gncInvoice
    
    This should give a consistent representation of invoice data across the application.

commit fcabf6bb9661e4566d3da4b1c30ca8c0e1e2a75b
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu May 24 18:53:15 2018 +0200

    A more detailed revision of gncEntry and gncInvoice related rounding
    
    First change is to ensure gncEntry rounding is consistent. Internally
    calculated values in the entry are never rounded. Consumers of
    gncEntry's calculated values can request them either rounded or not.
    
    Next use a pragmatical approach for calculating values on invoices based on
    the entry values: do the rounding such that we never
    create an unbalanced transaction while posting
    That means
    - round each entry's net value before summing them in net total
    - accumulate all tax totals on invoice level per tax account before rounding
      and round before before summing them in a global tax total
    
    Hopefully this will catch a few more rounding issues in this area.
    
    A complete solution can only offered if we allow users to manually correct
    tax entries. This requires changes to user interface and data format
    so that's not going to happen in gnucash 3.x.

commit 8b1b25aee52d3c844a4cbecba7c80b3cd5d8627b
Author: Bill Nottingham <notting at splat.cc>
Date:   Tue May 22 23:37:22 2018 -0400

    Modify date formatters to strip out certian specifiers.
    
    strptime/strftime supports various modifiers to their parameters.
    
     'E' and 'O': alternate locale-specific formats
     (used in default format for Persian, Oriya, Azerbaijani)
     '-': padding
     (used in default format for Czech)
    
    GnuCash passes dates as integer y/m/d without using locale-specific
    formats, so we need to strip out 'E' and 'O' from the format when
    scanning dates or determining separators in gnc-date.
    
    None of '-', 'E', or 'O' are supported by boost (and '-' causes
    errors), so strip them out from formatters in gnc-datetime as well.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=795247.

commit 2e8df1984aacfb3342b86f63d0314a4147267369
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 19 20:23:20 2018 +0200

    Improve rounding for invoice entry values
    
    This will probably need more refinement because the multiplications
    are still missing rounding methods, but the changes in this commit
    will already allow guile code to correctly create entries.

commit 519ce9fb81d4ad24ae4a5849a0b1ea46057e0a94
Author: Bill Nottingham <notting at splat.cc>
Date:   Wed May 16 22:16:20 2018 -0400

    Fix some copy-pasted code.

commit 5f5ad968f985dd1efff90f39bffe9364945861ee
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue May 15 16:57:08 2018 -0700

    Bug 796079 - Repeatable Crash in Tax Report Options.

commit 3ac0f4a3fd63f8c5950313792d3a3ee9895c453a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon May 14 23:35:48 2018 +0800

    Bug 796081 Tax Schedule Report - An error occurred while running the report
    
    Missed out from timepair->time64 conversion.

commit 53a17fe77c60c975d33c8ed79e83c64175b223f4
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 12 17:40:03 2018 +0200

    New Dutch translation imported from the Translation Project

commit 324c9adfd2dbee64ceffe0036d7e6a61d2b45c25
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 12 16:50:02 2018 +0200

    Bug 795519 - Credit card payment after reconciliation
    
    The transfer dialog was set up as a child of the reconciliation dialog.
    However as the latter is closed it's child dialogs are closed as well.
    At least that's the behaviour on Windows. This didn't happen on Fedora 27.
    Regardless it's fixed by making the account register the parent of the transfer
    dialog.



Summary of changes:
 CMakeLists.txt                                     |     2 +-
 data/accounts/ca/acctchrt_common.gnucash-xea       |     2 +-
 data/accounts/en_GB/uk-vat.gnucash-xea             |     2 +-
 data/accounts/ja/acctchrt_full.gnucash-xea         |     6 +-
 gnucash/gnome-utils/gnc-gnome-utils.c              |     3 +-
 gnucash/gnome-utils/gnc-main-window.c              |    22 +-
 gnucash/gnome-utils/gnc-tree-view.c                |    46 +-
 gnucash/gnome/dialog-tax-info.c                    |     6 +
 gnucash/gnome/gnc-budget-view.c                    |   176 +-
 gnucash/gnome/gnc-plugin-page-register.c           |    29 +-
 gnucash/gnome/gnc-split-reg.c                      |    15 +-
 gnucash/gnome/reconcile-view.c                     |     3 +
 gnucash/gnome/window-reconcile.c                   |     2 +-
 gnucash/register/ledger-core/gncEntryLedger.c      |    13 +-
 gnucash/register/register-core/table-allgui.h      |     2 +-
 gnucash/register/register-gnome/table-gnome.c      |     8 +-
 gnucash/report/business-reports/easy-invoice.scm   |   135 +-
 gnucash/report/business-reports/fancy-invoice.scm  |   142 +-
 gnucash/report/business-reports/invoice.scm        |   136 +-
 gnucash/report/business-reports/receipt.eguile.scm |    25 +-
 .../report/business-reports/taxinvoice.eguile.scm  |    27 +-
 gnucash/report/locale-specific/us/taxtxf.scm       |     2 +-
 libgnucash/backend/dbi/gnc-backend-dbi.hpp         |    10 +-
 libgnucash/backend/dbi/gnc-dbisqlconnection.cpp    |   187 +-
 libgnucash/backend/dbi/gnc-dbisqlconnection.hpp    |    10 +-
 libgnucash/backend/dbi/gnc-dbisqlresult.cpp        |     6 +-
 libgnucash/backend/dbi/gnc-dbisqlresult.hpp        |     2 +-
 libgnucash/backend/sql/gnc-slots-sql.cpp           |     6 +-
 .../backend/sql/gnc-sql-column-table-entry.cpp     |     2 +-
 .../backend/sql/gnc-sql-column-table-entry.hpp     |    31 +
 libgnucash/backend/sql/gnc-sql-connection.hpp      |     3 +-
 libgnucash/backend/sql/gnc-sql-result.hpp          |     4 +-
 libgnucash/backend/sql/gnc-transaction-sql.cpp     |     4 +-
 .../backend/sql/test/utest-gnc-backend-sql.cpp     |     4 +-
 libgnucash/engine/gnc-date.cpp                     |    47 +-
 libgnucash/engine/gnc-datetime.cpp                 |    36 +-
 libgnucash/engine/gncEntry.c                       |    88 +-
 libgnucash/engine/gncEntry.h                       |     3 +-
 libgnucash/engine/gncInvoice.c                     |   169 +-
 libgnucash/engine/gncInvoice.h                     |     3 +
 libgnucash/engine/gncTaxTable.c                    |     4 +-
 libgnucash/engine/gncVendor.c                      |     4 +-
 libgnucash/engine/test/utest-Entry.c               |   175 +-
 po/nl.po                                           | 40080 +++++++++----------
 44 files changed, 19955 insertions(+), 21727 deletions(-)



More information about the gnucash-patches mailing list