gnucash unstable: Multiple changes pushed
Geert Janssens
gjanssens at code.gnucash.org
Thu Mar 8 12:57:08 EST 2018
Updated via https://github.com/Gnucash/gnucash/commit/25883b17 (commit)
via https://github.com/Gnucash/gnucash/commit/563d7161 (commit)
via https://github.com/Gnucash/gnucash/commit/b577a7da (commit)
via https://github.com/Gnucash/gnucash/commit/751a3fec (commit)
via https://github.com/Gnucash/gnucash/commit/e71f5612 (commit)
via https://github.com/Gnucash/gnucash/commit/6fe7d885 (commit)
via https://github.com/Gnucash/gnucash/commit/89c1534d (commit)
via https://github.com/Gnucash/gnucash/commit/1449d4ca (commit)
from https://github.com/Gnucash/gnucash/commit/f8fd9dd2 (commit)
commit 25883b17ebba418a9100bc9fa3d531f21d80a769
Author: Carsten Rinke <carsten.rinke at gmx.de>
Date: Sun Sep 17 13:16:21 2017 +0200
Bug764245 - multi-column reports include incorrect sub-reports
commit 563d7161610d8d44c9e047a25e1a33ce0d3e85ff
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 17:59:48 2018 +0100
Csv imp settings - internalize prefix handling
This information is not relevant outside of the settings code
The way it's implemented now each settings module defines its
own unique prefix and the generic code can just use it when
needed.
commit b577a7daf1b2e878bece8a799ddfafaeb6a0f689
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 17:20:13 2018 +0100
Csv import settings - undo rename of common methods
Use C++-style to call method with same name in parent class
commit 751a3fec43a9740b842e0f5f4ea148fd47a9ea4e
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 17:12:31 2018 +0100
Csv importer - align file names
Done in a separate commit
commit e71f561236787f0ca7d1bb812c5959d0c83476a8
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 15:31:12 2018 +0100
Bug 793467 - GnuCash crashes when trying to open a binary file instead of a CSV
The cause was an uncaught exception from boost::tokenizer.
Fix and add test case.
commit 6fe7d8854836ceea2b58914511b7743b2dcdd1d4
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 14:24:02 2018 +0100
Enable test to handle attempt to load non-existing file in csv importer
commit 89c1534d5184cd3f499fc8e3e654b8eb43583e1b
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 14:06:33 2018 +0100
Csv import - improve memory handling in the assistant class
Make it more RAII, in that whatever the class allocates, it should
also deallocate. This simplifies a couple of memory handling cases.
The only exception is the generic import matcher that for some reason
has chosen to deallocate itself. To be fixed when more importers are
converted to c++
commit 1449d4ca688bd41691d7854eae40574eef230b5e
Author: Geert Janssens <geert at kobaltwit.be>
Date: Thu Mar 8 10:46:07 2018 +0100
Add some background info on memory management in CSV importers
As the assistant code combines multiple memory management models care should be taken
not to mix them up. The notes should give some insights in how to do this.
Also fix a few minor issues
- delete default copy and move constructor/assignment for the assistant gui class
- nullify a freed pointer
Summary of changes:
.../gtkbuilder/assistant-csv-price-import.glade | 12 +-
.../gtkbuilder/assistant-csv-trans-import.glade | 6 +-
gnucash/import-export/csv-imp/CMakeLists.txt | 40 +++---
.../csv-imp/assistant-csv-price-import.cpp | 54 ++++----
.../csv-imp/assistant-csv-trans-import.cpp | 142 ++++++++++++++++-----
.../import-export/csv-imp/gnc-csv-tokenizer.cpp | 67 ----------
...gnc-price-props.cpp => gnc-imp-props-price.cpp} | 6 +-
...gnc-price-props.hpp => gnc-imp-props-price.hpp} | 6 +-
.../{gnc-trans-props.cpp => gnc-imp-props-tx.cpp} | 4 +-
.../{gnc-trans-props.hpp => gnc-imp-props-tx.hpp} | 4 +-
...settings.cpp => gnc-imp-settings-csv-price.cpp} | 30 +++--
...settings.hpp => gnc-imp-settings-csv-price.hpp} | 11 +-
...rt-settings.cpp => gnc-imp-settings-csv-tx.cpp} | 30 +++--
...rt-settings.hpp => gnc-imp-settings-csv-tx.hpp} | 11 +-
...mport-settings.cpp => gnc-imp-settings-csv.cpp} | 23 ++--
...mport-settings.hpp => gnc-imp-settings-csv.hpp} | 16 +--
.../{gnc-price-import.cpp => gnc-import-price.cpp} | 12 +-
.../{gnc-price-import.hpp => gnc-import-price.hpp} | 8 +-
.../{gnc-tx-import.cpp => gnc-import-tx.cpp} | 14 +-
.../{gnc-tx-import.hpp => gnc-import-tx.hpp} | 8 +-
.../import-export/csv-imp/gnc-tokenizer-csv.cpp | 78 +++++++++++
...gnc-csv-tokenizer.hpp => gnc-tokenizer-csv.hpp} | 4 +-
...dummy-tokenizer.cpp => gnc-tokenizer-dummy.cpp} | 2 +-
...dummy-tokenizer.hpp => gnc-tokenizer-dummy.hpp} | 7 +-
.../{gnc-fw-tokenizer.cpp => gnc-tokenizer-fw.cpp} | 2 +-
.../{gnc-fw-tokenizer.hpp => gnc-tokenizer-fw.hpp} | 4 +-
gnucash/import-export/csv-imp/gnc-tokenizer.cpp | 6 +-
gnucash/import-export/csv-imp/gnc-tokenizer.hpp | 2 +-
.../import-export/csv-imp/test/test-tokenizer.cpp | 34 +++--
.../import-export/csv-imp/test/test-tx-import.cpp | 6 +-
gnucash/report/report-system/report.scm | 102 ++++++++++++---
po/POTFILES.in | 20 +--
32 files changed, 474 insertions(+), 297 deletions(-)
delete mode 100644 gnucash/import-export/csv-imp/gnc-csv-tokenizer.cpp
rename gnucash/import-export/csv-imp/{gnc-price-props.cpp => gnc-imp-props-price.cpp} (98%)
rename gnucash/import-export/csv-imp/{gnc-price-props.hpp => gnc-imp-props-price.hpp} (95%)
rename gnucash/import-export/csv-imp/{gnc-trans-props.cpp => gnc-imp-props-tx.cpp} (99%)
rename gnucash/import-export/csv-imp/{gnc-trans-props.hpp => gnc-imp-props-tx.hpp} (98%)
rename gnucash/import-export/csv-imp/{gnc-csv-price-import-settings.cpp => gnc-imp-settings-csv-price.cpp} (92%)
rename gnucash/import-export/csv-imp/{gnc-csv-price-import-settings.hpp => gnc-imp-settings-csv-price.hpp} (92%)
rename gnucash/import-export/csv-imp/{gnc-csv-trans-import-settings.cpp => gnc-imp-settings-csv-tx.cpp} (92%)
rename gnucash/import-export/csv-imp/{gnc-csv-trans-import-settings.hpp => gnc-imp-settings-csv-tx.hpp} (92%)
rename gnucash/import-export/csv-imp/{gnc-csv-import-settings.cpp => gnc-imp-settings-csv.cpp} (94%)
rename gnucash/import-export/csv-imp/{gnc-csv-import-settings.hpp => gnc-imp-settings-csv.hpp} (93%)
rename gnucash/import-export/csv-imp/{gnc-price-import.cpp => gnc-import-price.cpp} (99%)
rename gnucash/import-export/csv-imp/{gnc-price-import.hpp => gnc-import-price.hpp} (97%)
rename gnucash/import-export/csv-imp/{gnc-tx-import.cpp => gnc-import-tx.cpp} (99%)
rename gnucash/import-export/csv-imp/{gnc-tx-import.hpp => gnc-import-tx.hpp} (97%)
create mode 100644 gnucash/import-export/csv-imp/gnc-tokenizer-csv.cpp
rename gnucash/import-export/csv-imp/{gnc-csv-tokenizer.hpp => gnc-tokenizer-csv.hpp} (96%)
rename gnucash/import-export/csv-imp/{gnc-dummy-tokenizer.cpp => gnc-tokenizer-dummy.cpp} (94%)
rename gnucash/import-export/csv-imp/{gnc-dummy-tokenizer.hpp => gnc-tokenizer-dummy.hpp} (91%)
rename gnucash/import-export/csv-imp/{gnc-fw-tokenizer.cpp => gnc-tokenizer-fw.cpp} (99%)
rename gnucash/import-export/csv-imp/{gnc-fw-tokenizer.hpp => gnc-tokenizer-fw.hpp} (97%)
More information about the gnucash-patches
mailing list