gnucash master: Multiple changes pushed

Geert Janssens gjanssens at code.gnucash.org
Sat May 12 08:11:13 EDT 2018


Updated	 via  https://github.com/Gnucash/gnucash/commit/61071b9f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/61fe6478 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/7f91cb82 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fc963f87 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/836705f9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/388a4906 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5e1c8e91 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9eedea71 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/66fcaa4f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bb551af9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4e851026 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4c55141d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ded88b01 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1df7fb40 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d4cb87fe (commit)
	 via  https://github.com/Gnucash/gnucash/commit/23410ca4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/97ab1b19 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/13f31e06 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5e0fc04f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8ddee964 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c6032ac6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/dda6730c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4a27285e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/44a568bc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fd028716 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d68ccc33 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ac510d13 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4b9ec663 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f82e5a5b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f89f00f5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4a7bc0b5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2102c55b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b95fa5ba (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6210b80f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6e78fa1d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2e53d647 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1f3cf845 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/27c1df30 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/682b5cf5 (commit)
	from  https://github.com/Gnucash/gnucash/commit/435b0ace (commit)



commit 61071b9f6d9b912ca6418b1b7018e6a3e6fcc6f2
Merge: 435b0ac 61fe647
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 12 14:10:38 2018 +0200

    Merge branch 'maint'

commit 61fe647828e806667659ed63f64be9e16b3b31ed
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 12 14:07:26 2018 +0200

    Use lowercase for account type descriptions

commit 7f91cb82d7ef07177085b714ffa53dc5233fbb8f
Merge: fc963f8 388a490
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 12 14:07:59 2018 +0200

    Merge branch 'scheme-progress' of https://github.com/christopherlam/gnucash into maint

commit fc963f877cd725ee4e561530e2deb0f9bba6e515
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Tue May 1 15:11:16 2018 +0100

    Change the right margin setting for reconcile totals
    
    Change the margin setting from the gtk box to the label so it looks
    correct when styled.

commit 836705f98087ec7bf9418cef71af939fcff6a393
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Tue May 1 15:07:46 2018 +0100

    Bug 795101 - Fix the reconcile window sort order
    
    When the reconcile column was moved, the default sort order was not
    altered for the change so fixed it. Also added enum so model columns
    can be referenced by name which hopefully will make it easier to read.

commit 388a4906b05740b507582b8eda9b264d8a357bfa
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri May 11 16:39:00 2018 +0800

    gnc:options->sxml allow alphanumeric in test filename

commit 5e1c8e91321ad07ffc6c2e45823315d44773434c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu May 10 22:52:43 2018 +0800

    business-reports/*.scm: close tags to make valid XHTML
    
    This will be important for testing.

commit 9eedea71ea1871fdc8d926fe2376b1105291b06a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed May 9 20:30:34 2018 +0800

    test-GSTR: implementation testing for GST Report

commit 66fcaa4f91566a5737cfeb3afa8dbb4b3ee5bf47
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed May 9 20:36:40 2018 +0800

    test-extras.scm: centralize (sxml->table-row-col)
    
    This is used in conjunction with (gnc:options->sxml) to extract
    html table cells.
    
    From SXML tree, retrieve, from a <table>, the th/tr/td cells as a list
    of string.

commit bb551af9482b786088086ba2eabf1ada3cd778a7
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 8 23:52:24 2018 +0800

    collectors.scm: rewrite binary-search-lt to be clearer

commit 4e85102682909c68cbf8612aa0df0fd7d65c9603
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 8 23:47:46 2018 +0800

    report-system/cmakelists: fix scm_test_report_system_SOURCES
    
    These tests were disabled by mistake in cbd87647806ca3700d2ead8a6623b758a07ba2a7

commit 4c55141d963452a2381a5bd5b3d4fe31bde2cd2c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 8 23:05:59 2018 +0800

    html-utilities.scm: simplify

commit ded88b01dd4e9a80000eca2736a81e66567dc260
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 8 23:03:46 2018 +0800

    list-extras.scm: trim useless utility functions
    
    These functions are either better defined in R5RS (list-min-max),
    unused (function-compose), or being defined in the .scm using
    them (list-leaves).

commit 1df7fb4048e8484fae4305d185e39a57305455ef
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 8 22:41:12 2018 +0800

    html-text.scm: schemify

commit d4cb87fe3d923cc6490168a27f91a24b65a02553
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun May 6 17:26:28 2018 +0800

    business-report/test: create test directory
    
    These tests will all be SRFI-64 based.

commit 23410ca429aead77deeb271416bd461598f3bfdf
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun May 6 23:39:45 2018 +0800

    html-table.scm: centralize (gnc:html-table-set-last-row-style!)
    
    This html-table modifier seems common enough to centralize into
    html-table.scm.

commit 97ab1b19fe081e06fe59d994294ae34e70291f75
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat May 5 23:07:52 2018 +0800

    test-date-utilities.scm: to SRFI64
    
    Clearer syntax helped find flawed test - while set-tm:mday directly
    accepts 1-31, set-tm:mon accepts 0-11 to represent 1-12, therefore
    must minus 1. set-tm:year accepts 92 to represent 1992, therefore must
    minus 1900.

commit 13f31e0691a60af2c1b1e70152060bb76bec92b6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon May 7 19:04:22 2018 +0800

    test-extras.scm: (logging-and) is obsolete
    
    Use the much nicer SRFI-64 forms instead.

commit 5e0fc04f7ba8df4ed28823cc9248b5dae7c66f4c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun May 6 22:58:38 2018 +0800

    test-extras.scm: remove dead code
    
    These functions are never used through code.

commit 8ddee96463795fd89ad6ca8359c1a64911feb361
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun May 6 20:44:36 2018 +0800

    test-extras.scm: centralize (gnc:options->sxml)
    
    I think this is useful enough to be upgraded.

commit c6032ac6ed52f44b112dee4c5cf0ed9d261a437e
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun May 6 20:43:32 2018 +0800

    srfi64-extras.scm: centralize (gnc:test-runner)
    
    This is good enough to be used widely.

commit dda6730c44b82df6881baa083d78a87da4a916c6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu May 3 08:52:59 2018 +0800

    utilities.scm: centralize and modernize addto!
    
    (define-macro) is discouraged in most scheme forms. Change
    to (define-syntax), and centralize common macro to utilities.scm

commit 4a27285edd956b37f54eb2f9c94b144f5b48edb7
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Apr 29 07:32:20 2018 +0800

    html-utilities.scm: new home (gnc:html-render-options-changed)
    
    We want to sanitize render-options-changed, therefore it must return
    an html-object. Unfortunately this is not accessible to
    app-utils/options.scm. If we move this function to
    report-system/html-utilities.scm, it can access html-objects.
    
    Also rename it to gnc:html-render-options-changed

commit 44a568bc457022a4bea7c8b55d304e80a11aa6ba
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Apr 29 18:36:49 2018 +0800

    GSTR: sanitize string
    
    Instead of returning raw html string, return an html-object.

commit fd02871678a79653880e9a6dca7892edd0bf569a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu May 3 17:19:36 2018 +0800

    TR: sanitize string
    
    This will change the HTML slightly, so, requires an update to the test
    suite.

commit d68ccc330628d56178d2dd0d83bde8d084663ba6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu May 3 21:59:22 2018 +0800

    TR: rename some variable names to be more descriptive
    
    The previous names were remnants of old transaction.scm and were not
    exactly consistent. Use more descriptive names.
    
    The only user-visible change is elimination of <br/> in the
    common-currency account header, because this will be sanitized.  The
    table col-headers cannot unfortunately accept a (gnc:make-html-text)
    object therefore we cannot add <br/> at all. I vote to display
    e.g. "Debit (USD)" instead.

commit ac510d13be9e7522c5762378b79d3cf0422aeac1
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jan 19 15:22:48 2018 +0800

    TR: (ENH) add Closing-status filter, enable it by default
    
    This commit will add a filter to include/exclude closing
    transactions. In conventional reports, they are usually disruptive to
    the regular periodic reporting and the default ensures they are not
    included.
    
    This commit also changes income-gst-report.scm to use the closing
    filter just created, and disable its UI.

commit 4b9ec663f7a050a2cfea23729ab5fca6c20dcdcf
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu May 3 13:46:09 2018 +0800

    TR: (ENH) do not add headers if hiding transaction data

commit f82e5a5b4b2d7f110af8041dad4a4af7ebbde368
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 1 21:07:07 2018 +0800

    TR: (ENH) enable subtotal/grouping for Split Memo

commit f89f00f59d375bd313426b45ec34cdd944b685a6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 1 21:05:55 2018 +0800

    TR: (ENH) enable subtotal/grouping for Transaction Description

commit 4a7bc0b53d434cd72f4ed58ae687a16f8bfc0046
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 1 21:06:54 2018 +0800

    TR: (ENH) enable subtotal/grouping for Transaction Notes

commit 2102c55bb7ad5216537c553c0d6189033322a8e1
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 1 23:44:50 2018 +0800

    TR: (centralize) centralize custom-sorter split comparators
    
    This commit will modify the custom sorter to reuse 'split-sortvalue
    comparators. The original purpose of these functions was to *compare*
    splits *during* table generation to determine whether a subtotal group
    was changed. These functions can be easily reused by the custom sorter
    to *sort* splits *before* table generation.
    
    Also modify the sortkey renderer logic to catch all non-date,
    non-account sortkeys into the generic string renderer.

commit b95fa5ba8cd6a8cdd4416504f52a36529fa4ce05
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 1 20:41:38 2018 +0800

    TR: (simplify) dynamically check CUSTOM-SORTING?
    
    Instead of a list needing manual adjustments, this function will check
    if sortkey requires custom sorter, depending on sortkey capabilities.

commit 6210b80fd0b94d9504cef688a3769d638539393d
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 1 19:08:56 2018 +0800

    TR: (simplify) dynamically check SUBTOTAL-ENABLED?
    
    This function checks whether the sortkey can be grouped. Instead of
    manually creating list, test it dynamically.
    
    Sortkeys whose 'renderer-fn is defined can be grouped.

commit 6e78fa1d99936244fd74772fc3a329fd8120168c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed May 2 22:54:31 2018 +0800

    test-TR: change report out filenames
    
    This will allow easier addition of tests.
    
    Also fix (use-modules) usage. VM is only needed for coverage reporting.

commit 2e53d647263c20a9e1a9a7fd6893ec7ef186280f
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Wed May 9 17:39:29 2018 +0200

    Work around gtk warnings with gcc 8.0

commit 1f3cf845c4588e787f9b26ad06b05d7cd73326b7
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Wed May 9 17:20:13 2018 +0200

    Work around a conflict between gcc 8.0 and swig 3.0
    
    The swig 3.0 generated python wrappers trigger a warning converted into an error issued
    by gcc 8.0 for using strncpy as follows:
    strncpy(buff, "swig_ptr: ", 10);
    The reason is this call will truncate the trailing null byte from the string.
    This appears to have been fixed in swig master already but that's not released yet
    so let disable the warning when compiling the swig wrappers until it is.

commit 27c1df30afda7998c8f1dccd3253fb53a95fbe8e
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 5 13:42:13 2018 +0200

    Handle the common csv double quote escape variation (repeating the double quote)

commit 682b5cf581895a5da3296cfbfc24acc9ece0185e
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat May 5 12:42:17 2018 +0200

    Bug 795666 - Backslash "\" in Description field spoils CSV Import without helpful error message
    
    We've configure boost::tokenizer to take the backslash as the escape character
    However boost::tokenizer will throw if it encounters a sole backslash that's
    not an escape (it would expect two if a pure backslash is to be inserted).
    Avoid this by replacing lone backslashes (not part of escapes) with double
    backslashes before passing control to the tokenizer.



Summary of changes:
 CMakeLists.txt                                     |  11 +-
 bindings/python/CMakeLists.txt                     |   6 +
 common/test-core/CMakeLists.txt                    |   3 +
 gnucash/gnome/reconcile-view.c                     |  29 +--
 gnucash/gnome/reconcile-view.h                     |  10 +
 gnucash/gnome/window-reconcile.c                   |  16 +-
 gnucash/gnome/window-reconcile2.c                  |  10 +-
 .../import-export/csv-imp/gnc-tokenizer-csv.cpp    |  23 ++
 .../import-export/csv-imp/test/test-tokenizer.cpp  |  14 +-
 gnucash/report/business-reports/CMakeLists.txt     |   1 +
 .../report/business-reports/customer-summary.scm   |  20 +-
 gnucash/report/business-reports/easy-invoice.scm   |  27 +--
 gnucash/report/business-reports/fancy-invoice.scm  |  19 +-
 gnucash/report/business-reports/invoice.scm        |  33 +--
 gnucash/report/business-reports/job-report.scm     |  14 +-
 gnucash/report/business-reports/owner-report.scm   |  20 +-
 gnucash/report/business-reports/receipt.scm        |   2 +-
 gnucash/report/business-reports/taxinvoice.scm     |   2 +-
 .../report/business-reports/test/CMakeLists.txt    |  31 +++
 gnucash/report/report-system/CMakeLists.txt        |   1 -
 gnucash/report/report-system/collectors.scm        |  24 +-
 gnucash/report/report-system/html-table.scm        |   7 +
 gnucash/report/report-system/html-text.scm         |  12 +-
 gnucash/report/report-system/html-utilities.scm    |  71 +++++-
 gnucash/report/report-system/list-extras.scm       |  47 ----
 gnucash/report/report-system/report-collectors.scm |   7 +-
 gnucash/report/report-system/report-system.scm     |   2 +
 gnucash/report/report-system/test/CMakeLists.txt   |   5 +-
 gnucash/report/report-system/test/test-extras.scm  | 128 +++++-----
 .../test/test-html-utilities-srfi64.scm            |  30 +--
 .../report/report-system/test/test-list-extras.scm |  42 ----
 .../report/report-system/test/test-test-extras.scm |   5 +-
 .../standard-reports/income-gst-statement.scm      |  28 ++-
 gnucash/report/standard-reports/register.scm       |  14 +-
 .../report/standard-reports/test/CMakeLists.txt    |   1 +
 .../test/test-cashflow-barchart.scm                |   6 +-
 .../test/test-generic-net-barchart.scm             |  16 +-
 .../test/test-generic-net-linechart.scm            |  10 +-
 .../standard-reports/test/test-income-gst.scm      | 213 +++++++++++++++++
 .../standard-reports/test/test-transaction.scm     | 228 ++++++++----------
 gnucash/report/standard-reports/transaction.scm    | 266 ++++++++++++---------
 libgnucash/app-utils/CMakeLists.txt                |   3 +
 libgnucash/app-utils/app-utils.scm                 |   1 -
 libgnucash/app-utils/options.scm                   |  58 -----
 libgnucash/app-utils/test/CMakeLists.txt           |   8 +
 libgnucash/app-utils/test/test-date-utilities.scm  |  70 +++---
 libgnucash/core-utils/CMakeLists.txt               |   4 +
 libgnucash/engine/test/CMakeLists.txt              |  15 ++
 libgnucash/engine/test/srfi64-extras.scm           |  49 ++++
 libgnucash/engine/test/test-extras.scm             |  87 +------
 libgnucash/engine/test/test-test-extras.scm        |   5 +-
 libgnucash/scm/utilities.scm                       |   5 +
 po/POTFILES.in                                     |   1 -
 53 files changed, 931 insertions(+), 829 deletions(-)
 create mode 100644 gnucash/report/business-reports/test/CMakeLists.txt
 delete mode 100644 gnucash/report/report-system/list-extras.scm
 delete mode 100644 gnucash/report/report-system/test/test-list-extras.scm
 create mode 100644 gnucash/report/standard-reports/test/test-income-gst.scm
 create mode 100644 libgnucash/engine/test/srfi64-extras.scm



More information about the gnucash-patches mailing list