gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/263c5a40 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b59e2096 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d0bbb5a2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0fc84ddb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a603ea33 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a8326001 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f1e8de68 (commit)
	from  https://github.com/Gnucash/gnucash/commit/105ea8e9 (commit)



commit 263c5a40ea88cdc974fc45af2e1674decf431c34
Merge: 105ea8e b59e209
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Oct 29 13:06:25 2018 -0700

    Merge Chris Lam's 'maint-scheme-progress' into maint.

commit b59e2096182f0356ee97a850b35399f131461383
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Oct 20 13:33:24 2018 +0800

    [test-extras] gnc-pricedb-create skips if commodity = currency

commit d0bbb5a2a800ed612f64a82062eb3946a432ec74
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Oct 18 14:10:36 2018 +0800

    [report-utilities] deprecate gnc:account-get-balance-at-date.
    
    I think (gnc:account-get-balance-at-date) is flawed. It is actually
    unused, so, it should be safe to remove. It needs to be deprecated.
    Reports use xaccAccountGetBalanceAsOfDate instead, which does not
    retrieve sub-acct balances.
    
    I think this (gnc:account-get-balance-at-date) is flawed in sub-acct handling.
    Consider account structure:
    Assets [USD] - bal=$0
       Bank [USD] - bal=$100
       Broker [USD] - bal=$200
          Cash [USD] - bal=$800
          Funds [FUND] - bal=3 FUND @ $1000 each = $3000
    
    - Calling (gnc:account-get-balance-at-date BANK TODAY #f) returns 100
    - Calling (gnc:account-get-balance-at-date BROKER TODAY #f) returns 200
    - Calling (gnc:account-get-balance-at-date BROKER TODAY #t) returns 1000
      this is because although it counts all subaccounts bal $200 + $800 + 3FUND,
      it retrieves the parent account commodity USD $1000 only.

commit 0fc84ddbcb6bfca3de8bc0f84bcc4d49ff02164a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Oct 17 01:20:52 2018 +0800

    Bug 796914 - Customer Summary is giving error
    
    Bugfix. div/0 was not producing an error previously. This is probably
    caused by changes to gnc_numeric_div.

commit a603ea338011c89cf06358f3f47230879797c6f6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Oct 8 00:23:14 2018 +0800

    [invoice] bugfix img url must have file:/// prefix

commit a8326001822c796b207ac448ee79cbf31ebfa555
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Sep 26 21:46:29 2018 +0800

    [test-transaction] test for display/enable links? feature

commit f1e8de6886efd05013edacf41cdd3cc5d78cd93c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Sep 26 17:46:47 2018 +0800

    [transaction] add option Display/Enable links to toggle hyperlinks
    
    This option is often requested.



Summary of changes:
 .../report/business-reports/customer-summary.scm   |  4 +-
 gnucash/report/business-reports/invoice.scm        |  3 +-
 .../standard-reports/test/test-transaction.scm     | 10 +++++
 gnucash/report/standard-reports/transaction.scm    | 45 ++++++++++++++--------
 libgnucash/engine/test/test-extras.scm             | 28 +++++++-------
 5 files changed, 58 insertions(+), 32 deletions(-)