gnucash maint: Multiple changes pushed

Christopher Lam clam at code.gnucash.org
Tue Apr 23 06:53:49 EDT 2019


Updated	 via  https://github.com/Gnucash/gnucash/commit/d9623b0a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4d8ef9b9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/3815e17e (commit)



commit d9623b0ad1878e0f11d870cd3c47fa2f2fed12d1
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Apr 23 18:46:48 2019 +0800

    [test-utilities] initial commit
    
    Add tests for libgnucash/scm/utilities.scm functions
    
    - tests for list<->vec
    - tests for gnc:substring-replace
    - tests for gnc:substring-replace-from-to
    
      The latter confirms that the comment before the function definition
      is *incorrect* - it describes that substring-replace-from-to will
      start from the 2nd substring for the first substitution, and
      performs 2 substitutions. However the comment illustrates only 1
      substitution. The test suite performs the test according to code
      behaviour, rather than the comment. This issue is moot in practice
      because the end-after is always called with negative in the code
      base.
    
      original comment:
    
    ;;  gnc:substring-replace-from-to
    ;;  same as gnc:substring-replace extended by:
    ;;  start: from which occurrence onwards the replacement shall start
    ;;  end-after: max. number times the replacement should executed
    ;;
    ;;  Example: (gnc:substring-replace-from-to "foobarfoobarfoobar" "bar" "xyz" 2 2)
    ;;           returns "foobarfooxyzfoobar".

commit 4d8ef9b9e461157eaa8f5b19e0198d35e315088f
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Apr 23 06:38:48 2019 +0800

    [report] inline args-to-defn



Summary of changes:
 gnucash/report/report-system/report.scm | 18 +++++-----
 libgnucash/scm/test/test-utilities.scm  | 63 +++++++++++++++++++++++++++++++++
 2 files changed, 71 insertions(+), 10 deletions(-)
 create mode 100644 libgnucash/scm/test/test-utilities.scm



More information about the gnucash-patches mailing list