gnucash maint: Multiple changes pushed

John Ralls jralls at
Sun Apr 28 20:00:03 EDT 2019

Updated	 via (commit)
	 via (commit)
	from (commit)

commit 3feb864691cf855f0fcd0240731eb05206ec2254
Author: John Ralls <jralls at>
Date:   Sun Apr 28 16:59:51 2019 -0700

    Add an optionally-compiled diagnostic console on Windows.

commit 6c7ccbd9e77fd377c8eae97323fbdadd77d3192f
Author: John Ralls <jralls at>
Date:   Sun Apr 28 16:34:58 2019 -0700

    Bug 797134 - Decimal separator: Windows configured as dot,...
    Gnucash shows comma.
    This was introduced by 8f88b7f2b. It turns out that Windows
    implementation of setlocale works only if the POSIX locale environment
    variables (i.e. LC_FOO or LANG) are set, otherwise it returns NULL. We
    were unknowingly relying on Guile to retrieve the Windows environment
    for us and that would do the wrong thing if the user had set the locale
    in the environment file, so 8f88b7f2b restored it... unfortunately to
    the C locale.
    This commit changes the set_win32_thread_locale function to work in
    both directions, setting both locales from the environment variables
    if any are set and calling setlocale with the result of
    GetUserDefaultLocaleName if not.

Summary of changes:
 gnucash/gnucash-bin.c | 117 ++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 95 insertions(+), 22 deletions(-)

More information about the gnucash-patches mailing list