gnucash maint: Multiple changes pushed
Christopher Lam
clam at code.gnucash.org
Wed Dec 11 08:37:43 EST 2019
Updated via https://github.com/Gnucash/gnucash/commit/5f6b9946 (commit)
via https://github.com/Gnucash/gnucash/commit/0212537c (commit)
via https://github.com/Gnucash/gnucash/commit/3efb960d (commit)
from https://github.com/Gnucash/gnucash/commit/60765e38 (commit)
commit 5f6b9946d470636dba99ca6acd78c5ea34e9593e
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Wed Dec 11 19:54:08 2019 +0800
[report-utilities] bugfix: fix overpayment detection
For 1 payment to >1 invoices, previous would miscalculate overpayment.
Old overpayment definition -- from the payment amount, successively
subtract the invoice totals. If remaining is >0, then this is
overpayment. But this fails whereby invoice was partially paid
elsewhere because the overpayment would miss them.
New overpayment definition -- the payment txn is analysed, and all
APAR-splits' lots are analysed. Any lot with no invoice is a
prepayment.
This is a simpler algorithm and does not require the creation and
searching of invoices-and-splits.
commit 0212537cca6bf941f09c61dd34c4072d5ed3caba
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Wed Dec 11 19:54:00 2019 +0800
[new-owner-report] bugfix: fix overpayment detection
For 1 payment to >1 invoices, previous would miscalculate overpayment.
Old overpayment definition -- from the payment amount, successively
subtract the invoice totals. If remaining is >0, then this is
overpayment. But this fails whereby invoice was partially paid
elsewhere because the overpayment would miss them.
New overpayment definition -- the payment txn is analysed, and all
APAR-splits' lots are analysed. Any lot with no invoice is a
prepayment.
commit 3efb960daf319f72b6108ca6632f2a42f19591ff
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Dec 10 18:23:30 2019 +0800
Bug 797521 - Receivable Aging (beta): prepayments logic doesn't work, appears to use incorrect absolute value logic
Overpayments create at least 2 APAR splits (1 for each invoice, and 1
for the overpayment), they were processed multiple times.
Modify query to return unique transactions, thereby ensuring a payment
gets processed once only.
Summary of changes:
gnucash/report/business-reports/new-aging.scm | 2 +-
.../report/business-reports/new-owner-report.scm | 25 +++++++++-------
gnucash/report/report-system/report-utilities.scm | 34 ++++++++++------------
3 files changed, 31 insertions(+), 30 deletions(-)
More information about the gnucash-patches
mailing list