gnucash maint: sort-and-delete-duplicates: change < function to ensure dedupe works

Christopher Lam clam at
Tue Dec 17 17:32:41 EST 2019

Updated	 via (commit)
	from (commit)

commit 92509761a53d5126ef2bf77d819dabd1de690f49
Author: Christopher Lam <christopher.lck at>
Date:   Tue Dec 17 22:09:46 2019 +0800

    sort-and-delete-duplicates: change < function to ensure dedupe works
    sort-and-delete-duplicates require that the < proc can sort elements
    In new-owner-report, previous used split->parent->posted_date for
    sorting during call to sort-and-delete-duplicates. This does not
    guarantee equal elements will be adjacent. Using xaccSplitOrder
    satisfies that guarantee, and splits will be deduped properly.
    Also account and commodity comparison functions similarly defined to
    have consistent code.
    This change will modify the output in some tests (e.g. balsheet-pnl
    will now group currencies and commodities together due to
    string-comparison using gnc-commodity-get-full-name) which must be

Summary of changes:
 gnucash/report/business-reports/new-aging.scm      |  5 ++-
 .../report/business-reports/new-owner-report.scm   |  3 +-
 gnucash/report/report-system/report-utilities.scm  |  7 ++-
 .../standard-reports/test/test-balsheet-pnl.scm    | 51 +++++++++++-----------
 4 files changed, 33 insertions(+), 33 deletions(-)

More information about the gnucash-patches mailing list