gnucash maint: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/6945e1c7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2215dfc5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c6f5e673 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d97d4930 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1a69bf1b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/56bccd1b (commit)
	from  https://github.com/Gnucash/gnucash/commit/12d6ace9 (commit)



commit 6945e1c7d70d8b7ed0ae6287b75ed80ed87f7366
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Feb 20 20:43:48 2019 +0800

    [cash-flow][budget] logic error in sub-accounts handling
    
    Previous logic would cycle through accounts' sub-accounts, and each
    sub-account would be queried for inclusion in accounts; if not
    present, the accounts would be appended by all sub-accounts.
    
    Logic would dictate that only the missing sub-account should be added
    to the accounts list.
    
    No functional change is expected; previous behaviour would generate an
    unnecessarily long resulting accounts list (includes sub-accounts as
    many times as there are sub-accounts).

commit 2215dfc5e1bf052f8fb3ed4096d12f707fd925a8
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jan 26 23:59:18 2019 +0800

    [cash-flow] clean up cash-flow calculator
    
    1. remove split-seen? helper function. use a simple list.
    
    2. they were maintaining 2 lists for in, 2 lists for out. simplify to
    1 list each.
    
    3. convert single-use function to named let
    
    4. remove transaction date filter - transactions were already
    date-filtered by the query prior.
    
    5. use simple lists instead of split/account hash tables. use the
    incredible versatile srfi-1 functions.
    
    6. s-report-value can be defined earlier
    
    7. clean up whitespace so that line maxwidth is 80
    
    8. tests already exist in test-cash-flow.scm

commit c6f5e6736b516d1cf568af60e3418a2027589362
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Feb 20 20:00:38 2019 +0800

    [cash-flow] *untabify/delete-trailing-whitespace/reindent*

commit d97d4930bae2135e71980e0ee5d23a2ab5a6a449
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Jan 28 17:22:23 2019 +0800

    [cash-flow] replace account-in-alist with srfi-1 equivalent

commit 1a69bf1b2f07bb0ebe1aac318a0190cc185eb6b4
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Jan 22 18:53:14 2019 +0800

    [cashflow-barchart] remove srfi-1 aliases

commit 56bccd1b50707389dff77b99912aeb26f2af5f8f
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Feb 20 19:45:10 2019 +0800

    [cashflow-barchart] reuse cash-flow-calc-money-in-out
    
    The (cashflow-barchart-calc-money-in-out) function was copied verbatim
    from cash-flow.scm (apart from the returned list being shorter). reuse
    function from cash-flow.scm.
    
    Test already exists in test-cashflow-barchart.scm



Summary of changes:
 gnucash/report/standard-reports/budget.scm         |   2 +-
 gnucash/report/standard-reports/cash-flow.scm      | 654 +++++++++------------
 .../report/standard-reports/cashflow-barchart.scm  | 131 +----
 3 files changed, 299 insertions(+), 488 deletions(-)