gnucash maint: Multiple changes pushed

Robert Fewell bobit at
Tue Jul 2 06:06:35 EDT 2019

Updated	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit f82058e026bebeb0c9380231b884d2c3140ca11a
Merge: a7bdd0829 690e359be
Author: Robert Fewell <14uBobIT at>
Date:   Tue Jul 2 10:57:23 2019 +0100

    Merge David Cousens's 'Bug797275' branch into maint

commit 690e359be093a7207f646879d8e80a6392f263b3
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 14:12:03 2019 +1000

    Fix view_selection_function declaration
    For some strange reason the view_selection_function declaration went missing?? reinserted it

commit 98cf760c6eb1362dbb7b41b2689c76cbf1aa3a5c
Merge: caeea74b5 377b73d1a
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 13:53:08 2019 +1000

    Merge branch 'matcher-help' into Bug797275

commit 377b73d1aa9f9c263c5887a0c869d2a371bfd142
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 13:42:36 2019 +1000

    Add multiselection info to help dialogue

commit caeea74b5003788a79fd684e50244dac44f11e93
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 07:43:10 2019 +1000

    Add view_selection_function
    view_selection_function added to only allow adding a row to the selection if GNCImport_Add is set for the transaction.
    Explicit selection clearing
    try explicitly clearing the row in the add, update and clear toggle callbacks - before refresh row and add debugging info which showed that the selection is called after exiting the above callbacks and as the view_selection_function has no knowledge that the add checkbox has just been toggled it allows the row to be selected. Requires a flag to be set in the add_toggle_cb which prevents selection in the view_selection_function and is cleared there.
    Fix row being selected after A(dd)toggled
    When the A is toggled on from U+R or R the row is automatically selected and if the row is toggled back to U+R or R selected, it cannot be unselected. Add a global add-toggled flag set in the gnc_gen_trans_add-toggled_cb and used in the treeview  multiple selection function to prevent a row being selected immediately after the A has been toggled.
    Fix to Multiple selection to ensure the match dialog comes up on double click on a  reconciled or update row and implement a view_selection_function so that only rows flagged for addition can be added to a selection
    Fixes requested by Bob-IT
    removed global add_toggled variable and added it to _main_matcher_info structure. modified gnc_gen_trans_add_toggled_cb and view_selection_function to use the _main_matcher_info member.

Summary of changes:
 gnucash/gtkbuilder/      |  34 ++++-
 gnucash/import-export/import-main-matcher.c | 190 ++++++++++++++++++++++------
 2 files changed, 184 insertions(+), 40 deletions(-)

More information about the gnucash-patches mailing list