gnucash master: Multiple changes pushed

Christopher Lam clam at
Fri Jul 12 07:17:01 EDT 2019

Updated	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit cee6400779cf03f2c15b70f693abd52f7bfd49c4
Merge: 620efc7ca c9d001d55
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 12 18:51:16 2019 +0800

    Merge branch 'maint'

commit c9d001d550df2cbfa2b62226288040f0dcbf87e8
Author: John Ralls <jralls at>
Date:   Thu Jul 11 17:31:49 2019 -0700

    Bug 797295 - problems with entering swedish åäö in company address
    scm_c_string_length() returns the wrong answer when the C string is
    UTF8: It returns the number of codepoints because the SCM string is in
    UTF32, but we need the number of bytes for gtk_text_buffer_set_text.
    Fortunately scm_to_utf8_string returns a null-terminated string so
    we can just tell gtk_text_buffer_set_text to figure it out on its own.
    Guile doesn't use g_malloc so don't use g_free, and gpointer* is a
    void** so change the cast to void* for free.

commit 22f22b0a280e0ad65a74ac60228ce64d0650f334
Merge: 9f40cac25 b3a4cd627
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 12 08:16:46 2019 +0800

    Merge branch 'wrapqoflog' into maint

commit 9f40cac2541195dda848226620c7e1165443af55
Author: Christopher Lam <christopher.lck at>
Date:   Wed Jul 10 23:07:16 2019 +0800

    [taxinvoice] bugfix: remove option 'Report Currency'
    this option is useless; it does not enforce currency conversion, it
    was merely used for "Amount Due, XXX" currency-mnemonic. Remove this
    option, and modify code to use invoice currency instead.

commit 5112210e4221eaef51a35c35be1151c1f571a8dd
Author: Christopher Lam <christopher.lck at>
Date:   Wed Jul 10 22:01:13 2019 +0800

    [invoice] Payments should be shown in invoice by default
    If an invoice has payments already applied, by default the
    invoice-report should show payments.

commit 06e3fd4d2812220970c19700c27b82251ff21864
Author: Christopher Lam <christopher.lck at>
Date:   Sun Jul 7 19:50:46 2019 +0800

    [customer-summary] fix no-owner sorting properly
    this comparison now works for no-owner sorting. 3a927ce2a, second

commit 1a16ba704b3ea1f1902204ec392c2c9b6d93ef44
Author: John Ralls <jralls at>
Date:   Tue Jul 9 16:22:52 2019 -0700

    Bug 797306 - "URL cannot be shown" when one clicks an account line link...
    in report.
    perform_navigation_policy hadn't been implemented for webkit2gtk-3.0.

commit f80e025b7b4d2c5994b6c99177b794d33ecded37
Author: John Ralls <jralls at>
Date:   Tue Jul 9 11:50:59 2019 -0700

    Bug 797297 - GNUCash is in English even though MacOS is set-up to French.
    Thanks to a misplaced #endif.
    Also allow info of selected locale, the comment about MacOS wasn't

commit 39cfcb30f939ca3c413350c8262ceea69085fb6b
Author: Christian Stimming <christian at>
Date:   Sun Jul 7 22:39:09 2019 +0200

    Online-banking: add value for fintsRegistrationKey with most recent aqbanking.

commit adbf8afeaea16e632b45fb5dc1619c97bac37018
Author: Pedro Albuquerque <pmra at>
Date:   Sun Jul 7 09:10:02 2019 +0100

    Updated pt.po

commit b3a4cd62775705b2543438f912ca71dad591bf0e
Author: Christopher Lam <christopher.lck at>
Date:   Sun Jul 7 08:30:54 2019 +0800

    completion redefine gnc:debug

commit 429077ee8e5728315e491f00e44bba85c160e59b
Author: Christopher Lam <christopher.lck at>
Date:   Sun Jul 7 08:30:41 2019 +0800

    completion wrap qoflog

commit 629569b792eb7201d54999f2740ace36c1459ee4
Author: Christian Stimming <christian at>
Date:   Sat Jul 6 22:17:34 2019 +0200

    Update German translation

commit bb6d84e03d5920d79c63e446eb145050f741c715
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 5 21:54:38 2019 +0800

    [html-utilities] [API] further deprecations
    * gnc:html-build-acct-table -- unused for decades
    * gnc:html-table-append-ruler/markup
    * gnc:html-acct-table-row-helper!
    * gnc:html-acct-table-comm-row-helper!

commit 463c3124ef51fc5d7ec4c349dd2646f7b9ad1ffa
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 5 21:50:52 2019 +0800

    [commodity-utilities] [API] deprecate gnc:sum-collector-stocks
    this function is never reachable in code

commit b9382d2cf22ae1549f144bd64b1fe9b7bfcaa3f5
Author: Christopher Lam <christopher.lck at>
Date:   Sat Jul 6 18:20:18 2019 +0800

    [commodity-utilities] move gnc:debug to less CPU critical code
    pricealist is a long list generated once, yet is dumped via gnc:debug
    for every call to gnc:exchange-by-pricealist-nearest. This change
    moves gnc:debug to the initial pricealist generation, ensuring that
    gnc:exchange-by-pricealist-nearest is much faster.

commit e783335cf26521fd9faa5854d3393e51bd880a43
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 5 23:09:19 2019 +0800

    [commodity-utilities] compact gnc:sum-collector-commodity
    This function converted to purely functional approach.
    Note that commodity-collectors always round amounts to the currency
    SCU therefore we replicate the behaviour here.

commit dd1873eb0571848d1e40be5316ae8155372c82dd
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 5 23:09:12 2019 +0800

    [test-cash-flow] fix test which was badly designed
    this test had confused 2 functions:
    (exchange-fn monetary currency) --> monetary
    (to-report-currency currency amount date) --> amount
    this flaw surfaces with the shortened gnc:sum-collector-commodity definition.

commit 4214f7eb76cc899e475b9af3b2790d8528a269dd
Author: Christopher Lam <christopher.lck at>
Date:   Sat Jul 6 14:32:53 2019 +0800

    [balsheet-pnl] bugfix prevent crash on missing accts
    When asset/liability/income/expense accounts are either missing or
    deselected, the report would crash. This commit will ensure the
    date-specific balance calculators do not crash.
    The reason for crash is the form (apply map gnc:monetaries-add lists)
    where lists is usually a list-of-list-of-monetaries, e.g.
    (list (list $1.00 $2.00 $3.00)
          (list $2.35 $3.44 $4.45))
    and (apply map gnc:monetaries-add lists) will return a list of the
    matched sums, i.e. commodity-collectors (list (list <$3.35> <$5.44>
    <$7.45>)), whereby each commodity-collector is denoted by <...>
    When there are missing account-types (or deselected) the lists are
    empty-lists, therefore mapping will fail. This change ensures that
    null-lists are handled by returning (list (list <> <> <>)), with null

commit 1e66d3b2f6406814efa185bc62cea4252fd79d45
Author: Christopher Lam <christopher.lck at>
Date:   Fri Jul 5 21:45:44 2019 +0800

    [balsheet-pnl] cosmetic: improve maxindent calc
    75ab45ac3 without 1+ some alignment is incorrect

commit 42b6fb993b9391c5725513d1e487f04c7b578082
Author: Christopher Lam <christopher.lck at>
Date:   Sat Jul 6 11:14:56 2019 +0800

    call strify only if debugging enabled

commit 898a9cdb8e1a8cad34125e6599ff62587297b01b
Author: Christopher Lam <christopher.lck at>
Date:   Sat Jul 6 11:14:50 2019 +0800

    wrap qoflog

commit bc1bcc718e509344bbda485c7475b4645d48cb9c
Author: Christopher Lam <christopher.lck at>
Date:   Wed Jul 3 19:35:58 2019 +0800

    [average-balance] show progress reports before chart generation
    This change adds progress reports to be more responsive on large
    datafiles. It is probably marginally slower.

commit 75ab45ac3c6589496bd04d8c6070bb7c9c60daab
Author: Christopher Lam <christopher.lck at>
Date:   Tue Jul 2 20:35:23 2019 +0800

    [balsheet-pnl] change definition of maxindent
    previous would find deepest account; it should really find deepest
    selected account.

commit 6f217165c4b90f34dcede27c6c1f236191bec7e0
Author: Christopher Lam <christopher.lck at>
Date:   Sat Jun 29 23:33:09 2019 +0800

    [owner-report] fix code to set date to 'today'
    code sets date-option to today. it fails to set the default-value. the
    date will reset when user click 'reset options', and this commit
    ensures the 'today' date remains the default date.

commit 3a927ce2ac88380746da6ed073aa692240a9e118
Author: Christopher Lam <christopher.lck at>
Date:   Sat Jun 29 14:18:59 2019 +0800

    [customer-summary] fix no-owner sorting of entries
    Previous 9ed0174cb would place any entry with customername == "No
    Customer" last, including genuine customers with this particular
    name. This commit modifies to test on presence of owner-report-url to
    detect owner/no-owner entries. This is reliable for this report.

commit f82058e026bebeb0c9380231b884d2c3140ca11a
Merge: a7bdd0829 690e359be
Author: Robert Fewell <14uBobIT at>
Date:   Tue Jul 2 10:57:23 2019 +0100

    Merge David Cousens's 'Bug797275' branch into maint

commit a7bdd0829191e16d49c4a7bcbbb8e7d5d3b0c803
Author: Christian Stimming <christian at>
Date:   Mon Jul 1 18:18:56 2019 +0200

    Update German translation.

commit 070e21fb0cc54110a61a4a51555d3a5af8f940f5
Author: Christian Stimming <christian at>
Date:   Mon Jul 1 17:59:21 2019 +0200

    aqb: Fix progress window scaling/filling
    The widget with the log messages didn't fill the space
    in the dialog anymore. Probably a side-effect of 58465432,
    but fixed now anyway.
    Also, one label whose "translatable" attribute was removed
    had to get it again.

commit da7cc037e25f410455d4b615b8f8cb726d093e12
Author: Christian Stimming <christian at>
Date:   Sun Jun 30 16:43:54 2019 +0200

    Fix remaining compiler errors in aqbanking5/aqbanking6 dependent code.

commit 98959f86d98952be65e7423dd868cab9355bd9ef
Author: Christian Stimming <christian at>
Date:   Sun Jun 30 16:09:34 2019 +0200

    Get aqbanking code to compile again with current aqbanking's git master version.
    Not yet tested, though, only successfully compile and link.

commit 690e359be093a7207f646879d8e80a6392f263b3
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 14:12:03 2019 +1000

    Fix view_selection_function declaration
    For some strange reason the view_selection_function declaration went missing?? reinserted it

commit 98cf760c6eb1362dbb7b41b2689c76cbf1aa3a5c
Merge: caeea74b5 377b73d1a
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 13:53:08 2019 +1000

    Merge branch 'matcher-help' into Bug797275

commit 377b73d1aa9f9c263c5887a0c869d2a371bfd142
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 13:42:36 2019 +1000

    Add multiselection info to help dialogue

commit caeea74b5003788a79fd684e50244dac44f11e93
Author: David Cousens <davidcousens at>
Date:   Sat Jun 29 07:43:10 2019 +1000

    Add view_selection_function
    view_selection_function added to only allow adding a row to the selection if GNCImport_Add is set for the transaction.
    Explicit selection clearing
    try explicitly clearing the row in the add, update and clear toggle callbacks - before refresh row and add debugging info which showed that the selection is called after exiting the above callbacks and as the view_selection_function has no knowledge that the add checkbox has just been toggled it allows the row to be selected. Requires a flag to be set in the add_toggle_cb which prevents selection in the view_selection_function and is cleared there.
    Fix row being selected after A(dd)toggled
    When the A is toggled on from U+R or R the row is automatically selected and if the row is toggled back to U+R or R selected, it cannot be unselected. Add a global add-toggled flag set in the gnc_gen_trans_add-toggled_cb and used in the treeview  multiple selection function to prevent a row being selected immediately after the A has been toggled.
    Fix to Multiple selection to ensure the match dialog comes up on double click on a  reconciled or update row and implement a view_selection_function so that only rows flagged for addition can be added to a selection
    Fixes requested by Bob-IT
    removed global add_toggled variable and added it to _main_matcher_info structure. modified gnc_gen_trans_add_toggled_cb and view_selection_function to use the _main_matcher_info member.

Summary of changes:
 gnucash/gnome-utils/dialog-options.c               |     4 +-
 gnucash/gnucash-bin.c                              |     8 +-
 gnucash/gtkbuilder/             |    34 +-
 gnucash/html/gnc-html-webkit2.c                    |    27 +-
 gnucash/import-export/aqb/assistant-ab-initial.c   |     6 +-
 gnucash/import-export/aqb/dialog-ab-trans.c        |    24 +-
 gnucash/import-export/aqb/          |     8 +-
 gnucash/import-export/aqb/gnc-ab-getbalance.c      |     6 +-
 gnucash/import-export/aqb/gnc-ab-utils.c           |    93 +-
 gnucash/import-export/aqb/gnc-file-aqb-import.c    |    12 +-
 gnucash/import-export/import-main-matcher.c        |   190 +-
 gnucash/report/commodity-utilities.scm             |    28 +-
 gnucash/report/html-utilities.scm                  |     8 +
 gnucash/report/reports/example/average-balance.scm |    27 +-
 gnucash/report/reports/standard/balance-sheet.scm  |     6 +-
 gnucash/report/reports/standard/balsheet-pnl.scm   |    40 +-
 .../report/reports/standard/customer-summary.scm   |    10 +-
 gnucash/report/reports/standard/invoice.scm        |     2 +-
 gnucash/report/reports/standard/owner-report.scm   |     7 +-
 gnucash/report/reports/standard/taxinvoice.scm     |     8 +-
 .../reports/standard/test/test-cash-flow.scm       |    13 +-
 .../report/reports/support/taxinvoice.eguile.scm   |     4 +-
 libgnucash/engine/engine.i                         |    22 +
 libgnucash/engine/qoflog.h                         |    18 +-
 libgnucash/scm/CMakeLists.txt                      |     2 +-
 libgnucash/scm/utilities.scm                       |    18 +-
 po/de.po                                           | 12447 +++++++--------
 po/pt.po                                           | 15326 ++++++++++---------
 28 files changed, 15003 insertions(+), 13395 deletions(-)

More information about the gnucash-patches mailing list