gnucash maint: Multiple changes pushed

Robert Fewell bobit at
Tue Jul 30 05:27:47 EDT 2019

Updated	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit 76ba133174bc1b638ae0a186a248733e03ae1aaf
Author: Robert Fewell <14uBobIT at>
Date:   Thu Jul 18 15:43:38 2019 +0100

    Account Picker dialogue warning message placement
    Currently this message is below the dialogue buttons so move the
    message to above them.

commit d4dd289113452e2aceedbbecc3ef8ad837ce3859
Author: Robert Fewell <14uBobIT at>
Date:   Thu Jul 18 15:42:27 2019 +0100

    Error when cancelling the create a new account in register
    When you are asked whether you want to create a new account on the
    register, possibly due to a typo and you answer no, the same dialogue
    will appear another three times before resetting the account cell to
    the original value.
    These changes eliminate that by returning you back to the cell with the
    invalid entry so that you can amend / cancel or use the dialogue again
    to create a new account based on an amended entry.

commit aca8a734b0ae0f058dadb1ef3f18e81f987a5eb6
Author: Robert Fewell <14uBobIT at>
Date:   Tue Jul 16 13:34:13 2019 +0100

    Error when creating a new account on expanded transaction
    With the register in journal mode and you edit the account field so the
    'Account x does not exist, do you want to create it' dialogue is shown
    you get the following error...
    gboolean boolean_from_key(const Account*, const std::vector<std::
    __cxx11::basic_string<char> >&): assertion 'GNC_IS_ACCOUNT(acc)' failed
    This was tracked down to a refresh being triggered with the account
    dialogue so add a check for a valid account as part of the placeholder

commit 69f76c63787d991605b8890a867674f54ec489a5
Author: Robert Fewell <14uBobIT at>
Date:   Tue Jul 16 13:30:01 2019 +0100

    Bug 797301/2 - Sub-account register not seeing changes to sub accounts.
    If you have a sub account register open and you create another account
    that is a descendant of the top account the transaction will not be
    seen as the query used for the sub account register does not include
    the new account. Add a check to 'refresh_handler' to check for the same
    number of sub accounts, if different recreate query.

commit b56203e06f6a87f17b362dd5a7ed1e1112fe3116
Author: Robert Fewell <14uBobIT at>
Date:   Tue Jul 16 13:29:18 2019 +0100

    Bug 797301/1 - Menu View->Refresh not refreshing register
    The Menu 'View->Refresh' only worked for the report page which reloaded
    the report so added functions for other pages as follows. The Register
    and Budget pages are reloaded with the remaining pages being redrawn
    with a call to gtk_widget_queue_draw.

Summary of changes:
 gnucash/gnome/gnc-plugin-page-account-tree.c      | 18 ++++++++++
 gnucash/gnome/gnc-plugin-page-budget.c            | 22 ++++++++++++
 gnucash/gnome/gnc-plugin-page-invoice.c           | 22 ++++++++++++
 gnucash/gnome/gnc-plugin-page-owner-tree.c        | 17 +++++++++
 gnucash/gnome/gnc-plugin-page-register.c          | 29 +++++++++++++++
 gnucash/gnome/gnc-plugin-page-sx-list.c           | 19 ++++++++++
 gnucash/gnome/gnc-split-reg.c                     | 14 ++++++--
 gnucash/gtkbuilder/            | 36 +++++++++----------
 gnucash/register/ledger-core/gnc-ledger-display.c | 29 ++++++++++++++-
 gnucash/register/ledger-core/split-register.c     | 44 +++++++++++++++--------
 gnucash/register/register-gnome/gnucash-sheet.c   |  5 +++
 11 files changed, 216 insertions(+), 39 deletions(-)

More information about the gnucash-patches mailing list