gnucash master: Multiple changes pushed
Christopher Lam
clam at code.gnucash.org
Sun Nov 10 08:03:20 EST 2019
Updated via https://github.com/Gnucash/gnucash/commit/7e5784ff (commit)
via https://github.com/Gnucash/gnucash/commit/a482c250 (commit)
via https://github.com/Gnucash/gnucash/commit/6f7c6b9d (commit)
via https://github.com/Gnucash/gnucash/commit/97798f9f (commit)
via https://github.com/Gnucash/gnucash/commit/b7205213 (commit)
via https://github.com/Gnucash/gnucash/commit/72c20a07 (commit)
via https://github.com/Gnucash/gnucash/commit/9f4677e3 (commit)
via https://github.com/Gnucash/gnucash/commit/f0701da8 (commit)
via https://github.com/Gnucash/gnucash/commit/a4773d2b (commit)
via https://github.com/Gnucash/gnucash/commit/2bc7d314 (commit)
via https://github.com/Gnucash/gnucash/commit/32ff31fe (commit)
via https://github.com/Gnucash/gnucash/commit/952c6561 (commit)
via https://github.com/Gnucash/gnucash/commit/ee191083 (commit)
via https://github.com/Gnucash/gnucash/commit/21d60803 (commit)
via https://github.com/Gnucash/gnucash/commit/e991fe85 (commit)
via https://github.com/Gnucash/gnucash/commit/910cdbfd (commit)
via https://github.com/Gnucash/gnucash/commit/1a9825fe (commit)
via https://github.com/Gnucash/gnucash/commit/c8d1e7c1 (commit)
via https://github.com/Gnucash/gnucash/commit/d0743cd0 (commit)
via https://github.com/Gnucash/gnucash/commit/1a404b8d (commit)
via https://github.com/Gnucash/gnucash/commit/6e354d8a (commit)
from https://github.com/Gnucash/gnucash/commit/47b6d05b (commit)
commit 7e5784ffa2e8a0f5a15bba58b6122ab8aac73766
Merge: c8d1e7c19 a482c2507
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sun Nov 10 20:11:51 2019 +0800
Merge branch 'maint'
commit a482c250726fe35447165625a8e74fcc81bbdd6f
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sun Nov 10 13:32:50 2019 +0800
[new-aging] step 4 - prepended lists must be reversed
after building lists by prepending in b72052137 we need to process
them in reverse to obtain the original sorting of accounts and
owner-list.
commit 6f7c6b9de3326d27bfaa0857069b8df4a2d22c74
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sun Nov 10 03:50:55 2019 +0800
[new-aging] step 3 - only render APAR details if APAR-accounts>1
This commit will hide the APAR account anchor if there's only one
found. So, for majority of users with single AP/AR accounts, the aging
report will be very similar to old one. For users with multi APAR
accounts, each one will be shown with header (and anchor) and
indenting to highlight grouping.
commit 97798f9fd1b5c7864b359e84b9f76f2d8915c2c9
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sun Nov 10 04:07:08 2019 +0800
[new-aging] step 2 - reduce indentation level by 1
merge two let* together
commit b72052137b562888421fdc9d4e7c7d05867c0186
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sat Nov 9 17:19:50 2019 +0800
[new-aging] step 1 - split loops into processing vs building table
Instead of rendering html-table all incrementally, build
account-and-owners and owners-and-aging lists first, leaving building
the html-table for the end. tofree is a list of owners which are
generated and must be freed after use.
commit 72c20a07c36fbf719691f5cc35e2df4037218d23
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sat Nov 9 14:45:11 2019 +0800
[new-owner-report] merge setup-query and setup-job-query
They were very similar.
and remove html-document-set-title! because the document headline will
override title in the renderer.
commit 9f4677e34651a35b409a1fcdc967bbbd2b6e5020
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sat Nov 9 14:31:24 2019 +0800
[new-owner-report] apply total-label-cell to label
Previous used 'total-number-cell' thereby unnecessarily right-aligning
total label cells.
Also xaccTransGetAccountAmount is more appropriate than
xaccTransGetAccountValue because the latter may retrieve numbers in a
currency other than APAR currency.
commit f0701da8685ec0b8bbd593099a561fb9cc60503f
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sat Nov 9 06:14:17 2019 +0800
[new-owner-report] modify report row->value accessor
Previously each owner-table row's value would access split's
amount. But this fails for payments spanning multiple invoices,
because these (with a single split to bank) will have a split for each
invoice. Hence split->amount gets only 1 invoice payment amount.
This change modifies to obtain the sum total of split->amounts in the
APAR account thus handles multi-invoice payments correctly.
commit a4773d2ba7d05f973f44eb9be1af866576131150
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 8 13:12:05 2019 -0800
Ensure all uses of g_table_index are protected from NULL return values.
Including all of the convenience wrappers.
Also remove a few calls where the result is discarded, as it has no
side effects.
commit 2bc7d314ed6b08eacc35adfca8ac1ac64f8ec3a7
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 8 12:33:00 2019 -0800
Bug 797481 - crash on close of unsaved tabs by pressing [X]
Pretty much the only place gnucash_sheet_get_block could crash is in
g_table_index, either because the GTable's GArray has been deleted or
the index is out of range. Add g_return_val_if_false tests for each
possibility.
commit 32ff31feadaed6ec5a6902a690bf62651eed9fc2
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Fri Nov 8 14:51:30 2019 +0000
Bug 796945 - Search dialog update - follow up
For some reason on Ubuntu 18.04 that uses Gtk3.22.30 and maybe others
we have to set the scroll window content min height after the dialog
has been shown to get the correct scroll window height
commit 952c6561447a3ad560865af34d60dc7d05ab9f4f
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Mon Nov 4 06:52:30 2019 +0800
[dialog-payment] instead of tooltip, render in gtklabel
The warning icon is used to show blocking and non-blocking warnings in
a payment. Increase visibility by showing the warning as a gtklabel
instead of a tooltip.
commit ee19108321631931a386dc4d1018b8f295df3f80
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Mon Nov 4 06:33:43 2019 +0800
[dialog-payment] tooltip warning if payment is unattached
Completing a payment for a customer without associating with an open
invoice is allowable and is used for prepayments.
Previously this was done silently.
This commit will enable a warning to inform that the payment does not
have an invoice/bill document attached. This warning does not block
the payment however.
commit 21d608038eadbe573e52a47a99bd57c1ee000474
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Mon Nov 4 20:12:36 2019 +0800
Addendum to UI Jump to Invoice at 535632b02
Previous trans->invoice strategy was flawed. A payment for multiple
invoices would always return the first invoice found.
A safer approach is to find split->invoice -- this enables a split
from a payment for multiple invoices to retrieve the corresponding
invoice.
The disadvantage is that we cannot jump from bank split to invoice
split anymore; this is acceptable because a payment which covers
multiple invoices would lead to ambiguity and would require UI to
select the invoice for jump.
commit e991fe853caff678ec23cdeb41e9d1ea87403d6b
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Nov 5 09:14:14 2019 -0800
Bug 797086 - Import customer dialog – headers not translated
commit 910cdbfddc39eea3fc8e624eeda46f40543972e7
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Nov 5 09:12:17 2019 -0800
Fix compile error, missing return value.
And a condition, !(!inv) to cast inv as a bool is a bit too clever.
inv != NULL more clearly conveys the intent.
commit 1a9825febcaadbd17298a45d3d032f94e59ee6d7
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Nov 5 23:08:08 2019 +0800
[new-owner-report] job-reports reverse according to ownertype
Previously job-report assumed owner was customer and assumed use of
A/Receivable account.
This fix ensures the payable? boolean must be derived dynamically from
owner-type rather than from report-type. This commit will check
whether owner is vendor/employee and uses a/payable; otherwise uses
a/receivable.
commit c8d1e7c197a7868730739166b75621584c686a79
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Nov 5 20:59:18 2019 +0800
[html-table] Remove deprecated function
commit d0743cd0fc2dfef7021704b40e8b1ffd605c36cd
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Nov 5 22:10:16 2019 +0800
[new-aging] restore html link to account register
Current aging-report includes a link to APAR account register. New
aging-report includes the APAR account prior to each section. Ensure
the link to register is offered.
commit 1a404b8d76127f6030c168b41f6966ddec51e1e5
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Nov 5 21:25:37 2019 +0800
[new-owner-report] fix signs for calling gnc:owner-splits->aging-list
gnc:owner-splits->aging-list revceives an argument 'receivable'
specifying whether the report is dealing with an AR-type account. The
renderers for the various business types (customer/vendor/employee)
define 'reverse?' to be #f for AR reports, and #t for AP
reports. Therefore we need to send '(not reverse?)' to
gnc:owner-splits->aging-list.
This commit performs 2 changes:
* rename 'reverse?' to 'payable?' to be more explicit throughout
* calls gnc:owner-splits->aging-list with '(not payable?)' instead of
the confusing '(not reverse?)'
The end result is that the signs for aging-list for
new-owner-report.scm is now fixed.
commit 6e354d8a49d730eba204224eac13af3c33d3a46f
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Nov 5 18:41:39 2019 +0800
Remove html-utilities.scm deprecations
These functions were marked as deprecated in 3.x
Summary of changes:
gnucash/gnome-search/dialog-search.c | 8 +
gnucash/gnome/dialog-payment.c | 26 ++-
gnucash/gnome/gnc-plugin-page-register.c | 45 ++---
gnucash/gtkbuilder/dialog-payment.glade | 44 +++--
.../customer-import/dialog-customer-import-gui.c | 38 ++--
.../register/ledger-core/gncEntryLedgerControl.c | 1 -
.../register/ledger-core/split-register-control.c | 1 -
gnucash/register/register-core/gtable.c | 9 +-
gnucash/register/register-gnome/gnucash-header.c | 4 +-
gnucash/register/register-gnome/gnucash-sheet.c | 13 +-
gnucash/register/register-gnome/gnucash-style.c | 38 +++-
gnucash/report/html-table.scm | 15 --
gnucash/report/html-utilities.scm | 25 +--
gnucash/report/report.scm | 1 -
gnucash/report/reports/standard/new-aging.scm | 204 ++++++++++++---------
.../report/reports/standard/new-owner-report.scm | 63 +++----
gnucash/report/test/test-report-html.scm | 26 ---
17 files changed, 293 insertions(+), 268 deletions(-)
More information about the gnucash-patches
mailing list