gnucash maint: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/23d0fa13 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/7a36c229 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/70cb3a0b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ff8c5725 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b05c57a9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/d3f86d2a (commit)



commit 23d0fa132414faab93acb46214c7c6197938044e
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Sep 8 23:37:10 2019 +0800

    [balsheet-pnl] bugfix last pnl period must not be decreased by 1 day
    
    logic error to calculate last period date pair for col-header.
    
    pnl report-dates are stored as a list of time64. consider a regular
    profit&loss for "quarterly income & expense amounts for last
    calendar year". dates are 1-jan to 31-dec. the report-dates are
    '(1-jan 1-apr 1-jul 1-oct 31-dec). the inc/exp accounts balances are
    queried for the above dates, and the delta change (sans closing
    entries) constitutes the desired answer.
    
    the col-header needs to report "1-jan to 31-mar", which it does by
    retrieving 2 consecutive dates in the list (1-jan 1-apr), then
    decrease second date by 1 day to obtain "1-jan to 31-mar" . however
    this fails for the last period which would return '1-oct to 30-dec'.
    
    this commit changes display for last period to return last report-date
    so that the header is fixed to '1-oct to 31-dec'.
    
    this is cosmetic for header dates only, calculations of periodic
    income/expense amounts were never affected and included entries on the
    last report-date (e.g. 31-dec as above).

commit 7a36c229c54a54d27444a30be44cae3622681a99
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Sep 8 20:39:09 2019 +0800

    [balsheet-pnl] speed up by pre-appending accounts
    
    minor efficiency change. append-reverse is faster than append, and
    storing the appended lists is rather convenient for this
    report which uses them a lot.

commit 70cb3a0b979991cc34a00278d9de246ad5fac1c5
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Sep 10 00:34:25 2019 +0800

    [utilities] compact sort-and-delete-duplicates
    
    This is still readable IMHO. kons is the result constructor, and adds
    item to result iff different from previous add.

commit ff8c5725cde0d6bbdeba6ea53ad6a08198a4db0a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Sep 8 18:54:06 2019 +0800

    [test-extras] rewrite strip-string to avoid repeat string-append
    
    this is marginally more efficient, by keeping a list of (shared)
    substrings, and only concatenating them when returning the stripped
    string.

commit b05c57a948cac6c665c6134ccf03335f3135900e
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Sep 7 19:36:34 2019 +0800

    [html-acct-table] compact functions



Summary of changes:
 gnucash/report/report-system/html-acct-table.scm  | 246 +++++++++-------------
 gnucash/report/report-system/test/test-extras.scm |  10 +-
 gnucash/report/standard-reports/balsheet-pnl.scm  |  51 ++---
 libgnucash/scm/utilities.scm                      |   8 +-
 4 files changed, 127 insertions(+), 188 deletions(-)