gnucash master: Fix several dependency issues in scheme code

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/617c4c4a (commit)
	from  https://github.com/Gnucash/gnucash/commit/0b3752d9 (commit)



commit 617c4c4ade54ceba918cfd7cb303f93562a02f14
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Sep 12 10:10:58 2019 +0200

    Fix several dependency issues in scheme code
    
    * Ensure all the files included in report.scm are built before
      any module calls '(use-modules (gnucash report))'
    * Break circular dependency between report.scm and the files it loads via
      '(load-from-path ...)'
      For example file 'gnucash/report/html-linechart' is loaded via
      '(load-from-path ...)' in 'reports.scm' it shouldn't call
      '(use-modules (gnucash report))'. That would  make it indirectly
      depend on its own.
    * In the same way 'engine-utilities.scm' was in a circular dependency loop
      with 'engine.scm' though even more indirectly via (gnc-module-load ...)'.
      The initialization code of libgncmod-engine calls
      '(use-modules (gnucash engine))' which in turn tries to load-from-path
      'engine-utilities.scm', completing the loop.



Summary of changes:
 gnucash/report/CMakeLists.txt          | 2 +-
 gnucash/report/html-barchart.scm       | 2 --
 gnucash/report/html-linechart.scm      | 2 --
 gnucash/report/html-piechart.scm       | 2 --
 gnucash/report/html-scatter.scm        | 2 --
 libgnucash/engine/engine-utilities.scm | 5 ++++-
 6 files changed, 5 insertions(+), 10 deletions(-)