gnucash master: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/de9d6a33 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/7218bfef (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a584806e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ccdeda42 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0af5883d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1f8dfbac (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d65a29c4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ee4f0daa (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2af5d52c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4f8652c2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/402b1c86 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c08215d0 (commit)
	from  https://github.com/Gnucash/gnucash/commit/fa769090 (commit)



commit de9d6a3339463af35e47036e9dfeaa7e8ad2aa2e
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 18:44:35 2020 -0700

    Delete Account: Use subaccount commodity for subaccount splits.
    
    It might be different from the parent account's. Also check the
    commodity, not the currency-or-parent; moving widgets to flidgets
    is just as bad as pounds to dollars.

commit 7218bfef372693249b8ded5206951950b1814ee5
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 18:44:16 2020 -0700

    Delete Account: Short circuit checks if no transactions or subaccounts.

commit a584806e070df198a73f9fc48722ea8f6903bd1b
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 17:36:38 2020 -0700

    Delete account: Rename and reflow helper functions.

commit ccdeda4292f247514b4fe48e620246694cba067d
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 17:13:18 2020 -0700

    Extract function account_delete_dialog.

commit 0af5883d6e6016481fd0a7f4fbe8e4ad42785c4c
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 16:19:59 2020 -0700

    Delete Account: Abstract the disposition adopters into a struct.
    
    With functions for the operations done on the members.

commit 1f8dfbac99ebac986c621e64ff661a3b58606387
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 16:17:30 2020 -0700

    Delete Account: Modify strings for single subaccount.
    
    Because we bail out and make the user sort it out if there is more
    than one subaccount.

commit d65a29c4c0417d3f091323a8e6a86bf5fff2e151
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 12:02:56 2020 -0700

    gnc-plugin-page-account-tree.c: delete_account_next fix leaks and whitespace.

commit ee4f0daa470af7a934e517cdb6ef97d553a811e1
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 10:28:42 2020 -0700

    Plugin-page-account: Extract function commodity_mismatch_dialog.

commit 2af5d52c4cabe86c083d39047852adb81f4df386
Merge: fa769090e 4f8652c2e
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 27 18:49:33 2020 -0700

    Merge Jean Laroche's '797220_delete_account_wrong_currency' into master.

commit 4f8652c2e54d7914a6d599a530f977fdb844c4ba
Author: jean <you at example.com>
Date:   Wed May 6 20:49:14 2020 -0700

    Refactor, breaking large function.
    - gnc_plugin_page_account_tree_cmd_delete_account() is still too long but would be messy to break
    - rename the _int function and break it further
    - remove passing of account name
    - simplify some of the code by reversing if(...) to if(!...)

commit 402b1c86a23b163a5f75158031a014132b04f63f
Author: jean <you at example.com>
Date:   Mon Apr 27 22:06:07 2020 -0700

    Split long function into two sub-functions. Prevent deleting accounts with more than 1 subaccount. Verify currency match for sub-account when it is to be moved or its transactions are to be moved

commit c08215d01b558de70699b5289d61faafd2872442
Author: jean <you at example.com>
Date:   Sun Apr 26 23:24:50 2020 -0700

    Bug 797220 - delete account allows move of all transactions to account having non-matching currency



Summary of changes:
 gnucash/gnome/gnc-plugin-page-account-tree.c | 670 ++++++++++++++++-----------
 gnucash/gtkbuilder/dialog-account.glade      |   6 +-
 2 files changed, 404 insertions(+), 272 deletions(-)