gnucash maint: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Sun Nov 8 17:28:14 EST 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/e09a26ba (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6394b649 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/feba6462 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e44cf9c6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/63969e86 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d673c32e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0e634c54 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/99256c38 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/833edd0b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bc80bbb3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b0906b5e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5408854c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/41c147a9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/df6621f2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/861a2482 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3d92d539 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1fa90a54 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/af3353a1 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1e2236af (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fa82a8bc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2639cdef (commit)
	 via  https://github.com/Gnucash/gnucash/commit/841111e3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bbfc30d7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8425af78 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/766f88c0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8ac640d5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/610bbda2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/53c294f9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bb0088c4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/967cf0b4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d0842798 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/67f63053 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a9d85e8f (commit)
	from  https://github.com/Gnucash/gnucash/commit/26fa239f (commit)



commit e09a26ba3ae9658af50122143cd19787137d5b61
Merge: 26fa239f8 6394b6491
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Nov 8 14:04:29 2020 -0800

    Merge Christian Gruber's 'test_import_backend' into maint.

commit 6394b6491b719089aeb83917bc7dd0714c880e98
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Oct 5 22:48:52 2020 +0200

    fixup! Simplify type checking for GObject mockups

commit feba64624c360ec992f3f11a78732cf9f2461e99
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Oct 5 22:20:02 2020 +0200

    Fix xaccTransSetNotes()
    
    This is a bugfix for commit 954ce9577f4de5f77956e4cdc1d79d51ef8afb1f

commit e44cf9c61f36ef29c16dafbad443d9c1a8cfdf3f
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Sep 23 19:59:40 2020 +0200

    Add missing C linkage statements

commit 63969e8628d4ac5ae53c8d2a72bf6bcf717b3c03
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Tue Sep 22 22:25:45 2020 +0200

    Remove unecessary include

commit d673c32e358c53a49ff8b5ff8d17a661003dc582
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Tue Sep 22 22:24:57 2020 +0200

    Mock methods should not neccessarily return mock objects

commit 0e634c54460463de2c8bc1204835041d03a014e0
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Tue Sep 22 22:20:38 2020 +0200

    Relax runtime type checks
    
    Runtime type checks should only check for the mock up type, if
    neccessary. If objects of another class than the mocked object itself
    are processed, runtime type check should only check for the base-class
    type. It should be possible to use mockup objects and non-mockup objects
    within the same application.
    
    The included headers are adapted accordingly.

commit 99256c385b21efa920650089c5ea4d948dbb4ffe
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Tue Sep 22 22:07:21 2020 +0200

    Add missing _get_type() functions of all mocked GObject classes
    
    If a GObject is replaced by a mock up, its _get_type() function has to
    be replaced as well. The replaced _get_type() functions have to return
    the type of the mock up now.

commit 833edd0b29dcc936ec77ece9bf6a331d8cffdd75
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Sep 21 00:50:24 2020 +0200

    Add missing comment

commit bc80bbb325d1814489d72bd1bc0760e8f7423a2f
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Sep 21 00:47:53 2020 +0200

    Simplify type checking for GObject mockups
    
    A type conversion function is introduced for each GObject mockup. This
    function does a runtime type check and generates a GoogleTest failure in
    case of any type error. This avoids checking GObject type twice.

commit b0906b5e2ac000255e6e9f58def36634edc93e0e
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Sep 20 23:36:34 2020 +0200

    Use MOCK_CONST_METHODn() macro instead of MOCK_METHODn() macro if necessary

commit 5408854c28aa9bb47a243eed887b4bcfdc5eb049
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Sep 20 22:33:51 2020 +0200

    Rename GObject type names of mock classes
    
    According to a remark in PR #738 the lower case type name is changed.
    Underscores should only be used between namespace and type name and
    between type name and suffixes.

commit 41c147a91803b93a891c9a4da1f29b1fd7d302fa
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Aug 24 23:31:08 2020 +0200

    Use /* ... */ for multi-line comments

commit df6621f2b54aa488468ac64f6147572cb1f50eb4
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Fri Jul 10 23:50:10 2020 +0200

    Add doxygen documentation to QofFakeQuery and QofFakeQueryPool

commit 861a2482fe72786c3a6023b4d496fb781fb34836
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Fri Jul 10 23:03:01 2020 +0200

    Add a comment on using empty ctor for mock classes derived from GObjects

commit 3d92d539176e80cc5630729e02a81b57fe0e39a6
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Thu Jul 9 21:36:01 2020 +0200

    Rename all class methods using snake_case instead of camelCase

commit 1fa90a54298682944abfb7504a9f74bd2bfc7b64
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Jun 15 22:53:08 2020 +0200

    Cleanup some comments

commit af3353a1da2659fcf705bc7b430e84899c0a16f4
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Jun 15 22:52:54 2020 +0200

    Correct comments on fake functions of the test application

commit 1e2236afdcd216c42be4ab316470628598e830ec
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Jun 15 22:36:13 2020 +0200

    Use typed queries

commit fa82a8bcce5328c6aeb20c8fc3b57949b0548c08
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Mon Jun 15 22:06:08 2020 +0200

    Replace query factory by a query pool
    
    Query factory was implemented using a public global variable
    qof_query_factory.
    
    Furthermore a query pool is easier to handle than a factory, since the
    whole management can be hidden from the user.

commit 2639cdefdfac9dadce946b14ea7ebbfa0048fce4
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Jun 14 21:38:22 2020 +0200

    Remove unnecessary inclusion of qofquery-p.h

commit 841111e37e9c72099e881afe6157c99cc3e39a85
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 10 22:55:29 2020 +0200

    Rename class QofMockQuery to QofFakeQuery

commit bbfc30d70b669a3e7279377c355ada8205f7fb7b
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 10 22:59:02 2020 +0200

    Rename gmock-qofquery to fake-qofquery

commit 8425af784e1ef9c5ab62cff82f76f999b9012bb4
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 10 22:04:30 2020 +0200

    Check pointer to preferences backend before using it

commit 766f88c02d6b8837fdf09d0b8660da6251cf68a3
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 10 21:47:50 2020 +0200

    Replace singleton class MockPrefsBackend by an ordinary class

commit 8ac640d5fab740d4f99866c87bc6a7f08dd71c41
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Jun 7 22:53:18 2020 +0200

    Fix typo

commit 610bbda23f19e4ae3a20796c30f907a4275e84e8
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Jun 7 22:52:24 2020 +0200

    Add glib-object.h to includes

commit 53c294f9e83295ccd2d9294aaba9b46e22010967
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Jun 7 22:52:19 2020 +0200

    Remove unnecessary type check

commit bb0088c43c79fbf3c5a8763f66d0b44a491f774f
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Sun Jun 7 22:50:56 2020 +0200

    Replace g_return_if_fail() and g_return_val_if_fail() by ASSERT_TRUE and EXPECT_TRUE

commit 967cf0b4304ad1412fbc3970a4dbac68a15356c5
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 3 23:41:04 2020 +0200

    Pass std::vector arguments by reference instead of by value

commit d0842798917b78db777c20bf6181d2bf056a1b3a
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 3 23:36:48 2020 +0200

    State comment on unused GObject instance init function more precisely

commit 67f63053fbae56029a71d8010fed83dc3623f4ff
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Wed Jun 3 23:26:49 2020 +0200

    Remove todo comments on replacement of std::vector by std::list
    
    Replacing std::vector by std::list wouldn't have any advantage

commit a9d85e8f8ea8ffb75bdf0927fa263fd01d9308be
Author: Christian Gruber <christian.gruber at posteo.de>
Date:   Tue Jun 2 08:16:50 2020 +0200

    Use std::vector of const char* instead of std::string where meaningful
    
    This avoids additional string allocation



Summary of changes:
 gnucash/import-export/test/CMakeLists.txt          |   2 +-
 .../import-export/test/gtest-import-backend.cpp    |  48 +++---
 libgnucash/app-utils/mocks/gmock-gnc-prefs.cpp     |  38 ++++-
 libgnucash/app-utils/mocks/gmock-gnc-prefs.h       |  46 ++----
 libgnucash/engine/mocks/fake-qofquery.cpp          | 169 +++++++++++++++++++++
 libgnucash/engine/mocks/fake-qofquery.h            |  71 +++++++++
 libgnucash/engine/mocks/gmock-Account.cpp          |  52 ++++---
 libgnucash/engine/mocks/gmock-Account.h            |  60 +++++---
 libgnucash/engine/mocks/gmock-Split.cpp            |  96 +++++++-----
 libgnucash/engine/mocks/gmock-Split.h              |  61 +++++---
 libgnucash/engine/mocks/gmock-Transaction.cpp      |  86 ++++++-----
 libgnucash/engine/mocks/gmock-Transaction.h        |  60 +++++---
 libgnucash/engine/mocks/gmock-gobject.h            |   1 +
 libgnucash/engine/mocks/gmock-qofbook.cpp          |  19 ++-
 libgnucash/engine/mocks/gmock-qofbook.h            |  35 ++++-
 libgnucash/engine/mocks/gmock-qofinstance.cpp      |  11 +-
 libgnucash/engine/mocks/gmock-qofquery.cpp         |  68 ---------
 libgnucash/engine/mocks/gmock-qofquery.h           |  46 ------
 18 files changed, 622 insertions(+), 347 deletions(-)
 create mode 100644 libgnucash/engine/mocks/fake-qofquery.cpp
 create mode 100644 libgnucash/engine/mocks/fake-qofquery.h
 delete mode 100644 libgnucash/engine/mocks/gmock-qofquery.cpp
 delete mode 100644 libgnucash/engine/mocks/gmock-qofquery.h



More information about the gnucash-patches mailing list