gnucash maint: Multiple changes pushed

Robert Fewell bobit at code.gnucash.org
Thu Oct 22 09:38:24 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/3c5066fe (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e5886955 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f93f850f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c11f4db9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/8e5e3480 (commit)



commit 3c5066feb4a6a58c263c3ae83a16739fedf28266
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Oct 22 14:30:46 2020 +0100

    Change source files option-util.* for spaces and tabs

commit e5886955027dad50b085871e7f8b6a081a506910
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Oct 22 14:30:11 2020 +0100

    Change source files dialog-options.* for spaces and tabs

commit f93f850f17a333105c8a5106aa05517eea0990a0
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Oct 22 14:27:54 2020 +0100

    Bug 345924 - Conditionally change Options dialog cancel button
    
    When the options dialog is loaded, the main buttons are a sensitive
    'Cancel' button and insensitive 'OK' and 'Apply' buttons. When changes
    are made the 'OK' and 'Apply' buttons become sensitive and when pressed
    the 'OK' button will make changes and close dialog whereas the 'Apply'
    button will make changes and the dialog will remain open but with these
    buttons insensitive leaving just 'Cancel' sensitive.
    
    This could be confusing so this commit changes conditionally the text
    label of the 'Cancel' button between 'Cancel' and 'Close'.

commit c11f4db96ef1c23903075807bd944731a8eab167
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu Oct 22 14:26:50 2020 +0100

    Bug 345924 - Report options 'Reset Button' always flags changes
    
    If a report is loaded with default settings and the 'Reset button' is
    pressed the 'OK/Apply' buttons will be enabled which should not happen
    as there are no changes to be made.
    
    Fixed by resetting the changed flag on options load and then comparing
    the current value to the default one when the 'Reset button' pressed.



Summary of changes:
 gnucash/gnome-utils/dialog-options.c | 2020 +++++++++++++++++-----------------
 gnucash/gnome-utils/dialog-options.h |   54 +-
 libgnucash/app-utils/option-util.c   | 1091 +++++++++---------
 libgnucash/app-utils/option-util.h   |  351 +++---
 4 files changed, 1729 insertions(+), 1787 deletions(-)



More information about the gnucash-patches mailing list