gnucash maint: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Sat Sep 5 18:53:09 EDT 2020
Updated via https://github.com/Gnucash/gnucash/commit/706277e6 (commit)
via https://github.com/Gnucash/gnucash/commit/3d98ba09 (commit)
via https://github.com/Gnucash/gnucash/commit/bbdd4f34 (commit)
from https://github.com/Gnucash/gnucash/commit/bc9c717d (commit)
commit 706277e6a899cd58b7dd058f67d3570d012b4f03
Merge: bc9c717d9 3d98ba092
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Sep 5 15:50:28 2020 -0700
Merge Jean Laroche's '797900_check_repair_crash' into maint.
commit 3d98ba092f147bf738a5f5a746568a3a1941854a
Author: jean <27791933+jeanlaroche at users.noreply.github.com>
Date: Thu Aug 27 17:00:32 2020 -0700
Fix reversed logic in gnc_quartz_should_quit
commit bbdd4f34b626a7489129bb1bf26dcfa7fccb2393
Author: jean <27791933+jeanlaroche at users.noreply.github.com>
Date: Sat Aug 22 16:11:17 2020 -0700
Bug 797900 - Crash caused by Quitting while Check and Repair All is running
The account tree page didn't have a "finish" function normally used to verify a page can close.
I added one, along with two flags that indicate whether a scrubbing operation is currently ongoing
and whether we should quit when the scrubbing is done.
The result is: If a user attempts to quit while scrubbing isn't done, an alert pops up asking whether the
user wants to abort the scrub. If so, the scrub is aborted (safely) and GC quits.
If not the app does not quit.
I have to say, I'm not sure this is the right way to do this. In my view, the right way would be:
- Disable the "quit" menu when scrubbing is happening (for some reason gnc_suspend_gui_refresh() does
not cause the quit menu to be grayed) so there's no chance of quitting while scrubbing is ongoing
- If needed, add an abort scrubbing button to the main window. Not sure whether that's desirable or not.
Let me know what you think: is what I have what we need, or would the above be better.
Summary of changes:
gnucash/gnome-utils/gnc-main-window.c | 7 ++++-
gnucash/gnome/gnc-plugin-page-account-tree.c | 32 ++++++++++++++++++--
gnucash/gnome/gnc-plugin-page-register.c | 26 ++++++++++++++++
libgnucash/engine/Scrub.c | 44 ++++++++++++++++++++++++----
libgnucash/engine/Scrub.h | 10 +++++++
5 files changed, 110 insertions(+), 9 deletions(-)
More information about the gnucash-patches
mailing list