gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/5e6f9b34 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/44fc52f5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1c556171 (commit)
	from  https://github.com/Gnucash/gnucash/commit/d642397d (commit)



commit 5e6f9b3460f2db06f60f273dbd20bb06986514d8
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Sep 25 12:31:52 2020 -0700

    Fix some return of ptr-to-temporary errors
    
    Flagged by new clang Apple version 12.

commit 44fc52f5c64fdd95d2dc68f9af63857d070228cd
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Sep 25 12:31:13 2020 -0700

    Fix unnecessary copy in range-for loop
    
    Flagged by new clang Apple version 12.

commit 1c5561714def3babc9618ad3342a16b91ec9f8c2
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Sep 25 12:23:56 2020 -0700

    Fix ptr-comparison-to-string-literal error
    
    A new error raised in the latest versions of gcc and clang.
    
    The address of string literals is undefined in the C standard so the
    compiler raises an error if one tries to test for string equality by
    comparing them. A better fix would be to replace QOF_ID strings with an
    int-based identifier; an even better one would get rid of QOF_ID
    entirely and use the C++ type system.



Summary of changes:
 libgnucash/backend/dbi/gnc-dbisqlconnection.cpp |  2 +-
 libgnucash/engine/qof-backend.hpp               |  2 +-
 libgnucash/engine/qofid.h                       | 22 +---------------------
 libgnucash/engine/qofsession.cpp                | 12 +++++++-----
 libgnucash/engine/qofsession.hpp                |  4 ++--
 5 files changed, 12 insertions(+), 30 deletions(-)