gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/ed486a58 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2258e7a4 (commit)
	from  https://github.com/Gnucash/gnucash/commit/2e7fcad8 (commit)



commit ed486a58a45adcb90e6f1e5232b6d348bed83a4c
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Apr 24 15:44:08 2021 -0700

    Fix duplicate trading accounts.
    
    In many cases GnuCash would create a new trading account hierarchy
    when one already existed because gnc_account_lookup_by_type_and_commodity
    didn't check the account presented and didn't recurse down the
    account hierarchy correctly.

commit 2258e7a44ea550c709d9c429a973d66add31e5ec
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Apr 24 15:42:01 2021 -0700

    xaccAccountTypes was backwards
    
    vs. the documentation. The unit tests and dialog-account were similarly
    backwards, but the use in gnucash/import-export/ofx followed the docs.



Summary of changes:
 gnucash/gnome-utils/dialog-account.c     |  4 +--
 libgnucash/engine/Account.cpp            | 43 ++++++++++++++++++++++++++------
 libgnucash/engine/test/utest-Account.cpp | 11 ++++----
 3 files changed, 42 insertions(+), 16 deletions(-)