gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/d099d39a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fd56512c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9062be3d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f6766d42 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ddc423a5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/621704eb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4a5b5f3b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/320df7e4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/41329396 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bf8fe112 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f15402a9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/79d6154c (commit)



commit d099d39afd36b672a55956c34d105d940b6ea9af
Merge: fd56512cf bf8fe1123
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed Aug 4 15:52:51 2021 -0700

    Merge Simon Arlott's 'commit-root-on-load' into maint.

commit fd56512cf77ad14520d7e27f8b63c13b9b023ec6
Merge: 9062be3d4 f15402a9a
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed Aug 4 15:48:42 2021 -0700

    Merge Simon Arlott's 'load-test-xml' into maint.

commit 9062be3d47d669bbacf2ac4475b5243ddf416e3f
Merge: f6766d42e 413293961
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed Aug 4 14:26:27 2021 -0700

    Merge Simon Arlott's 'string-cache-fixes' into maint.

commit f6766d42ece18f11e9c6ba817325a007b50cc14c
Merge: ddc423a50 4a5b5f3bf
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed Aug 4 14:19:21 2021 -0700

    Merge Simon Arlott's 'string-cache-no-refcount-empty' into maint.

commit ddc423a5054f535ee56bae11a54dbb8c9a38c11b
Merge: 79d6154cb 621704ebe
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed Aug 4 14:18:16 2021 -0700

    Merge Simon Arlott's 'bug-798238' into maint.

commit 621704ebeb2d182be6784ea6602c6fbd3f3b67ce
Author: Simon Arlott <sa.me.uk>
Date:   Mon Jul 12 19:23:56 2021 +0100

    Bug 798238 - "New security" dialog doesn't save the "Display symbol"
    
    When creating a new commodity the display symbol isn't saved so it defaults
    to one of the other values as appropriate.
    
    After creating the new commodity (without providing a user symbol), set
    the user symbol.

commit 4a5b5f3bf2e7616c2da600ecf25bb470e5710c0c
Author: Simon Arlott <sa.me.uk>
Date:   Thu Jul 8 20:43:02 2021 +0100

    Don't cache the empty string
    
    Avoid unnecessary reference counting for uses of the empty string.

commit 320df7e4096e504ca002b794064aace27007d06d
Author: Simon Arlott <sa.me.uk>
Date:   Thu Jul 8 20:42:03 2021 +0100

    Use const return values for string cache
    
    This is a prerequisite for being able to return "" (which is const) and
    none of the returned values should ever be modified.

commit 4132939612aff073f3d2afab77171b9c9d59881d
Author: Simon Arlott <sa.me.uk>
Date:   Sun Jul 11 18:51:41 2021 +0100

    Avoid leaking string cache entries for "" in Transaction and Split
    
    When g_object_new() is used, the strings that default to "" are added to
    the string cache. These are then not correctly removed when updating them
    with new values when cloning a Transaction/Split.
    
    Use CACHE_REPLACE instead of CACHE_INSERT.

commit bf8fe1123c6acad373514ba8160727cdd0501e52
Author: Simon Arlott <sa.me.uk>
Date:   Sun Jul 11 15:04:43 2021 +0100

    Commit root accounts after loading from XML
    
    The root accounts start with a non-zero editlevel because BeginEdit is
    called for them during loading but not committed after loading.
    
    If the book is then closed without performing any further edits that would
    require a commit, the Account book_end process does nothing because the
    root account is still being edited and so none of the accounts are freed.

commit f15402a9a603f0cb8e70f8ff89a5235e8be494f5
Author: Simon Arlott <sa.me.uk>
Date:   Sun Jul 11 14:53:57 2021 +0100

    Load test data from XML properly
    
    If qof_session_new() is called without a book then qof_session_load()
    won't do anything.
    
    Set up a book for it to use.



Summary of changes:
 gnucash/gnome-utils/dialog-commodity.c         |  2 +
 gnucash/gnome-utils/gnc-component-manager.c    |  4 +-
 libgnucash/backend/xml/io-gncxml-v2.cpp        |  9 ++-
 libgnucash/backend/xml/test/test-load-xml2.cpp |  8 ++-
 libgnucash/engine/Account.cpp                  | 20 +++----
 libgnucash/engine/AccountP.h                   |  6 +-
 libgnucash/engine/Split.c                      |  6 +-
 libgnucash/engine/SplitP.h                     |  8 +--
 libgnucash/engine/Transaction.c                | 21 +++----
 libgnucash/engine/TransactionP.h               |  4 +-
 libgnucash/engine/gnc-budget.c                 |  4 +-
 libgnucash/engine/gnc-commodity.c              | 26 ++++-----
 libgnucash/engine/gnc-pricedb-p.h              |  2 +-
 libgnucash/engine/gnc-pricedb.c                |  6 +-
 libgnucash/engine/gncAddress.c                 | 26 ++++-----
 libgnucash/engine/gncBillTerm.c                | 10 +---
 libgnucash/engine/gncCustomer.c                | 12 ++--
 libgnucash/engine/gncEmployee.c                | 14 ++---
 libgnucash/engine/gncEntry.c                   | 12 ++--
 libgnucash/engine/gncInvoice.c                 | 12 ++--
 libgnucash/engine/gncJob.c                     | 12 ++--
 libgnucash/engine/gncOrder.c                   | 26 ++++-----
 libgnucash/engine/gncTaxTable.c                |  8 +--
 libgnucash/engine/gncVendor.c                  | 12 ++--
 libgnucash/engine/kvp-frame.cpp                |  2 +-
 libgnucash/engine/qof-string-cache.cpp         | 13 +++--
 libgnucash/engine/qof-string-cache.h           |  6 +-
 libgnucash/engine/qofbook.cpp                  |  2 +-
 libgnucash/engine/test/test-qof-string-cache.c |  8 +--
 libgnucash/engine/test/utest-Account.cpp       |  4 +-
 libgnucash/engine/test/utest-Split.cpp         |  4 +-
 libgnucash/engine/test/utest-Transaction.cpp   | 78 +++++++++++++-------------
 32 files changed, 181 insertions(+), 206 deletions(-)