gnucash master: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/9d1c73f9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/91b1d291 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/972fd452 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ab8277e9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/329ca0e4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/73822f97 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/99c2c82c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6070aecd (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5dab3369 (commit)
	from  https://github.com/Gnucash/gnucash/commit/88ecf8dd (commit)



commit 9d1c73f91a62e1184565a198dfdd8ee4830ddc03
Merge: 88ecf8dd1 91b1d291a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Dec 3 17:41:33 2021 +0800

    Merge branch 'master-fix-budget-signs' PR #585

commit 91b1d291a54e3ea44b3bb82fa174c57cd0029c82
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Dec 2 22:28:49 2021 +0800

    [3/3][gnc-ui-util.c] Remove unused functions
    
    These functions were used to (optionally) reverse amounts according to
    whether the feature GNC_FEATURE_BUDGET_UNREVERSED was set. They are
    now obsolete because code will now assume feature is set for all
    loaded datafiles.

commit 972fd452025f68e917bfe72549fae7086ee2dc14
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Dec 2 22:31:29 2021 +0800

    [2/3][budget editor] remove backward-compatibility code
    
    Previously the budget editor would sign-reverse budget amounts for
    some account types prior to saving in datafile. This code is now
    obsolete. Sign reversal is now a display mechanic in the budget viewer
    only.

commit ab8277e9c415e267c4d47674c76e32c5cedb7153
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Dec 2 22:31:16 2021 +0800

    [1/3][reports.scm] remove backward-compatibility code
    
    We can now assume that all budget amounts now use natural
    numbers. Remove handling old reversed-budget amounts.

commit 329ca0e4916df2f5042c19e8079f650d6aa83dad
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Aug 27 20:37:58 2021 +0800

    [2/2][gnc-file.c] launch scrubbing and inform user after file-load
    
    Note the feature check and checking for budgets is done in
    ScrubBudget.c

commit 73822f97a958dd2b2a732e4453cc5747450e09f7
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Aug 27 20:37:50 2021 +0800

    [1/2][Scrubbudget.c] use heuristics to scrub budget signs
    
    If book has budgets, and GNC_FEATURE_BUDGET_UNREVERSED isn't set,
    check and fix budget amount signs. Previously budgets were created
    with assumption that sign reversal was set to credit amounts. A
    heuristic approach is used:
    
    - if budgeted expense is negative, conclude sign reversal is
    "Income and Expense"
    
    - if budgeted liability is positive, conclude sign reversal is
    "None"
    
    - otherwise conclude sign reversal is "Credit Accounts"
    
    The above is calibrated to (hopefully) prefer sign reversal of Credit
    Accounts.

commit 99c2c82c98220fd1f95add33b0d1201cbf5191f0
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Mar 6 18:14:25 2021 +0800

    [3/3][gnc-plugin-budget.c] set/unset feature creating/deleting budget
    
    If creating budget, and unfeatured, set feature.
    If deleting budget, and num(budgets) == 0 afterwards, unset feature

commit 6070aecd69785c8f51727aea4df1d7c8b5fcc3e3
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Dec 2 22:12:29 2021 +0800

    [2/3][gnc-features.c] add & expose gnc_features_set_unused
    
    same as gnc_features_set_used but removes feature

commit 5dab33694fbbe82f4aa46ad148584ec105385372
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Dec 2 22:12:12 2021 +0800

    [1/3][qofbook.cpp] add & expose qof_book_unset_feature
    
    same as qof_book_set_feature but removes feature item



Summary of changes:
 gnucash/gnome-utils/gnc-file.c                     |  26 ++-
 gnucash/gnome/gnc-budget-view.c                    |  97 +++-------
 gnucash/gnome/gnc-plugin-budget.c                  |  17 ++
 gnucash/gnome/gnc-plugin-page-budget.c             |   9 +-
 .../reports/standard/budget-balance-sheet.scm      |   2 +-
 .../reports/standard/budget-income-statement.scm   |   2 +-
 gnucash/report/reports/standard/budget.scm         |  43 +----
 .../report/reports/standard/test/test-budget.scm   |   4 +-
 libgnucash/app-utils/app-utils.i                   |   2 -
 libgnucash/app-utils/gnc-ui-util.c                 |  17 --
 libgnucash/app-utils/gnc-ui-util.h                 |  10 -
 libgnucash/engine/CMakeLists.txt                   |   2 +
 libgnucash/engine/ScrubBudget.c                    | 211 +++++++++++++++++++++
 .../engine/ScrubBudget.h                           |  42 ++--
 libgnucash/engine/gnc-features.c                   |  21 ++
 libgnucash/engine/gnc-features.h                   |   7 +
 libgnucash/engine/qofbook.cpp                      |  21 ++
 libgnucash/engine/qofbook.h                        |   1 +
 po/POTFILES.in                                     |   1 +
 19 files changed, 355 insertions(+), 180 deletions(-)
 create mode 100644 libgnucash/engine/ScrubBudget.c
 copy gnucash/register/register-core/table-control.c => libgnucash/engine/ScrubBudget.h (71%)