gnucash maint: Multiple changes pushed

Tue Jun 8 14:58:50 EDT 2021

Updated	 via  https://github.com/Gnucash/gnucash/commit/66685f04 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8f063159 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/862e0ca5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/08b578a2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/510e186e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/92b877cc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/faaed371 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/51b06252 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/7ee9dac2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/db6f2337 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/788166b3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b728a331 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/32f605ae (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6facaa06 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/748dbf54 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/435bb1c7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5779e72d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d55060c0 (commit)
	from  https://github.com/Gnucash/gnucash/commit/115b7bc2 (commit)


commit 66685f042ecb53bdcd5b2c67537b37cd4de5aeaa
Merge: 115b7bc2b 8f0631590
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Jun 8 11:57:18 2021 -0700

    Merge Bob Fewell's 'bug796761' into maint.

commit 8f0631590b9952bf98c76da842327b348a87c6aa
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 11:01:23 2021 +0100

    Add validation to the use of GNCAmountEdit for rest
    
    Add validation of GNCAmountEdit where used in the remaining source
    files and make changes required for the change in GNCAmountEdit widget.

commit 862e0ca579e2ca2cc269b8d452adeadb1c8337eb
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 11:00:39 2021 +0100

    Add validation to the use of GNCAmountEdit for search
    
    Add validation of GNCAmountEdit where used in the search source
    files and make changes required for the change in GNCAmountEdit widget.

commit 08b578a2e44d485275f24010927c69f5879df8a1
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:59:52 2021 +0100

    Add validation to the use of GNCAmountEdit for fincalc
    
    Add validation of GNCAmountEdit where used in the fincalc source files
    and make changes required for the change in GNCAmountEdit widget.

commit 510e186ed28c6c7fba44df84d87e33ca6ca30676
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:59:10 2021 +0100

    Add validation to the use of GNCAmountEdit for assistants
    
    Add validation of GNCAmountEdit where used in the assistant source
    files and make changes required for the change in GNCAmountEdit widget.

commit 92b877ccd1864224a0f02431e17d4453c3fbcca0
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:58:29 2021 +0100

    Add validation to the use of GNCAmountEdit for Business
    
    Add validation of GNCAmountEdit where used in the Business source files
    and make changes required for the change in GNCAmountEdit widget.

commit faaed371ed3f5bb1083284bd762e3d22d4b1216f
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:57:35 2021 +0100

    Bug 798144 - Reconciliation uses different number than entered
    
    If a number was pasted into the balance end value with a currency
    symbol the number would silently fail on evaluate and cause the wrong
    value to be used. With previous changes to the GNCAmountEdit widget a
    warning symbol will indicate a validation error and prevents going
    forward.

commit 51b062524b8f841a50554177cce135f68396d592
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:56:22 2021 +0100

    Change GNCAmountEdit to be based on a GtkBox
    
    To indicate that the expression entered has failed change the widget it
    is based on to a box and add a warning triangle image with tooltip that
    is made visible when the validation has failed. This is less intrusive
    but if required the error message can be retrieved and used for a
    warning dialog if that is in keeping with other dialog checks.

commit 7ee9dac2e9d428ade889deb5e3f64c3d45e1d3eb
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:55:42 2021 +0100

    Add filter for currency symbol for GNCAmountEdit widget
    
    When pasting an amount that includes the currency symbol the validation
    will silently fail which may lead to unusual behaviour.

commit db6f2337051434135ea8b7747546bfc1ead80b8e
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:53:56 2021 +0100

    Incorrect validation for GNCAmountEdit
    
    gnc_amount_edit_expr_is_valid can return 0 for validation OK, 1 for an
    error with no position information and also the position of that error.
    If the error was at position 0, that will look like the validation was
    OK so instead return 1 and use a GError parameter using the position as
    the code and setting the message to the common format used. Also as
    gnc_amount_edit_evaluate could also benefit from using the GError add
    that as a parameter and initially set all occurrences of use to NULL.

commit 788166b3a74056a858949873652abff3c4ab6c1a
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:53:09 2021 +0100

    Filter control characters when pasted to GNCAmountEdit

commit b728a331cfcd699b4b4a0899e3594dfa632ab7f8
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon May 31 10:52:33 2021 +0100

    Realign source file gnc-amount-edit.* for white space

commit 32f605aec2e63140563908dfc6c65344899844fc
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 27 11:59:48 2021 +0100

    Extract common code used in pricecell and formulacell to basiccell

commit 6facaa0683ac7f7676f17d2e42f7f20a1a5b5130
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 27 11:36:25 2021 +0100

    Change how the print_info is obtained for the register
    
    Currently the register sets up some 'print_info' values using the
    default account but if the register is a stock register they should be
    obtained from a parent account with a currency.

commit 748dbf54e0fb4ab152bedf2df8a35256b56366fa
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 27 11:35:45 2021 +0100

    Change monetary value for gnc_default_share_print_info
    
    Share values are not currencies so set the monetary value to 0 for the
    GNCPrintAmountInfo

commit 435bb1c76bab4c94be1c530bf5fa3c8218559c33
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 27 11:34:59 2021 +0100

    Parse the register monetary cells for a currency symbol
    
    Add the ability to strip the currency symbol from a registry monetary
    cell if it is pasted with one so it can be validated.

commit 5779e72db49b12f3f9c9965e2661ebe89bde6a05
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Thu May 27 11:04:28 2021 +0100

    Realign source file gnucash-item-edit.c for white space

commit d55060c0fc838d89cbdea453a2ce58c3fb1b9b45
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Mon Apr 5 14:32:48 2021 +0100

    Bug 796761 - Control characters can be pasted in register fields
    
    If copied text includes control characters they are inserted when
    pasted which can cause alignment issues. This commit filters the
    clipboard text for control characters before it is pasted.


Summary of changes:
 gnucash/gnome-search/search-double.c               |  12 +-
 gnucash/gnome-search/search-int64.c                |  12 +-
 gnucash/gnome-search/search-numeric.c              |  11 +-
 gnucash/gnome-utils/dialog-account.c               |   2 +-
 gnucash/gnome-utils/dialog-tax-table.c             |  64 +++
 gnucash/gnome-utils/dialog-transfer.c              |  16 +-
 gnucash/gnome-utils/gnc-amount-edit.c              | 597 +++++++++++++--------
 gnucash/gnome-utils/gnc-amount-edit.h              | 242 +++++++--
 gnucash/gnome/assistant-loan.cpp                   |  19 +
 gnucash/gnome/assistant-stock-split.c              |  18 +-
 gnucash/gnome/dialog-customer.c                    |  15 +-
 gnucash/gnome/dialog-employee.c                    |  28 +
 gnucash/gnome/dialog-fincalc.c                     |  52 +-
 gnucash/gnome/dialog-invoice.c                     |   6 +-
 gnucash/gnome/dialog-job.c                         |   8 +
 gnucash/gnome/dialog-payment.c                     |  61 ++-
 gnucash/gnome/dialog-price-editor.c                |  17 +-
 gnucash/gnome/window-autoclear.c                   |  44 +-
 gnucash/gnome/window-reconcile.c                   |  41 +-
 gnucash/gnome/window-reconcile2.c                  |  43 +-
 gnucash/gtkbuilder/dialog-fincalc.glade            |   5 +
 gnucash/register/ledger-core/split-register-load.c |  15 +-
 gnucash/register/register-core/basiccell.c         |  57 ++
 gnucash/register/register-core/basiccell.h         |   8 +
 gnucash/register/register-core/formulacell.c       |  49 +-
 gnucash/register/register-core/pricecell.c         |  45 +-
 .../register/register-gnome/gnucash-item-edit.c    | 263 +++++----
 libgnucash/app-utils/gnc-ui-util.c                 | 146 +++++
 libgnucash/app-utils/gnc-ui-util.h                 |  50 ++
 29 files changed, 1408 insertions(+), 538 deletions(-)