gnucash maint: Multiple changes pushed

Robert Fewell bobit at
Mon Jun 21 05:31:29 EDT 2021

Updated	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit 4cff5aa197107cf4a552d2156b936b0c7b3242af
Author: Robert Fewell <14uBobIT at>
Date:   Sat Jun 19 13:07:58 2021 +0100

    Refactor gnc_combo_cell_modify_verify to make it clearer.

commit afd61f749337968c30c0c4458dd012e976a02af0
Author: Robert Fewell <14uBobIT at>
Date:   Sat Jun 19 12:43:34 2021 +0100

    Type ahead not working properly on subsequent key strokes
    When in the transfer cell and you are searching for the 'fuel' account,
    entering the 'f' would bring up all accounts containing an 'f' but when
    the next letter 'u' is entered it would show all accounts containing a
    'u'. This is down to the transfer cell being updated to early from a
    gnc_item_list_select which is being used for the quick fill so test for
    quick fill use first.

commit ea2a54bf9e5440aebb1f999410be9d163fdf6108
Author: Robert Fewell <14uBobIT at>
Date:   Sat Jun 19 12:43:18 2021 +0100

    Bug 798162 - Type Ahead Initialization Problem
    If navigating by the keyboard and you tab to the transfer cell and then
    type a letter, we get to gnc_item_edit_show_popup which starts to
    create and hopefully show the pop up list.
    But on first use, cell height obtained by gnc_item_list_get_cell_height
    can be 1 pixel less than required. This should be corrected by the
    check_popup_height_is_true function which calls gnc_item_edit_update
    via an idle function. As part of that function, a check is made for
    item_edit->show_popup being set but that was only getting set in the
    gnc_item_edit_popup_toggled call back so the pop up would not show.
    To fix set item_edit->show_popup after setting the toggle button arrow

Summary of changes:
 gnucash/register/register-gnome/combocell-gnome.c  | 34 ++++++++++++----------
 .../register/register-gnome/gnucash-item-edit.c    |  1 +
 2 files changed, 19 insertions(+), 16 deletions(-)

More information about the gnucash-patches mailing list