gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/f10b0339 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/da3c511b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4f030aac (commit)
	 via  https://github.com/Gnucash/gnucash/commit/18c72bad (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2b48fd37 (commit)
	from  https://github.com/Gnucash/gnucash/commit/d2a4aef3 (commit)



commit f10b0339fbe7ce2a5c071b049e42ed6f07aa8075
Merge: d2a4aef3b da3c511b6
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 12 09:01:32 2021 -0700

    Merge John Ralls's 'bug798093bis' into maint.

commit da3c511b6c8f332ae883ab8fccdfec868f42d425
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue May 11 14:42:21 2021 -0700

    Remove trading splits instead of trying to adjust them.

commit 4f030aac6e8bb64aa687f82f92e11ab875a9bfdb
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue May 4 10:11:59 2021 -0700

    Bug 798093 - Changing the symbol/abbreviation of a security...
    
    after the trading account was created breaks GnuCash.
    
    Revisited. The original changeset looked for a top level trading account
    and a namespace account in the transaction currency; if either of those
    accounts had been created in a different currency it would duplicate
    them.
    
    This commit will accept any such account regardless of commodity. If
    more than one exists it will prefer the one in the root currency if
    there is one, otherwise it will select the first one found.

commit 18c72baddf3c200252ffd5eac3274351fcec42a7
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue May 4 13:20:01 2021 -0700

    Don't bother scrubbing for orphans if there's no transaction currency.
    
    If it found one it would try to create an orphan account with no
    currency which will crash later.

commit 2b48fd375de12c1b4a6a896133a0fddd0aa92dbf
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon May 3 17:16:23 2021 -0700

    Revert "Fix duplicate trading accounts."
    
    This reverts commit ed486a58a45adcb90e6f1e5232b6d348bed83a4c.



Summary of changes:
 libgnucash/engine/Account.cpp |  39 ++----
 libgnucash/engine/Account.h   |  24 ++--
 libgnucash/engine/Scrub.c     | 310 ++++++++++++++++++++----------------------
 3 files changed, 171 insertions(+), 202 deletions(-)