gnucash master: Multiple changes pushed

Christopher Lam clam at code.gnucash.org
Thu Sep 2 10:17:41 EDT 2021


Updated	 via  https://github.com/Gnucash/gnucash/commit/8d502fcd (commit)
	 via  https://github.com/Gnucash/gnucash/commit/881d3dcd (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9b30a232 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ac5650a9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1eb67093 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/323182c9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8a37c4c0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9ec670f8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d4c8b36f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c3b50f0b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/595e126a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c5a6383b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/86c438dc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/52715fac (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bda03a1c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f97821e0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/22e64905 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1a049f4e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1a12489e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5d15f95f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/998e14c1 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0c21ae35 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e13644df (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8a48ed97 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/001b3461 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a47bee97 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0ecbcb4e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ac2afc7e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3bf49ed8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e3af2f22 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/57f73d70 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6cb509ea (commit)
	from  https://github.com/Gnucash/gnucash/commit/c6d83338 (commit)



commit 8d502fcdd808d0f16e35833bbb87e032a34a8740
Merge: c6d833381 881d3dcd2
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Sep 2 22:17:22 2021 +0800

    Merge branch 'maint'

commit 881d3dcd2358b6180a1434e5f493e53c5af98c7b
Author: TianXing_Yi <ytx.cash at gmail.com>
Date:   Tue Aug 31 16:33:43 2021 +0200

    Translation update  by TianXing_Yi <ytx.cash at gmail.com> using Weblate
    
    po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Chinese (Simplified))
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/
    
    Translation update  by TianXing_Yi <ytx.cash at gmail.com> using Weblate
    
    po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Chinese (Simplified))
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/
    
    Co-authored-by: TianXing_Yi <ytx.cash at gmail.com>

commit 9b30a2327bb129bd2c032937573db8b247113e34
Merge: ac5650a9a 86c438dcf
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Aug 31 12:54:53 2021 -0700

    Merge Chris Good's 'MaintGenTrnImpMatFixCrash' into maint.

commit ac5650a9a2b7b91761cabfbf06a41b0aa300e9ce
Merge: bda03a1c5 1eb670933
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 23:30:24 2021 +0800

    Merge branch 'maint-g-value-leaks' into maint #1124

commit 1eb67093316519ad4e43d20ba7c87e4b92bf37d6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 00:27:30 2021 +0800

    [test-lots.cpp] add kvp getter/setter changes

commit 323182c9f772fcb07f348a83abcab5b04d87871e
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 11:32:54 2021 +0800

    [utest-Account.cpp] add kvp getter/setter changes

commit 8a37c4c019395dee61293de56eeb796b14f76f26
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 00:13:06 2021 +0800

    [utest-Invoice.c] add kvp getter/setter tests

commit 9ec670f8286ab5f3b568f07bd79cc7509d6d2052
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 00:06:38 2021 +0800

    [test-commodities.cpp] add kvp setter/getter test

commit d4c8b36f9f2d0e19506019a18cb2605f3bd0fba8
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Aug 30 23:58:41 2021 +0800

    [utest-Transaction.cpp] add kvp setter/getter tests
    
    wasn't tested before

commit c3b50f0b5838b396407cd0c06536fcaa7d9f6863
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 00:27:16 2021 +0800

    [gnc-lot.c] fix - cache value properly

commit 595e126a34d557bcc07c675e8cff2f3e84674471
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 11:51:37 2021 +0800

    [account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr
    
    - will remove a second call to g_strstrip (g_strdup (str))

commit c5a6383b431b04e8d487cb4a2394970000a8657c
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 11:32:23 2021 +0800

    [account.cpp] fix - incomplete #1117
    
    - init struct members properly to: is_unset and TriState::Unset
    - test acct kvp "equity-type" for "opening-balance" instead of "true"
    - cached account->color/sort_order/notes/filter gets strstripped
      similarly to previous behavior

commit 86c438dcf4ba9492af0a32fac953b5b6b865f598
Author: goodvibes2 <goodchris96 at gmail.com>
Date:   Tue Aug 31 10:06:42 2021 +1000

    Fix unneeded double call to get_action_for_path()
    
    in gnc_gen_trans_onButtonPressed_cb().

commit 52715face7808f7f3bd3ab590a5feaa2c8516a0b
Author: goodvibes2 <goodchris96 at gmail.com>
Date:   Tue Aug 31 09:53:38 2021 +1000

    Fix 2 crashes in Generic Transaction Matcher
    
    Both dumped core in gnc_import_TransInfo_get_action() because info
    is null
    1. After double clicking on a potential match line, then right clicking
    on the the parent transaction of the potential match
    2. After rubber banding a group of transactions which also includes an
    expanded potential match. Sometimes also need to right click the
    selection to trigger the core dump.

commit bda03a1c5620860acc041269f011ffa906abd80b
Author: Giuseppe Foti <foti.giuseppe at gmail.com>
Date:   Mon Aug 30 17:32:28 2021 +0200

    Translation update  by Giuseppe Foti <foti.giuseppe at gmail.com> using Weblate
    
    po/it.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Italian)
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/it/
    
    Co-authored-by: Giuseppe Foti <foti.giuseppe at gmail.com>

commit f97821e07281be96d4f21d9bf0263fddf02dd86e
Author: Avi Markovitz <avi.markovitz at gmail.com>
Date:   Mon Aug 30 17:32:27 2021 +0200

    Translation update  by Avi Markovitz <avi.markovitz at gmail.com> using Weblate
    
    po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Hebrew)
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/
    
    Co-authored-by: Avi Markovitz <avi.markovitz at gmail.com>

commit 22e64905a161f7f793b2e594819d8e1203be3f07
Author: Yaron Shahrabani <sh.yaron at gmail.com>
Date:   Mon Aug 30 17:32:27 2021 +0200

    Translation update  by Yaron Shahrabani <sh.yaron at gmail.com> using Weblate
    
    po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Hebrew)
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/
    
    Co-authored-by: Yaron Shahrabani <sh.yaron at gmail.com>

commit 1a049f4ef588403d1c29e2fe63e19c460e7ff1be
Author: Avi Markovitz <avi.markovitz at gmail.com>
Date:   Mon Aug 30 17:32:26 2021 +0200

    Translation update  by Avi Markovitz <avi.markovitz at gmail.com> using Weblate
    
    po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Hebrew)
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/
    
    Translation update  by Avi Markovitz <avi.markovitz at gmail.com> using Weblate
    
    po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Hebrew)
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/
    
    Co-authored-by: Avi Markovitz <avi.markovitz at gmail.com>

commit 1a12489ef943ed92f541ec53403e0a744511ac02
Author: TianXing_Yi <ytx.cash at gmail.com>
Date:   Mon Aug 30 17:32:25 2021 +0200

    Translation update  by TianXing_Yi <ytx.cash at gmail.com> using Weblate
    
    po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
    0 failing checks (0.0%)
    Translation: GnuCash/Program (Chinese (Simplified))
    Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/
    
    Co-authored-by: TianXing_Yi <ytx.cash at gmail.com>

commit 5d15f95f9e8761b9939c86ebe50e7a689cd1100e
Merge: 0c21ae352 998e14c10
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 31 00:38:01 2021 +0800

    Merge branch 'maint-leaks' into maint #1116

commit 998e14c1074e0caebf53782d51810c5874e89a6d
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Aug 20 21:37:33 2021 +0800

    gtk_list_store_new returning a GObject must be g_object_unref
    
    GObjects were not consistently unrefed.

commit 0c21ae35221b49c640d1025d66ea024e24db15c2
Author: Mike Alexander <mta at umich.edu>
Date:   Mon Aug 30 03:09:23 2021 -0400

    Handle very large denominators in precies from Finance::Quote
    
    The OpenExchange exchange rate source in Finance::Quote produces
    some ridiculously precise prices like #e6.95253159056541e-5 which
    produce a denominator greater than INT64_MAX.  Use the rationalize
    function to bring them back to reality.

commit e13644dffc1375c568ffcd2f80efd2d9825be561
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Aug 28 22:05:37 2021 +0800

    free GtkTreePath after calling gtk_tree_view_get_path_at_pos

commit 8a48ed977750798dfc0fd49a243a593347d256c5
Merge: 57f73d70c 001b34616
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Aug 30 08:43:13 2021 +0800

    Merge branch 'maint-cache-gvalue-string' into maint #1117
    
    Will store a copy of kvp data onto struct so that GValue can be
    freed (unset) cleanly.

commit 001b34616f0b0b9450ae55ca0effab4ae9f55c5a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Aug 24 21:38:16 2021 +0800

    [Transaction.c] GValue string must be unset

commit a47bee97d634204a742e05e02c18c5ad5107ff00
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Aug 23 23:22:06 2021 +0800

    [Split.c] GValue string must be unset

commit 0ecbcb4ef1701732872a205779633e3e36160bbf
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Aug 23 23:21:46 2021 +0800

    [gnc-lot.c] GValue string must be unset

commit ac2afc7e13babd4c850e3831318a705f9996feef
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Aug 23 18:44:23 2021 +0800

    [gncInvoice.c] GValue string must be unset

commit 3bf49ed8d7c806a550d07fc2d803b64c2e78f196
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Aug 23 18:05:08 2021 +0800

    [Account.cpp] GValue string must be unset

commit e3af2f22f9aec70131dc2da8d9c9eceade1a52ad
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Aug 22 11:17:28 2021 +0800

    [gnc-commodity.c] cache user_symbol into commodity struct
    
    Continuation of ff2ceb111 which introduced issue whereby user_symbol
    returned could become stale, leading to invalid read fixed with
    c398bef59. There are likely other user_symbol pointers becoming stale
    without this commit.
    
    This change will save the user_symbol into the commodity struct,
    avoids gchar* becoming stale.

commit 57f73d70c725652e6acaf67c2a4a2be8c2ef027a
Merge: b42052464 6cb509ea7
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 27 12:34:07 2021 -0700

    Merge Yordan Miladinov's denom_lcd into maint.

commit 6cb509ea7d247a565a057359f080fcd0a52a27c1
Author: Yordan Miladinov <jordanmiladinov at gmail.com>
Date:   Tue Aug 24 00:58:31 2021 +0300

    fix an uncaught exception: denom_lcd may throw an overflow exception if casting lcm to int64_t fails



Summary of changes:
 gnucash/gnome-search/gnc-general-search.c          |   1 +
 gnucash/gnome-utils/dialog-object-references.c     |   1 +
 gnucash/gnome-utils/gnc-account-sel.c              |   7 +-
 gnucash/gnome-utils/gnc-dense-cal.c                |   1 +
 gnucash/gnome/assistant-hierarchy.c                |   2 +
 gnucash/gnome/dialog-custom-report.c               |   6 +
 gnucash/gnome/dialog-print-check.c                 |   2 +
 gnucash/gnome/dialog-report-style-sheet.c          |   2 +-
 gnucash/gnome/gnc-budget-view.c                    |  13 ++
 .../csv-imp/assistant-csv-account-import.c         |   1 +
 .../csv-imp/assistant-csv-price-import.cpp         |   4 +
 .../csv-imp/assistant-csv-trans-import.cpp         |   2 +
 gnucash/import-export/import-main-matcher.c        |   8 +-
 gnucash/price-quotes.scm                           |   8 +-
 gnucash/register/register-gnome/combocell-gnome.c  |   6 +
 libgnucash/engine/Account.cpp                      | 131 +++++++++++++++++----
 libgnucash/engine/AccountP.h                       |  14 +++
 libgnucash/engine/Split.c                          |  35 ++++--
 libgnucash/engine/SplitP.h                         |   2 +
 libgnucash/engine/Transaction.c                    | 111 +++++++++++------
 libgnucash/engine/TransactionP.h                   |   4 +
 libgnucash/engine/gnc-commodity.c                  |  52 ++++++--
 libgnucash/engine/gnc-lot.c                        |  58 +++++++--
 libgnucash/engine/gnc-numeric.cpp                  |   9 +-
 libgnucash/engine/gncInvoice.c                     |  41 ++++++-
 libgnucash/engine/test/test-commodities.cpp        |   5 +
 libgnucash/engine/test/test-lots.cpp               |  46 ++++++++
 libgnucash/engine/test/utest-Account.cpp           | 100 ++++++++++++++++
 libgnucash/engine/test/utest-Invoice.c             |  22 ++++
 libgnucash/engine/test/utest-Transaction.cpp       |  21 ++++
 po/he.po                                           |  28 ++---
 po/it.po                                           |   4 +-
 po/zh_CN.po                                        |  26 ++--
 33 files changed, 639 insertions(+), 134 deletions(-)



More information about the gnucash-patches mailing list