gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/73a13473 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/598a6f1b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f6cc6eda (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5e7bc1d6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/86284838 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6a9e1cb2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/17eb739d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0bc2d692 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5519a9d7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e116a4f1 (commit)
	from  https://github.com/Gnucash/gnucash/commit/b4bab92d (commit)



commit 73a134730f682e54e15f4813df6946abdb45db4a
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Dec 13 13:13:13 2022 -0800

    Bug 798680 - Not able to match a reverse transaction of a...
    
    previously matched transaction.
    
    Cloned transactions and copied splits shouldn't keep the online-id
    slot.

commit 598a6f1b6b565e9eb335c43c278202d498ff1fc3
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Dec 13 12:03:03 2022 -0800

    [ofx import] Propose parent account unless last account is right commodity.

commit f6cc6eda4c11a204c9abe4e7e6d681fb019fe00e
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Dec 13 11:53:42 2022 -0800

    [ofx import] Make automatic account creation work.
    
    When Preferences>Import>Automatic commodity creation is enabled.
    
    Note that this behavior isn't indicated in the tooltip and is a bit
    clunky: the user has to cancel the manual account selection for it
    to fire.

commit 5e7bc1d6c214d1faeab271215721e4348f7a9ef5
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Dec 12 18:02:42 2022 -0800

    [ofx import] Fix the parentage of the select account windows.
    
    The account list window is gone when these are used, use the importer parent.

commit 862848380c788a23a26500562722a57a40c5a717
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Dec 10 17:18:38 2022 -0800

    Bug 798681 - Previously imported investment income transactions may not be filtered.
    
    Resequence process_investment_transaction so that the first split is
    the primary asset account split (cash unless it's a reinvest) followed
    by the security asset account if it's not income and finally the income
    split for income or reinvest transactions.
    
    Note that there's also a sign change on the income splits for
    income and reinvest transactions: testing showed the signs to be
    backwards.

commit 6a9e1cb24976c0a1a1b78f62adda2b3234d8915c
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Dec 10 16:32:25 2022 -0800

    [ofx import] Don't set online-id on income accounts.

commit 17eb739da3eef1166e7c42adb8400d031db2baf5
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Dec 8 13:38:16 2022 -0800

    [ofx import] Extract functions from ofx_proc_transaction_cb.
    
    set_transaction_dates, fill_transaction_description,
    fill_transaction_notes, process_bank_transaction,
    process_investment_transaction, choose_investment_account,
    choose_income_account, add_investment_split, add_currency_split,
    create_investment_subaccount, continue_account_selection,
    choose_investment_account_helper, choose_investment_account

commit 0bc2d692c732048f6950c514ce8d126c82810dfa
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Dec 8 13:09:10 2022 -0800

    [ofx import] Typedef OfxTransactionData.
    
    So we don't have to say struct on every use.

commit 5519a9d788c1ec6439252daf956d16c299dcd651
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Dec 10 16:26:05 2022 -0800

    [import matcher] Make related functions adjacent
    
    gnc_gen_trans_list_add_trans just wraps
    gnc_gen_trans_list_add_trans_with_ref_id.

commit e116a4f195250b782c40e51a19a53409be73b480
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Dec 13 12:32:54 2022 -0800

    [import backend] Extract function hash_account_online_ids.



Summary of changes:
 gnucash/import-export/import-backend.c      |  31 +-
 gnucash/import-export/import-main-matcher.c |  31 +-
 gnucash/import-export/ofx/gnc-ofx-import.c  | 947 +++++++++++++++-------------
 libgnucash/engine/Split.c                   |   2 +
 libgnucash/engine/Transaction.c             |   3 +
 5 files changed, 545 insertions(+), 469 deletions(-)