gnucash maint: [assistant-stock-transaction] handle sign reversal outside create_split

Christopher Lam clam at
Sun Dec 18 22:52:18 EST 2022

Updated	 via (commit)
	from (commit)

commit 52deda868ff042a2815cc6b91464a1d3415a447b
Author: Christopher Lam <christopher.lck at>
Date:   Sun Dec 18 11:39:51 2022 +0800

    [assistant-stock-transaction] handle sign reversal outside create_split
    Passing the FieldMask as an arg to create_split is the wrong approach;
    it needs to test the input_new_balance bool and the FieldMask to
    determine whether negation should take place. It's best to handle
    negation outside create_split.
    Thus cash&fee amounts are not mangled when creating a stock-split
    transaction whose input_new_balance is true.

Summary of changes:
 gnucash/gnome/assistant-stock-transaction.cpp | 82 +++++++++++++--------------
 1 file changed, 41 insertions(+), 41 deletions(-)

More information about the gnucash-patches mailing list