gnucash master: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Thu Mar 31 15:28:19 EDT 2022
Updated via https://github.com/Gnucash/gnucash/commit/1fddf70e (commit)
via https://github.com/Gnucash/gnucash/commit/abd1a0b3 (commit)
via https://github.com/Gnucash/gnucash/commit/4fe83c3b (commit)
via https://github.com/Gnucash/gnucash/commit/f4bfd9df (commit)
via https://github.com/Gnucash/gnucash/commit/278aa484 (commit)
via https://github.com/Gnucash/gnucash/commit/5457d4a9 (commit)
via https://github.com/Gnucash/gnucash/commit/30e6c8ab (commit)
via https://github.com/Gnucash/gnucash/commit/572cb6b1 (commit)
via https://github.com/Gnucash/gnucash/commit/d4c3c30b (commit)
via https://github.com/Gnucash/gnucash/commit/a7a643f7 (commit)
via https://github.com/Gnucash/gnucash/commit/65bd8602 (commit)
via https://github.com/Gnucash/gnucash/commit/6841e5b5 (commit)
via https://github.com/Gnucash/gnucash/commit/11225d97 (commit)
via https://github.com/Gnucash/gnucash/commit/16dc1596 (commit)
via https://github.com/Gnucash/gnucash/commit/759376eb (commit)
via https://github.com/Gnucash/gnucash/commit/18edc175 (commit)
via https://github.com/Gnucash/gnucash/commit/b5d0c425 (commit)
via https://github.com/Gnucash/gnucash/commit/a700701c (commit)
via https://github.com/Gnucash/gnucash/commit/eb0bd4f9 (commit)
via https://github.com/Gnucash/gnucash/commit/a3f50586 (commit)
via https://github.com/Gnucash/gnucash/commit/6cd88c23 (commit)
via https://github.com/Gnucash/gnucash/commit/e9b850cc (commit)
via https://github.com/Gnucash/gnucash/commit/66f9fc81 (commit)
via https://github.com/Gnucash/gnucash/commit/0ce841d4 (commit)
via https://github.com/Gnucash/gnucash/commit/216b483e (commit)
via https://github.com/Gnucash/gnucash/commit/947c0619 (commit)
via https://github.com/Gnucash/gnucash/commit/f26014a0 (commit)
via https://github.com/Gnucash/gnucash/commit/24d2999a (commit)
via https://github.com/Gnucash/gnucash/commit/51cc2668 (commit)
via https://github.com/Gnucash/gnucash/commit/26924937 (commit)
via https://github.com/Gnucash/gnucash/commit/6f93a68b (commit)
via https://github.com/Gnucash/gnucash/commit/c3b8b6cc (commit)
via https://github.com/Gnucash/gnucash/commit/5e84f118 (commit)
via https://github.com/Gnucash/gnucash/commit/8eddb63e (commit)
via https://github.com/Gnucash/gnucash/commit/19a2dd49 (commit)
via https://github.com/Gnucash/gnucash/commit/98049280 (commit)
via https://github.com/Gnucash/gnucash/commit/e17ee38c (commit)
via https://github.com/Gnucash/gnucash/commit/a3a381cf (commit)
via https://github.com/Gnucash/gnucash/commit/dd7feb99 (commit)
via https://github.com/Gnucash/gnucash/commit/d1fe359e (commit)
via https://github.com/Gnucash/gnucash/commit/74fd716a (commit)
via https://github.com/Gnucash/gnucash/commit/f6c9e63e (commit)
via https://github.com/Gnucash/gnucash/commit/4c43dac1 (commit)
via https://github.com/Gnucash/gnucash/commit/cf5da9ff (commit)
via https://github.com/Gnucash/gnucash/commit/96b09ded (commit)
via https://github.com/Gnucash/gnucash/commit/00a982d9 (commit)
via https://github.com/Gnucash/gnucash/commit/00c2e99d (commit)
via https://github.com/Gnucash/gnucash/commit/bed44f40 (commit)
via https://github.com/Gnucash/gnucash/commit/a487ca3f (commit)
via https://github.com/Gnucash/gnucash/commit/3935f1a9 (commit)
via https://github.com/Gnucash/gnucash/commit/62ab148a (commit)
via https://github.com/Gnucash/gnucash/commit/b3f96701 (commit)
via https://github.com/Gnucash/gnucash/commit/7392ac6f (commit)
via https://github.com/Gnucash/gnucash/commit/b361582c (commit)
via https://github.com/Gnucash/gnucash/commit/10381d42 (commit)
via https://github.com/Gnucash/gnucash/commit/97a317b5 (commit)
via https://github.com/Gnucash/gnucash/commit/3d1812aa (commit)
via https://github.com/Gnucash/gnucash/commit/bbe8ebbc (commit)
via https://github.com/Gnucash/gnucash/commit/42b4755a (commit)
via https://github.com/Gnucash/gnucash/commit/c0692462 (commit)
via https://github.com/Gnucash/gnucash/commit/53fac914 (commit)
via https://github.com/Gnucash/gnucash/commit/e77b5ec0 (commit)
via https://github.com/Gnucash/gnucash/commit/474bc360 (commit)
via https://github.com/Gnucash/gnucash/commit/1cd2cf21 (commit)
via https://github.com/Gnucash/gnucash/commit/852b2ffc (commit)
via https://github.com/Gnucash/gnucash/commit/e43ff932 (commit)
via https://github.com/Gnucash/gnucash/commit/1af97ebb (commit)
via https://github.com/Gnucash/gnucash/commit/86da12d8 (commit)
via https://github.com/Gnucash/gnucash/commit/a7f0476a (commit)
via https://github.com/Gnucash/gnucash/commit/e8f855e6 (commit)
via https://github.com/Gnucash/gnucash/commit/86d76371 (commit)
via https://github.com/Gnucash/gnucash/commit/8acf52a6 (commit)
via https://github.com/Gnucash/gnucash/commit/e4c9900c (commit)
via https://github.com/Gnucash/gnucash/commit/3c95ad8a (commit)
via https://github.com/Gnucash/gnucash/commit/8079470c (commit)
via https://github.com/Gnucash/gnucash/commit/c83a3f44 (commit)
via https://github.com/Gnucash/gnucash/commit/f0ecc0e2 (commit)
via https://github.com/Gnucash/gnucash/commit/b6622a38 (commit)
via https://github.com/Gnucash/gnucash/commit/26946d79 (commit)
via https://github.com/Gnucash/gnucash/commit/914f5f35 (commit)
via https://github.com/Gnucash/gnucash/commit/71955cc3 (commit)
via https://github.com/Gnucash/gnucash/commit/a97b3e0c (commit)
via https://github.com/Gnucash/gnucash/commit/58d090ff (commit)
via https://github.com/Gnucash/gnucash/commit/a2e1a3e1 (commit)
via https://github.com/Gnucash/gnucash/commit/99eaa81a (commit)
via https://github.com/Gnucash/gnucash/commit/0bd9033b (commit)
via https://github.com/Gnucash/gnucash/commit/0f02236e (commit)
via https://github.com/Gnucash/gnucash/commit/18997db7 (commit)
via https://github.com/Gnucash/gnucash/commit/dd8e8b4e (commit)
via https://github.com/Gnucash/gnucash/commit/05ac0564 (commit)
via https://github.com/Gnucash/gnucash/commit/9d150b1a (commit)
via https://github.com/Gnucash/gnucash/commit/f5d8d508 (commit)
via https://github.com/Gnucash/gnucash/commit/c034a26a (commit)
via https://github.com/Gnucash/gnucash/commit/67dab6b3 (commit)
via https://github.com/Gnucash/gnucash/commit/a1af86ed (commit)
via https://github.com/Gnucash/gnucash/commit/c34986da (commit)
via https://github.com/Gnucash/gnucash/commit/3f89d063 (commit)
via https://github.com/Gnucash/gnucash/commit/6eb5dfed (commit)
via https://github.com/Gnucash/gnucash/commit/29a2365f (commit)
via https://github.com/Gnucash/gnucash/commit/7885353f (commit)
via https://github.com/Gnucash/gnucash/commit/bbe74aa0 (commit)
via https://github.com/Gnucash/gnucash/commit/5a2ba091 (commit)
via https://github.com/Gnucash/gnucash/commit/7c6ecafd (commit)
via https://github.com/Gnucash/gnucash/commit/ce5fe577 (commit)
via https://github.com/Gnucash/gnucash/commit/52ef53a4 (commit)
via https://github.com/Gnucash/gnucash/commit/7239eb80 (commit)
via https://github.com/Gnucash/gnucash/commit/23461f1d (commit)
via https://github.com/Gnucash/gnucash/commit/12f8df1e (commit)
via https://github.com/Gnucash/gnucash/commit/be322a0d (commit)
via https://github.com/Gnucash/gnucash/commit/27670a6e (commit)
via https://github.com/Gnucash/gnucash/commit/a94f69d6 (commit)
via https://github.com/Gnucash/gnucash/commit/0f8446a1 (commit)
via https://github.com/Gnucash/gnucash/commit/f66a918b (commit)
via https://github.com/Gnucash/gnucash/commit/0a8f66ee (commit)
via https://github.com/Gnucash/gnucash/commit/418eb066 (commit)
via https://github.com/Gnucash/gnucash/commit/7d0cdf7c (commit)
via https://github.com/Gnucash/gnucash/commit/86a2f155 (commit)
via https://github.com/Gnucash/gnucash/commit/693e966b (commit)
via https://github.com/Gnucash/gnucash/commit/63502900 (commit)
via https://github.com/Gnucash/gnucash/commit/42185c0e (commit)
via https://github.com/Gnucash/gnucash/commit/5c743378 (commit)
via https://github.com/Gnucash/gnucash/commit/c04f4a00 (commit)
via https://github.com/Gnucash/gnucash/commit/e7309f07 (commit)
via https://github.com/Gnucash/gnucash/commit/3aa86ca9 (commit)
via https://github.com/Gnucash/gnucash/commit/4a305998 (commit)
via https://github.com/Gnucash/gnucash/commit/d9984f75 (commit)
via https://github.com/Gnucash/gnucash/commit/43cd81ba (commit)
via https://github.com/Gnucash/gnucash/commit/9bd3baff (commit)
via https://github.com/Gnucash/gnucash/commit/534a7c28 (commit)
via https://github.com/Gnucash/gnucash/commit/c62b526b (commit)
via https://github.com/Gnucash/gnucash/commit/efc73464 (commit)
via https://github.com/Gnucash/gnucash/commit/f20c358c (commit)
via https://github.com/Gnucash/gnucash/commit/b5c04771 (commit)
via https://github.com/Gnucash/gnucash/commit/f7f2d229 (commit)
via https://github.com/Gnucash/gnucash/commit/81d26189 (commit)
via https://github.com/Gnucash/gnucash/commit/16a36d91 (commit)
via https://github.com/Gnucash/gnucash/commit/7c1b4b79 (commit)
via https://github.com/Gnucash/gnucash/commit/d41292fd (commit)
via https://github.com/Gnucash/gnucash/commit/a21f329b (commit)
via https://github.com/Gnucash/gnucash/commit/8c2a8edb (commit)
via https://github.com/Gnucash/gnucash/commit/86102e1b (commit)
via https://github.com/Gnucash/gnucash/commit/53ad0ba4 (commit)
via https://github.com/Gnucash/gnucash/commit/08d1eebb (commit)
via https://github.com/Gnucash/gnucash/commit/fba02485 (commit)
via https://github.com/Gnucash/gnucash/commit/55a2ed1d (commit)
via https://github.com/Gnucash/gnucash/commit/18b83874 (commit)
via https://github.com/Gnucash/gnucash/commit/0b7ccfbd (commit)
via https://github.com/Gnucash/gnucash/commit/a602f64b (commit)
via https://github.com/Gnucash/gnucash/commit/43f4bcb6 (commit)
via https://github.com/Gnucash/gnucash/commit/7fa6778b (commit)
via https://github.com/Gnucash/gnucash/commit/cb7270ca (commit)
via https://github.com/Gnucash/gnucash/commit/76b0001c (commit)
via https://github.com/Gnucash/gnucash/commit/e2c87f23 (commit)
via https://github.com/Gnucash/gnucash/commit/ea835b31 (commit)
via https://github.com/Gnucash/gnucash/commit/472814d3 (commit)
via https://github.com/Gnucash/gnucash/commit/023db233 (commit)
via https://github.com/Gnucash/gnucash/commit/ae73b385 (commit)
via https://github.com/Gnucash/gnucash/commit/e4841601 (commit)
via https://github.com/Gnucash/gnucash/commit/7022f522 (commit)
via https://github.com/Gnucash/gnucash/commit/776d1aaa (commit)
via https://github.com/Gnucash/gnucash/commit/8c77ce96 (commit)
via https://github.com/Gnucash/gnucash/commit/90b8fce5 (commit)
via https://github.com/Gnucash/gnucash/commit/60c1d16e (commit)
via https://github.com/Gnucash/gnucash/commit/4f3fd665 (commit)
via https://github.com/Gnucash/gnucash/commit/b19f3d38 (commit)
via https://github.com/Gnucash/gnucash/commit/52600bbd (commit)
via https://github.com/Gnucash/gnucash/commit/31a0153f (commit)
via https://github.com/Gnucash/gnucash/commit/85db341a (commit)
via https://github.com/Gnucash/gnucash/commit/21398dfd (commit)
via https://github.com/Gnucash/gnucash/commit/7dab089d (commit)
via https://github.com/Gnucash/gnucash/commit/d1cfd62f (commit)
via https://github.com/Gnucash/gnucash/commit/1f0bfe0c (commit)
via https://github.com/Gnucash/gnucash/commit/c6fce317 (commit)
via https://github.com/Gnucash/gnucash/commit/507f35cc (commit)
via https://github.com/Gnucash/gnucash/commit/8440b9c9 (commit)
via https://github.com/Gnucash/gnucash/commit/2ccfe0c1 (commit)
via https://github.com/Gnucash/gnucash/commit/276d3397 (commit)
via https://github.com/Gnucash/gnucash/commit/5f9c66aa (commit)
via https://github.com/Gnucash/gnucash/commit/6491c985 (commit)
via https://github.com/Gnucash/gnucash/commit/245a8fcc (commit)
via https://github.com/Gnucash/gnucash/commit/c751e561 (commit)
via https://github.com/Gnucash/gnucash/commit/010ab1a9 (commit)
via https://github.com/Gnucash/gnucash/commit/79fdb412 (commit)
via https://github.com/Gnucash/gnucash/commit/e3b5a7d8 (commit)
via https://github.com/Gnucash/gnucash/commit/2dd8d782 (commit)
via https://github.com/Gnucash/gnucash/commit/7cb27b26 (commit)
via https://github.com/Gnucash/gnucash/commit/4a4e5d36 (commit)
via https://github.com/Gnucash/gnucash/commit/d8f83d6e (commit)
via https://github.com/Gnucash/gnucash/commit/3514725a (commit)
via https://github.com/Gnucash/gnucash/commit/e78c0126 (commit)
via https://github.com/Gnucash/gnucash/commit/ae79fd01 (commit)
via https://github.com/Gnucash/gnucash/commit/28438e31 (commit)
via https://github.com/Gnucash/gnucash/commit/41e59df7 (commit)
via https://github.com/Gnucash/gnucash/commit/1eef796f (commit)
via https://github.com/Gnucash/gnucash/commit/99103ffd (commit)
via https://github.com/Gnucash/gnucash/commit/8fe338f3 (commit)
via https://github.com/Gnucash/gnucash/commit/9111f118 (commit)
via https://github.com/Gnucash/gnucash/commit/01c0fe23 (commit)
via https://github.com/Gnucash/gnucash/commit/25b717d4 (commit)
via https://github.com/Gnucash/gnucash/commit/4451f58b (commit)
via https://github.com/Gnucash/gnucash/commit/6feb92d4 (commit)
via https://github.com/Gnucash/gnucash/commit/f9e136db (commit)
via https://github.com/Gnucash/gnucash/commit/eb6e31f8 (commit)
via https://github.com/Gnucash/gnucash/commit/67508ea0 (commit)
via https://github.com/Gnucash/gnucash/commit/3b4785e7 (commit)
via https://github.com/Gnucash/gnucash/commit/c63db36a (commit)
via https://github.com/Gnucash/gnucash/commit/01061764 (commit)
via https://github.com/Gnucash/gnucash/commit/5fd53c94 (commit)
via https://github.com/Gnucash/gnucash/commit/a995343a (commit)
via https://github.com/Gnucash/gnucash/commit/16da3208 (commit)
via https://github.com/Gnucash/gnucash/commit/ac0e7063 (commit)
via https://github.com/Gnucash/gnucash/commit/3200bd49 (commit)
via https://github.com/Gnucash/gnucash/commit/fce33799 (commit)
via https://github.com/Gnucash/gnucash/commit/00aa0f60 (commit)
via https://github.com/Gnucash/gnucash/commit/6c8e0e23 (commit)
via https://github.com/Gnucash/gnucash/commit/3b78b6e8 (commit)
via https://github.com/Gnucash/gnucash/commit/d5f6a253 (commit)
via https://github.com/Gnucash/gnucash/commit/93a3716c (commit)
via https://github.com/Gnucash/gnucash/commit/dc876d40 (commit)
via https://github.com/Gnucash/gnucash/commit/102f36c3 (commit)
via https://github.com/Gnucash/gnucash/commit/6c7f976a (commit)
via https://github.com/Gnucash/gnucash/commit/99c2c5e4 (commit)
via https://github.com/Gnucash/gnucash/commit/1bea809c (commit)
via https://github.com/Gnucash/gnucash/commit/cbf7d70e (commit)
via https://github.com/Gnucash/gnucash/commit/81c5ac66 (commit)
via https://github.com/Gnucash/gnucash/commit/aa246d30 (commit)
via https://github.com/Gnucash/gnucash/commit/20b3ef8a (commit)
via https://github.com/Gnucash/gnucash/commit/cd6ccbe3 (commit)
via https://github.com/Gnucash/gnucash/commit/691cb099 (commit)
via https://github.com/Gnucash/gnucash/commit/cbd0607e (commit)
via https://github.com/Gnucash/gnucash/commit/5a82aac6 (commit)
via https://github.com/Gnucash/gnucash/commit/ffc68664 (commit)
via https://github.com/Gnucash/gnucash/commit/d2535fe2 (commit)
via https://github.com/Gnucash/gnucash/commit/009219c6 (commit)
via https://github.com/Gnucash/gnucash/commit/276641ef (commit)
via https://github.com/Gnucash/gnucash/commit/51a1430c (commit)
via https://github.com/Gnucash/gnucash/commit/76172af2 (commit)
via https://github.com/Gnucash/gnucash/commit/6ab5618b (commit)
via https://github.com/Gnucash/gnucash/commit/d7a2a0ff (commit)
via https://github.com/Gnucash/gnucash/commit/826d75af (commit)
via https://github.com/Gnucash/gnucash/commit/c5294ed6 (commit)
via https://github.com/Gnucash/gnucash/commit/7ccba537 (commit)
via https://github.com/Gnucash/gnucash/commit/1ea38226 (commit)
via https://github.com/Gnucash/gnucash/commit/98ca1907 (commit)
via https://github.com/Gnucash/gnucash/commit/4b997cd0 (commit)
via https://github.com/Gnucash/gnucash/commit/b2fb57d3 (commit)
via https://github.com/Gnucash/gnucash/commit/4dcf4a0e (commit)
via https://github.com/Gnucash/gnucash/commit/4cabd6c0 (commit)
via https://github.com/Gnucash/gnucash/commit/e2a36a8b (commit)
via https://github.com/Gnucash/gnucash/commit/6df516df (commit)
via https://github.com/Gnucash/gnucash/commit/52d0ec52 (commit)
via https://github.com/Gnucash/gnucash/commit/883127a5 (commit)
via https://github.com/Gnucash/gnucash/commit/e583c84f (commit)
via https://github.com/Gnucash/gnucash/commit/aaf6b14c (commit)
via https://github.com/Gnucash/gnucash/commit/1b00399b (commit)
via https://github.com/Gnucash/gnucash/commit/5a9c4cca (commit)
via https://github.com/Gnucash/gnucash/commit/b95ea2c4 (commit)
via https://github.com/Gnucash/gnucash/commit/7183e7c4 (commit)
via https://github.com/Gnucash/gnucash/commit/399573a8 (commit)
via https://github.com/Gnucash/gnucash/commit/12c5b944 (commit)
via https://github.com/Gnucash/gnucash/commit/3f576671 (commit)
via https://github.com/Gnucash/gnucash/commit/2f2ac999 (commit)
via https://github.com/Gnucash/gnucash/commit/252ba9b4 (commit)
via https://github.com/Gnucash/gnucash/commit/ff7b263a (commit)
via https://github.com/Gnucash/gnucash/commit/39b7c9c7 (commit)
via https://github.com/Gnucash/gnucash/commit/3dc4bc23 (commit)
via https://github.com/Gnucash/gnucash/commit/435667e8 (commit)
via https://github.com/Gnucash/gnucash/commit/8eedcb6d (commit)
via https://github.com/Gnucash/gnucash/commit/d544f852 (commit)
via https://github.com/Gnucash/gnucash/commit/694a15ed (commit)
via https://github.com/Gnucash/gnucash/commit/16d1f065 (commit)
via https://github.com/Gnucash/gnucash/commit/cee3cdaf (commit)
via https://github.com/Gnucash/gnucash/commit/9cdcaf0d (commit)
via https://github.com/Gnucash/gnucash/commit/935ce6db (commit)
via https://github.com/Gnucash/gnucash/commit/e51faff3 (commit)
via https://github.com/Gnucash/gnucash/commit/c5fac51a (commit)
via https://github.com/Gnucash/gnucash/commit/3296212a (commit)
via https://github.com/Gnucash/gnucash/commit/0a13b4c5 (commit)
via https://github.com/Gnucash/gnucash/commit/4146251c (commit)
via https://github.com/Gnucash/gnucash/commit/6ccb9dbb (commit)
via https://github.com/Gnucash/gnucash/commit/94628097 (commit)
via https://github.com/Gnucash/gnucash/commit/3769a356 (commit)
via https://github.com/Gnucash/gnucash/commit/6deedd44 (commit)
via https://github.com/Gnucash/gnucash/commit/40361ec8 (commit)
via https://github.com/Gnucash/gnucash/commit/41ef2c5d (commit)
via https://github.com/Gnucash/gnucash/commit/083e5b93 (commit)
via https://github.com/Gnucash/gnucash/commit/cf0b1da4 (commit)
via https://github.com/Gnucash/gnucash/commit/2ee0edaa (commit)
via https://github.com/Gnucash/gnucash/commit/d2655d3f (commit)
via https://github.com/Gnucash/gnucash/commit/ade7fc8b (commit)
via https://github.com/Gnucash/gnucash/commit/f3eee511 (commit)
via https://github.com/Gnucash/gnucash/commit/455d3c2d (commit)
via https://github.com/Gnucash/gnucash/commit/16fd632e (commit)
via https://github.com/Gnucash/gnucash/commit/13b94d23 (commit)
via https://github.com/Gnucash/gnucash/commit/d88ec0dc (commit)
via https://github.com/Gnucash/gnucash/commit/01dc70cc (commit)
via https://github.com/Gnucash/gnucash/commit/01fcae6a (commit)
via https://github.com/Gnucash/gnucash/commit/b6fd8447 (commit)
via https://github.com/Gnucash/gnucash/commit/c0ba3e27 (commit)
via https://github.com/Gnucash/gnucash/commit/b495da4e (commit)
via https://github.com/Gnucash/gnucash/commit/0b77641e (commit)
from https://github.com/Gnucash/gnucash/commit/73ddaa8c (commit)
commit 1fddf70e214a62c3eccece76a02fe5b3d3a0c1d9
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 31 12:27:58 2022 -0700
[C++options] Fix previous month and previous quarter at the end of March
.
Because March has more days than February the previous month offset was
getting normalized back to the current month--th 29 February this
year is really 1 March, so normalizing before setting the day caused
begin/end previous month to return the begin/end of the current month.
That probably happened on the 31st of May, July, October, and December
as well, I just hadn't managed to test on those days. Switching the
normalization to after calculating the day of the month broke the
previous quarter calculation because now the month was out of range, so
normalize month & year first.
commit abd1a0b3f16e47e94236c4e9064e9e5f0fb76ba0
Merge: 73ddaa8c4 4fe83c3b3
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 29 15:58:22 2022 -0700
Merge branch 'c++options'
commit 4fe83c3b32884ab82dcccd24a221246316c817cb
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 21 14:08:06 2022 -0700
[C++options] Remove GncOptionValue<SCM>.
No longer needed.
commit f4bfd9df3e43fb331287a76fd74049bf4989ee11
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Dec 14 12:54:13 2021 +0800
[account-piecharts] don't use gnc:make-internal-option
commit 278aa484d72f2168d9217b43ef0c0e171300432b
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 21 12:46:02 2022 -0700
[C++options] Implement new GncOptionValue type GncOptionReportPlacement.
For multicolumn reports so that we don't have to pass Scheme values.
commit 5457d4a9e38bebd38f5d6e5e5a6e829477b9de46
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 21 12:44:52 2022 -0700
[C++options] Convert account-summary.scm to gnc-register-option.
Just to make sure that it works.
commit 30e6c8ab11be8f7014ddcd5bda82cf9d0ffe409c
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 15 16:16:50 2022 -0700
[gnc-optiondb.i]Explicitly include array.
Xcode-13.3 errors without it.
commit 572cb6b1d1da4aa1a971b16201c4048c5cfdb3a5
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Mar 13 15:51:16 2022 -0700
Banish gnc_get_optiondb_from_dispatcher to gnc-report.cpp.
Puts it closer to its points of use and removes it with its Scheme
dependency from libgnucash.
commit d4c3c30b1a0e27a7d9f97b62b1ef447b104c3cf6
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Mar 12 17:58:23 2022 -0800
Use GUIDs to represent QofInstances instead of pointers.
Converting them to pointers for Scheme to use. Prevents
dangling pointers when the user deletes a QofInstance as long as the
Scheme report code re-fetches its pointers from the options when it's
regenerated.
commit a7a643f7f2f364228d57eda935e9b9d2c8fa2f84
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 3 14:47:18 2022 -0800
Store option commodities and namespace and mnemonic instead of pointer.
Protects against crashes caused by the user deleting the commodity and
allows the option to work if a deleted commodity is recreated.
commit 65bd860249b3fc284558144eb81df413d92b32ca
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Jan 1 16:05:06 2022 -0800
Fix relative_date_to_time64 calculations.
Where the date requested extends beyond the start or end of the year.
commit 6841e5b5c8ac57d204c1bbf73ad232a4e5ed4ad8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 30 12:21:56 2021 -0800
Replace GncOptionValue<const QofInstance*> with GncOptionQofInstanceValue.
That stores its values as a pair of <QofIdType, gncGUID> so that it
won't have dangling ptrs if the instance gets deleted.
commit 11225d974172d93c134d3eb2beb002955a0fa08f
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Dec 15 14:54:41 2021 -0800
c++options: Remove gnc:options-data
commit 16dc15964c0eaa8727b8bd2d0d0940bd8451e97e
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Dec 15 14:32:39 2021 -0800
c++options: Remove the callback registration functions.
commit 759376eb1323f21d908a820d2b81bbc82316a584
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Dec 15 14:13:47 2021 -0800
c++options: Fix multicolumn report
commit 18edc175419534f578d0d365308eabc54a866325
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 14:20:20 2021 -0800
c++options remove stray debugging comment.
commit b5d0c42505a12e341d4c4fa6a7ebf48ddc38bd88
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 12:06:39 2021 -0800
c++options: Put copyright and FSF header comment on gnc-optiondb.i.
commit a700701cd3dcb9f37aa17b85d8cf7f2d0147f87d
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 11:11:51 2021 -0800
c++options: Remove three unused test functions.
Scheme serialization is now tested in test-option-gnc-scheme-output.scm.
commit eb0bd4f998ad4a39fd0c890ee258f98fbf28972e
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 11:18:15 2021 -0800
c++options: Remove unneeded C++20 header and resolve ambiguous call.
commit a3f50586dfaf76c0801bf9ff62561d1492f5d8db
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 11:03:37 2021 -0800
c++options: More thorough testing of scheme serialization.
commit 6cd88c230c1032b6e7427a04ae2220e0e72e7100
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 11:03:01 2021 -0800
c++options: Create bool or string internal options when possible.
There's no need to save internal options as SCM when we support the
underlying type in C++.
commit e9b850cca5a6be742919668886572e9e07744aa7
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 10:58:48 2021 -0800
c++options: Correct Scheme serialization of type bool.
commit 66f9fc81c70d2c767bb9befb548b0a8b5656d34f
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 14 10:57:41 2021 -0800
c++options: Implement serialization for GncOwner.
commit 0ce841d4ce650135b8d9c293e06b1cb667e175e9
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Dec 13 11:06:33 2021 -0800
c++options Fix Scheme bindings for QofQuery options.
commit 216b483e265f05e118fba053451f1380e93fdb9a
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Dec 13 11:05:15 2021 -0800
c++options SCM bindings Rewrite save_scm_value to branch on type.
Instead of GncOptionUIType, mostly. We still need to do that to tell apart
commodities and currencies from other QofInstances.
Allows compile-time dispatch for most types.
commit 947c061989fdc8cefce6802044e88d9d8dce05cf
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 11 15:12:22 2021 -0800
C++options: Create QofQueryValue trait.
commit f26014a04e26278827fa9f67f487bd7936e93eee
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 11 15:11:26 2021 -0800
c++options: QofInstanceValue: Protect against crashes when m_value is nullptr.
commit 24d2999aecfb589639aba8768dc7c1bfe17255f6
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 4 15:29:01 2021 -0800
c++options: Set the dialog entries only once at dialog creation.
commit 51cc2668a11933607a2b502c34c5ba2c590e8242
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 4 14:39:19 2021 -0800
c++options Ensure signals are inactive for initial setting of option entries.
Ensures that the initial setting of the entries doesn't trigger
gnc_option_changed_widget_cb. The entry widget hasn't been parented yet
and besides we don't want to activate the apply and ok buttons yet.
commit 269249378faf679c98d9ab42e52cc82dfb0bc479
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 2 16:05:14 2021 -0800
c++options fix setting account-selection widget from option.
commit 6f93a68bad9bf8840d783e861499a33c13f1b4be
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 2 15:04:49 2021 -0800
c++options: Serialize and deserialize to strings instead of streams.
And use serialize to create values for gnc:generate-restore-forms and both
of them for the meat of the stream functions.
This fixes in particular QofInstance serialization where passing the
option value directly to scheme format resulted in a notation about
a swig pointer instead of the desired GUID string or commodity namespace
and mnemonic strings.
commit c3b8b6cc493ded3360b760b4fa960611da045000
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 21 16:10:28 2021 -0800
Make a proper class of GncOptionsDialog.
Removes the C functions, allocates with new and delete and cleans itself
up.
commit 5e84f118ddfe53452e2f1088ee4d5aea618b0aa6
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 16:10:13 2021 -0800
Move gnc_options_dialog functions from gnc-gnome-utils to dialog-options.
commit 8eddb63ef1f5693253cb94df38cf8986f9290f2f
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 14:39:40 2021 -0800
Remove unused global variables global_help_cb_data and global_help_cb.
commit 19a2dd495272fd58751216c1b84b1645b956e688
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 14:34:55 2021 -0800
dialog-options: Store the main buttons in GNCOptionWin.
Instead of searching for them every time the dialog updates.
commit 9804928006b19552d00a9f1b478fcbd72abb2dda
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 11:58:22 2021 -0800
Don't call gnc_option_db_clean after setting up the options dialog.
The widgets have already been loaded and loading them again just sensitizes
the buttons as if something had changed.
commit e17ee38c8049f64fcbf00faf83b742d99ebaac0a
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 11:56:25 2021 -0800
dialog-options.cpp: Replace hand-rolled loop to find toplevel with gtk_widget_get_toplevel.
commit a3a381cfd0efdbbcf7c8bb1c28d2999502bad84f
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 11:52:44 2021 -0800
dialog-options.cpp: Fix passing bad widget ptr to dialog_changed_internal.
GtkTreeSelection is not a widget.
commit dd7feb99887278982f5dfc898fac44feb770672c
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 11:45:54 2021 -0800
options.scm: Remove second license comment.
commit d1fe359e4722e168fcd3fda0be87538b4e2c7ed1
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 11:44:57 2021 -0800
gnc_numeric_to_decimal: Change can't round warning to a debug.
Routinely used as a check so a warning isn't appropriate.
commit 74fd716afbf0b23d3b4bf4af0f18f935c58a8ea5
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 19 11:43:04 2021 -0800
Clarify gnc_relative_date_to_time64 helper functions.
commit f6c9e63e3d8b130f79c39e6db693541e9fc01ba0
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 14 15:28:22 2021 -0800
Fix PR comments so far.
Except for gnc-option-date's normalize_tm and set_day_and_time.
commit 4c43dac1b6b2d2e7840cc4d286c7637bc4c90042
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Nov 13 11:10:17 2021 -0800
Restore setting swig engine initialization flag.
commit cf5da9fffdaf6d4ec703ab46febae8829e36c972
Merge: 984d816a5 96b09ded9
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 12 16:09:00 2021 -0800
Resolve merge conflicts.
commit 96b09ded9fedb0a97bab468124e1aeafdda93b43
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Nov 10 18:01:55 2021 -0800
Doxygen documentation for new options classes.
commit 00a982d97d6a628d2750611fe8a5b533cb682535
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 30 13:46:10 2021 -0700
Use Scheme to generate and parse saved option files.
The saved option files being Scheme executables.
commit 00c2e99d2ee866f21f4c78d7b01cd65711723ef9
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 30 13:14:19 2021 -0700
Convert the Scheme RelativeDatePeriod lookup table to a std::vector.
From a Scheme alist. The vector can be used to find the scheme symbol
as a direct lookup, which isn't possible with an alist, and can be
searched for the Scheme symbol match more quickly than an alist can.
commit bed44f404f0c30ca6a36f9863250134dfb9e6612
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Aug 28 16:52:36 2021 -0700
Remove the always questionable Scheme generation and parsing code.
It's more reasonable to do that in Scheme than in C++.
commit a487ca3f9822cc8e65f0d28e2c267b64a2a2c697
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 25 12:16:15 2021 -0700
Improve template conditional readability with custom traits values.
commit 3935f1a91b53fd8d4013b44d14704882609effdc
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 19 11:13:29 2021 -0700
Don't put labels on checkboxes, they have their own.
commit 62ab148a3e3b7be1852a940e6209b9cdbfecdd1a
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 19 09:48:44 2021 -0700
Output a pair when writing relative date values to scheme file.
So that the can be properly recognized on input.
commit b3f96701a0603a0a84bc425f6e81c1f2363a6219
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 18 16:14:21 2021 -0700
GncOptionAccountListValue: Make setter param cv match template.
commit 7392ac6fcf853299d9c16fbf2c89dd337b0bbd44
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 18 15:51:19 2021 -0700
Prevent running off the end of the GncOptionUI widget's parent tree.
commit b361582cf22f13c34758befe848468569cfa98b1
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 18 14:37:20 2021 -0700
Ensure option UI is sorted: Tabs by names, items by keys.
commit 10381d42e078658d685ac3ccdf994fe9f1bc2650
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 18 13:38:06 2021 -0700
Fix color option handling.
Read and write color options the way legacy code does. Pass only values
with no alpha to gdk_rgba_parse because it fails if a hex-string has
alpha.
commit 97a317b50cafbb507bdf53206e748aae277befb1
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 17 15:47:11 2021 -0700
Ensure that alpha values in colors aren't passed to html.
html color tags don't like them.
commit 3d1812aacd340193480542f2946461b27d4c18d3
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 17 15:41:26 2021 -0700
Explicitly cast a value to the decltype of get_value().
Can't always rely on implicit conversion working.
commit bbe8ebbc15eb64b92a1f0e1d526270e136f801f0
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 17 15:38:07 2021 -0700
Reserve space for the accounts in their vector.
Instead of creating an empty vector and then adding the accounts to the
end of it.
commit 42b4755aea92134211c3c1ea09c59aac651779c0
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 17 15:36:51 2021 -0700
Set the initial value on Relative Date combo boxes.
commit c06924622ced87b4abfb38fb6f21f7e013db2f54
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 17 15:34:45 2021 -0700
Null-value protection for GUID and account values.
commit 53fac914c01f354475c36996d33e3a6245c476fd
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 17 15:30:44 2021 -0700
Re-enable connecting the buttons on the Stylesheet Edit select dialog.
commit e77b5ec03bb375765427c57da2b6ab23eb4b1aef
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 15 14:27:59 2021 -0700
Fix RelativeDateValue GtkListModel spec: No tooltips anymore.
commit 474bc360f4cb731099bdb1dab837579c43813280
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 15 14:25:52 2021 -0700
Improve converting vectors to SCM lists.
commit 1cd2cf211c4e1d46c81d9c119d4d52d12aad4445
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Aug 13 14:05:49 2021 -0700
Specialize QofInstance* options set_value, catch validation exceptions.
GncOptionValue<const QofInstance*>.get_value() returns a QofInstance* but
reports store them as strings, either commodity mnemonics or GUIDs.
Specialize set_value/set_default_value from scheme to handle those
possibilities.
GncOptionValidatedValue throws an invalid_argument exception if it's
fed an invalid argument. Catch that so that it doesn't crash the program.
commit 852b2ffc2effe61d13585141cd62505eb1770fdd
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Aug 13 14:01:27 2021 -0700
Handle bare currency mnemonics, catch invalid GUID string exceptions.
commit e43ff93279be4d9ea2cf2d73bf89d6b1dcf0ca05
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 12 14:30:13 2021 -0700
Fix some overly-long lines.
commit 1af97ebb9ad43ce39402108ab8adc1b2f3fe6f33
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 12 14:29:56 2021 -0700
Implement registering/unregistering/calling change callbacks.
Drives reloading the report when the Apply or OK button is pressed.
commit 86da12d844a4749a0334cf129ded53140b5cc351
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 12 14:28:44 2021 -0700
Use RGB instead of RGBA for color set for color
commit a7f0476af91688d381fa43afd6f1a70ceb5cad53
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 8 15:25:09 2021 -0700
GncMultichoiceUIItem: Cast the selection index to a size_t.
To get correct match with template type.
commit e8f855e6043f674c5d28a35a41ae672d825410d9
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 8 15:24:08 2021 -0700
Oops, bailed on failure when finding the dialog box buttons.
commit 86d7637160b4ec77f568ebc34da40b3866957ae9
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 8 15:22:53 2021 -0700
Handle GncOptionMultichoiceValue::set_value parameters
that don't match the get_value return type.
commit 8acf52a69beaf5dfa7a4560831b2fae46a4294c9
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 5 18:22:37 2021 -0700
Clean up variable declarations in create_list_widget.
commit e4c9900c9e7f0c6328b13feae80112f55bbee7be
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 5 18:21:53 2021 -0700
Avoid infinite recursion in toggle buttons.
Calling activate on a toggle button toggles it again. No need for that.
commit 3c95ad8a0015f3605ac7516b140322378c9fdb87
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 5 18:20:19 2021 -0700
Create and use renderer for multichoice option widgets.
commit 8079470c8aeed8601522a3336055aaec2760ae37
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 5 17:26:04 2021 -0700
Fix Color chooser option value setting and getting.
commit c83a3f44dd0774a28c6e1bb22e809f7dce33c391
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 5 15:41:50 2021 -0700
Fix paste error. Call get, not set, when we want to get.
commit f0ecc0e2ebd33f7286d22adf1b12c77f45fba771
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 5 15:41:03 2021 -0700
std::string(char*) crashes if it's given a nullptr.
commit b6622a386b8a3c6aa0b7dd42b296784202691922
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 4 17:13:23 2021 -0700
Pick up option aliases recently added in maint.
commit 26946d792c63aca947e77a9c01dccb3a84be302a
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 4 12:05:32 2021 -0700
Configure the book options before trying to load them.
commit 914f5f359bcc486c40dd941f5f17908ed794dfa7
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Aug 4 12:05:02 2021 -0700
Don't unref option UI elements.
They're wrapped in unique_ptr and will take care of themselves.
commit 71955cc326fda6897af12e3093df0417d0598ed2
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 3 17:06:22 2021 -0700
Correctly terminate gtk_list_store_set().
commit a97b3e0c6d21cd146d60326a6c59cc8143a804c5
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 3 17:05:04 2021 -0700
Don't let C code destroy the ODB, it's owned by Guile.
commit 58d090ff326aebe685dfaf4b726601a8d30f70b3
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 3 17:03:49 2021 -0700
Protect strncmp from empty string. It crashes if given one.
commit a2e1a3e1b8641968709ee2d82990152c8022990c
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 2 16:52:34 2021 -0700
Extract the GncOptionDB* from the Scheme dispatch function closure.
Scheme code keeps the GncOptionDB in a closure. Extract it for C/C++
use. Ownership remains with the closure, don't free the GncOptionDB*.
commit 99eaa81a280e195a465290d6b9098db13b22a102
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 1 12:43:14 2021 -0700
Fix parse of commodity namespace from scheme istream.
Just ignore 2 instead of ignoring 1 twice. No ifdef required.
commit 0bd9033bb3081ad94f80c507d455cf4ed04b54d8
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 1 11:11:20 2021 -0700
Move includes of glib and gtk out or extern C in new cpp files.
commit 0f02236ebe751f32609b64b1a67fdad1ab4aa5e5
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Aug 1 10:27:50 2021 -0700
Fix gcc warnings.
commit 18997db7202972be99d7d19ae7b367355219ef8e
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Jul 31 17:43:48 2021 -0700
Separate GncOptionAccountValue into GncOptionAccountListValue and GncOptionAccountSelValue.
They have different get_value() return types so can't cohabit comfortably.
commit dd8e8b4efaa04dfa7f6c085f568116686cba4ff6
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Jul 30 13:20:48 2021 -0700
Evaluate the getter for making invoice options.
commit 05ac05644976aa8ada12961d93ed8874da39fbe2
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Jul 30 13:19:17 2021 -0700
Make separate option type for GncOwner.
GncOwner is not a QofInstance subclass.
commit 9d150b1ae70d2ad51f22054b7a681a4d67adc3e1
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jul 19 11:30:13 2021 -0700
Always set budget option to default budget.
commit f5d8d508eec31bf1fe900a967551d36edd383953
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jul 19 10:42:24 2021 -0700
Create the GncOptionVariant's GncOptionValue in place.
Saves a temporary, prevents premature unprotecting of Scheme objects.
commit c034a26ae75f25e9fc78e764a250da6d5c5c69e4
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jul 19 10:40:48 2021 -0700
Protect stored scheme option values from the garbage collector.
commit 67dab6b320f8c93665b97bda9f9d00c5002c26bc
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Jul 18 14:13:29 2021 -0700
Remove business-options.scm and business-prefs.scm.
Their functions have been reimplemented elsewhere.
commit a1af86ed403d97c8f932c94c37537a43bcf87fb0
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 13 12:44:13 2021 -0700
Implement gnc:generate-restore-forms, gnc-optiondb-save-to-scheme.
commit c34986dad4dd2d07db1545585291bdb28ab331c4
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 13 12:43:27 2021 -0700
Change gnc:new-options to return a fake dispatch function.
To placate test-report.scm
commit 3f89d063ebbac5d4dbc51feed65ebdce7de52c04
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 13 09:49:27 2021 -0700
Evaluate default function in gnc:make-account-sel-limited-option.
commit 6eb5dfed513e323d5781dba4039af364104fdcc1
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 13 09:47:58 2021 -0700
make-internal fail if there is a ui_item, not if there isn't.
commit 29a2365fdf17161f05c5cb2012b8f9ef450e6e06
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 13 09:46:48 2021 -0700
Avoid infinite recursion when the alias changes only the section name.
commit 7885353fe31665013f23294d2a7fd1079d47a9c5
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 13 09:46:07 2021 -0700
Bring option aliases up to date.
commit bbe74aa0864aa1ef896372f410a04a96c8f73d6f
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jul 12 13:34:43 2021 -0700
Remove tooltips from multichoice option values.
This is the c++options equivalent to 02a6a0ae and e1525721.
commit 5a2ba091a3ef5f2f88ca20470232a0f1bba915bf
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jul 12 13:09:25 2021 -0700
Fix compilation error from latest rebase.
commit 7c6ecafd610ebe263131e538f7eabc06eacffdbd
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Jul 11 15:03:13 2021 -0700
Rewrite options.scm to wrap options.hpp functions where needed.
commit ce5fe577bf1b13ad55779109d0766b5de496fd86
Author: John Ralls <jralls at ceridwen.us>
Date: Sat May 15 10:22:02 2021 -0700
Fix failure to pass accounts list to gnc:make-account-list-option
The Scheme way of generating options is somehow able to obtain the
account-list even when running the generator before creating the account
tree. The C++ options object doesn't have that ability so one must make
sure to run the account creation first in a let* statement.
commit 52ef53a40523587d8621ed18c5c8175a42a61a98
Author: John Ralls <jralls at ceridwen.us>
Date: Mon May 3 09:46:57 2021 -0700
Implement multichoice selection options.
commit 7239eb809ac4b807aebd05020f9b317e4a5c341b
Author: John Ralls <jralls at ceridwen.us>
Date: Mon May 3 09:39:19 2021 -0700
Test more natural way of designating relative dates.
commit 23461f1d6c1ee029b751e893956be87abf5dc8d8
Author: John Ralls <jralls at ceridwen.us>
Date: Mon May 3 09:38:43 2021 -0700
The value of a list-option is a list. Duh.
commit 12f8df1eab092bf6326e25a69497562f2eb087bc
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Apr 27 16:08:36 2021 -0700
Fix test failure: Clear the stream before reusing it.
commit be322a0d7cf863696e7c355517972f056bdc5ce1
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 18:15:57 2021 -0800
Group GncOptionMultChoiceValue::set_multiple with set_default_multiple.
Better readability.
commit 27670a6e98865d2b8cb6c0702b8130f6a463af06
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 18:13:35 2021 -0800
Make the 'pixel and 'percent SCM symbols C++ constants.
Improves efficiency and conciseness.
commit a94f69d6e04329e92d94e844d4ca06e9c74d70fc
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 18:06:31 2021 -0800
Pretty up some SFINAE formatting for easier reading.
commit 0f8446a1bb550c6ae62d61576d168b7c08df7d99
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 18:04:12 2021 -0800
Remove some no longer needed diagnostics.
commit f66a918be463bc36a3ecd6c5c8d28eac05837df8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 18:03:36 2021 -0800
Implement GncOptionValue<const QofQuery*>
QofQuery isn't a QofInstance and doesn't have a GUID.
commit 0a8f66ee9048bdffb75840f76ec3928e394e50af
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 17:56:53 2021 -0800
Fold GncOptionGncOwnerValue into GncOptionValue<const QofQuery*>.
Reflecting the way Scheme options handles it.
commit 418eb066206c26c37f4d7d7af63b8d6f8cde7faf
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 11 17:50:57 2021 -0800
Remove GncOptionDateValue::set_default_value(size_t)
Because it's ambiguous with set_default_value(time64).
commit 7d0cdf7c94099aac372409c86d26ec004d0e7f01
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 8 11:16:35 2021 -0800
Handle #f input to option typemap(in)s.
commit 86a2f1551fc5910096f9c21e87711598abee876f
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 8 11:14:01 2021 -0800
Implement gnc-make-date-option.
commit 693e966bf958b540017e6cc0c1e6c20d3c10f5fd
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 8 11:13:26 2021 -0800
Extract Scheme date handling functions and apply them.
Including in RelativeDatePeriodVec typemap, making it work correctly.
commit 63502900f3dc9992a38bbd140a3e1a4830aa32cd
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Mar 5 16:15:12 2021 -0800
Permit GncOptionAccountValue to have a nil default value.
commit 42185c0ec8dc926912a440ced0fae83755d97086
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Mar 5 16:13:09 2021 -0800
typemap for std::size_t
Unaccountably missing from swig_guile.
commit 5c743378107ea6f34d2920f025efc07e0be60d51
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Mar 5 15:56:34 2021 -0800
Add function GncOption::set_default_value.
Allows reports to derive from other reports and then change the option
default values to suit. If they change only the values and not the defaults
then it's possible to create saved report configs that don't include the
options whose values are changed to the base report's default value. See
https://bugs.gnucash.org/show_bug.cgi?id=642292.
commit c04f4a00e0d34d66ed5409fd9e3875e40c13d3c4
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 2 14:24:15 2021 -0800
Replace gnc_make_option<SCM> with gnc_make_scm_option
To finesse SWIG_Guile's typedef unsigned long SCM, which causes SFINAE
issues when trying to resolve the template.
commit e7309f077bb47768071088a57580164b158c6721
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 2 14:20:12 2021 -0800
Replace gnc_make_option<gnc_commodity*> with gnc_make_commodity_option.
To handle cases where we try to create commodity options with a symbol as
the default instead of a gnc_commodity*.
commit 3aa86ca9925b85ea9316a54c6e2e64e35c4f0708
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 2 14:15:43 2021 -0800
QofInstance* needs a typemap to match the from/to SCM logic.
commit 4a305998e4cb41b19de80df4c0d424715be4e5f3
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 2 14:14:06 2021 -0800
GncOptionDateValue set_value_from_scm: 'else' required.
commit d9984f75ab8a91ef23ee85af099ca0901c9c2553
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 25 10:42:58 2021 -0800
Update test-gnc-optiondb.scm for not renaming the RelativeDatePeriod enums.
commit 43cd81ba78b235c7cc333e0c987f962f60085949
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 25 10:41:44 2021 -0800
Fix a couple of RangeValue retrieval issues.
commit 9bd3baff63d41186aff4f3341f6373098d19e1fd
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 25 10:40:18 2021 -0800
Change the reldate_values alist from a static to a singleton.
A static has to be initialized at library load and Guile
isn't necessarily running then. The singleton gets evaluated at
runtime only if the getter is called from Guile.
commit 534a7c28937de165a2c287df86e3778b4f7a3a24
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 25 10:34:43 2021 -0800
GncOptionMultichoiceValue allow setting a default selection.
Instead of arbitrarily using the first allowed value.
Also update tests for the Scheme type addition to
GncMultichoiceOptionChoices, intercept more cases where the value
needs to be transformed, and go back to emitting a string instead of
throwing in GncOptionMultichoiceValue::get_value when m_values has more
than one value.
commit c62b526ba0cc29974f5eaee4a1c45975939020f4
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Feb 23 10:36:58 2021 -0800
Implement scm_to_value<bool>.
commit efc734649015917fd8628dd3d49a7a57ad844689
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Feb 22 14:08:14 2021 -0800
Implement scm_to_value<GncOptionAccountList>.
commit f20c358ce1856f7e8c51bdebff8aaf80ded6e90a
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Feb 21 14:30:30 2021 -0800
Return a pair in scheme for GncOptionRangeValue<int>.
This is a bit of a hack to handle PlotSize options. They're the only
RangeValues that use ints; the rest use doubles because the control is a
GtkSpinButton and that uses doubles. The chart code expects a pair with
either 'pixel or 'percent saying what to put in front of the number. We
hack that too: if value <= 100 then it's percent because 100px is about
3cm on modern monitors and 15mm on HiDPI ones. Bigger numbers are pixels.
commit b5c0477143850f0aae7ff393c2da0f22909aa979
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Feb 21 14:25:20 2021 -0800
Use the SWIGGED pointer for the SCM value of QofInstance* Values.
This effectively reverts b7dd7f.
Note that two cases aren't handled because the types aren't GObjects and
so don't have type macros to decipher them: GncOwner and QofQuery. Since
they're not GObjects they're obviously not QofInstances either and we
need to rethink this value type a bit.
commit f7f2d22909c8a205018d07dcc944db242bcffd80
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Feb 20 11:42:42 2021 -0800
Implement gnc-optiondb-foreach.
commit 81d261897e9f48227e9b06e672a12c9036eea30a
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Feb 19 16:13:59 2021 -0800
scm_to_value<QofInstance*>() handle Swigged ptrs as well as GUIDs.
Some swigged engine functions used to set options return Swigged ptrs.
commit 16a36d91044b00ef653073bdb7ed193a992b3de3
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Feb 19 13:50:13 2021 -0800
Correctly set value of a GncOptionMultichoiceValue.
Accounting for the 3 types of SCM object that we might be handed.
commit 7c1b4b794a74f018417b0eed4bd043eaf45fcb55
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Feb 19 13:18:39 2021 -0800
Convert from Scheme date-period symbols to C++ RelativeDatePeriod enum.
Create an alist mapping the Scheme symbols to the corresponding Swig
functions that alias the enumerations. When a symbol is received look
up the corresponding function and evaluate it, retrieving the enumeration.
commit d41292fdddc91ca2e754f838179dd56ca22c2132
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:13:09 2021 -0800
Make set_selectable a GncOptionsGtkUIItem member function.
Callable from the option object with set_ui_item_selectable and from
Scheme as gnc-option-db-set-option-selectable-by-name.
commit a21f329b1e3b45273b0f85a12ade98a3ee04655c
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:38:10 2021 -0800
Use 100% instead of 20000 px for default Pixmap size.
commit 8c2a8edbed5f68987d77cb96a403ce44e57740a8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:36:52 2021 -0800
Implement gnc_option_db_set_string_value and gnc_optiondb_lookup_string_value.
commit 86102e1be7b1b4742c2acc194190af72dad43931
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:32:09 2021 -0800
Return SCM_BOOL_F instead of nullptr to Scheme optiondb-lookup.
Because unlike C, Scheme thinks (if 0) should return true. Besides, Swig
hides pointers so a null check doesn't even work.
commit 53ad0ba440e6bd088f05916db257539bb4343813
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:28:17 2021 -0800
Prevent SWIG from trying to call delete on a std::unique_ptr.
commit 08d1eebba251d123f68a02fa2a5ab7b1208e836d
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:27:37 2021 -0800
Use GUID strings instead of QofInstance* for scheme value of QofInstance.
Because that's what gets used everywhere else.
commit fba024854821ab5ee7dbd2ddb3c3137fd8bf3cc5
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 18 17:10:16 2021 -0800
Support different GncOptionMultichoiceValue key types.
Scheme can use strings, symbols, or ints as keys in multichoice options,
but C++ can handle only strings. Add conversion and tracking so that the
right key type gets sent back to Scheme.
commit 55a2ed1df8e2a2a170f754555723c9cf1ebaf2bd
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Feb 15 16:08:46 2021 -0800
gnc-optiondb.i uses functions declared in gnc-optiondb.h.
So it needs it declared in the swig file.
commit 18b83874fdb08cd691a02de814e17a775f8ca570
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Feb 15 15:49:03 2021 -0800
Another bit of Remove test-option-utils
commit 0b7ccfbd5bc6ceaea40ec026ffa074f496fe4eb9
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 4 17:21:31 2021 -0800
Create gnc-make-foo-option functions.
For compatibility with current Scheme code.
commit a602f64b170290d05febe8d5e8ae89b8e6f45b2f
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 4 17:19:02 2021 -0800
SFINAE-constrain the GncOption constructor templates.
So that one can't instantiate an invalid constructor.
Unfortunately Swig doesn't understand SFINAE and will try to create the
invalid constructors anyway but at least this generates a compile-time
error when it tries to.
commit 43f4bcb610ca24830b7b87b38800c458153a78fe
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 4 17:13:53 2021 -0800
Make GncOptionUIType an enum class.
So that Swig will create properly constrained identifiers for its values.
commit 7fa6778b4b71bca4129d60c98b1746ba0bcddae7
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 4 17:08:03 2021 -0800
Add a register_option overload to GncOptionDB
For compatibility with existing scheme code.
commit cb7270cafe53189b6d88374658ae097f4adcad24
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 22 16:24:15 2020 -0800
Fix myriad gcc10 complaints.
commit 76b0001cbe6547136f40a1bea8712baf0c7f26c5
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Dec 18 16:02:11 2020 -0800
Remove option-util.
commit e2c87f23c3c8d0760f886fb6c89fa621820ff4aa
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 8 16:45:15 2020 -0700
Convert optiondb users in gnome and gnome-utils to C++.
To enable using std::unique_ptr<GncObjectDB> and avoid memory management
problems.
commit ea835b31b791c1348a20f8bc255f6faceda511e8
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 6 10:14:10 2020 -0700
Provide GncOptionPtr& overloads for register-option functions.
Simplifies and makes safer calls from Scheme and C++ by not requiring
a raw pointer.
commit 472814d315cb424f488a9c7da208272501294fa3
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Oct 9 14:08:18 2020 -0700
Change the normal internal option ValueType to SCM.
Internal options are used as a Scheme hack and don't need to be interpreted
on the C side so there's no point in converting them to C types.
commit 023db2335349a8d5f15843f199d6cdfd9a769f03
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 8 17:43:07 2020 -0700
Make URLType an alias for const char* instead of char*.
Because it uses macros declared as string constants as values and C++
objects if one tries to initialize a non-const char* with a string constant.
On the other hand one doesn't want to strdup into a const char* because
then you can't free it, so all of the instances where it's strduped for
inserting into a container must be changed from URLType to char*.
commit ae73b3855d27c769fd8055194452e75f81adf545
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 8 17:37:56 2020 -0700
Cast const char* args from guile to char*.
Swig's guile typemaps lack a const char* freearg typemap. When a function
argument is explicitly const char* Swig automatically discards the const
in the temporary's decl so freeing it isn't a problem, but if the function
arg is declared as something typedeffed to const char* the alias is used
in the temporary's decl causing an error about discarding the const
qualifier when it's time to free the temporary. Providing a const char*
freearg typemap works around the shortcoming.
commit e48416010dfd4fb47d9142e09f1f1f61f5fb1c68
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 8 16:51:49 2020 -0700
Remove redundant GncOptionDB decl.
commit 7022f5222d6250b54ac7ef7e682a02c1de7b175f
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 8 16:50:41 2020 -0700
Revert gnc_option_db_lookup|set_glist_value to ...scm_value.
GLists and SCM lists are not interchangeable.
commit 776d1aaa0ed8b711490edf18590a1ed59ea4d256
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 8 16:48:00 2020 -0700
GNC_DEFINE_TYPE_WITH_CODE: Don't use class as a symbol name.
It conflicts with the C++ keyword. Even GObject code knows better.
commit 8c77ce967b500aeaaa02db7209b0c513c1cbc6d0
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 6 10:09:27 2020 -0700
Implement and test obsolete option name aliasing.
commit 90b8fce59fe02a0e0ccac05a2baaadf7317e07a0
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 6 13:15:51 2020 -0700
Fix build after merge.
commit 60c1d16e64d2ea327234dc91ab3bd6d232f2aa33
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 6 13:15:36 2020 -0700
Add/rename files in POTFILES.
commit 4f3fd665cfc1f7552f3b06b9de7bec5e86b3e4e8
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 12:20:12 2020 -0700
Fix counter and counter_format storage in KVP.
So that they go to their own slots instead of to the options slot.
commit b19f3d383c9ad869f9ea6a76fb93f3880beffbde
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 12:20:06 2020 -0700
Protect some exceptions from being passed to Swig.
commit 52600bbd1f9a8a2c0bc04edca605572c8ccbd50b
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 12:11:16 2020 -0700
Instantiate gnc_register_number_range_option templates in SWIG.
commit 31a0153fec66fcacc4348ba0f75efd488a37369b
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 12:08:54 2020 -0700
Another GncOptionDBPtr fix.
commit 85db341afe0211b9be71a2ba678a106048cbd18f
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 12:05:19 2020 -0700
Remove test-option-utils
It no longer works. Since that's all that test-app-utils called,
delete it too.
commit 21398dfda1462591522be96b387a581db492bbd0
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 11:44:11 2020 -0700
Testing fixups for using GncOptionDB* in register_option functions.
commit 7dab089d49b3b6e5aa43b866d0733a7e4de576b5
Author: John Ralls <jralls at ceridwen.us>
Date: Wed Apr 8 09:53:12 2020 -0700
Fix miscalculation of prev_quarter_end for the first quarter.
If the current quarter ends June 30 backing up 3 months from there
gets March 30, one day off. Back up first and calculate the end
of the actual quarter of interest.
Changed pre_quarter_start for consistency, it doesn't matter.
commit d1cfd62f3177abf681724ff6010042d2791fe28c
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 10:44:37 2020 -0700
Fix loading text fields from KVP into options.
commit 1f0bfe0cfa22cc7572ccac3e4b858ff3424b6c1b
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 10:39:48 2020 -0700
Log an error if we try to create an option for an unregistered UI type.
commit c6fce31795344a42a63967e68b4e2f7c980f09c1
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 10:38:24 2020 -0700
Set the component_class on the GNCOptionWin, silencing component-manager error.
commit 507f35cc303e0bc6453d50d5a61d8e7e038c30de
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 10:37:33 2020 -0700
Fix wrong callback for TEXT control.
commit 8440b9c99c9ced5e5e8cdd993cd996b723c1799a
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 10:02:20 2020 -0700
Test QofInstance from option before trying to use it.
Avoids GObject type error noise.
commit 2ccfe0c1910befd269c1001afd7ea38551b29eec
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 09:09:08 2020 -0700
Finish implementing the TaxTable option GUI.
commit 276d33975abed7c76066e36c6f48cb387314d4df
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Apr 5 09:07:34 2020 -0700
Remove dialog-options.c, replaced by dialog-options.cpp.
Adds new function reset_default_value to GncOption; doing it outside
of the class requires knowing the Type of m_value.
commit 5f9c66aa616a33cb0f6e6d31df3d952522672a8b
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 17:57:07 2020 -0700
Save all options to KVP if clear_options is true.
commit 6491c98563152043228891e24dc6d70cafc36695
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 17:49:34 2020 -0700
Clean up some omitted type-forcing in set_option_from_ui_type() instances.
commit 245a8fccc7886550b22cb6bfb95b9e63681b53a1
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 17:47:26 2020 -0700
Correctly select UI types for GUID output.
commit c751e561847409444b25f819edd8b6292fb2e68c
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 17:27:15 2020 -0700
Fix fail to load or save number-range values in KVP.
commit 010ab1a965a87c25550f7b32207558d533ca9db7
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 17:25:46 2020 -0700
Fix free of unallocated ptr crash.
commit 79fdb4124e6810cc4cba90f48acf376991b0f91c
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:50:17 2020 -0700
Fix some errant UI Types and a mis-formatted function.
commit e3b5a7d833f2a470e47225b9c8201336e0c71f62
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:48:41 2020 -0700
Fix boolean controls so that the set visitor recognizes the value.
commit 2dd8d782e5f692e8096bfc29022d8fb888197b85
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:46:47 2020 -0700
Don't crash if the option set doesn't set a default section.
commit 7cb27b26362aebfcdd842ec4deeb41fc75a2ad6a
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:45:34 2020 -0700
Make changes to controls enable the Apply & OK buttons.
commit 4a4e5d36f8f837bdf3e44e5586fec81aaead100a
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:44:38 2020 -0700
Enable gnc_register_owner_option to handle the three types that GncOwner aliases.
commit d8f83d6ee6634bd5e843a1e9e6cc066976f30732
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:42:59 2020 -0700
Boolean simple won't work if its UI type is INTERNAL.
commit 3514725a97f0737b63a84701d40d8f9c5e9e7135
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:34:45 2020 -0700
Make gnc_register_number_range_option a template on ValueType.
GtkSpinButton works with doubles, but we want to preserve the
ability to use other types.
It really should have enable_if<is_arithmetic(ValueType)>.
commit e78c01269949feeefea911663a3fa98cf29cfb5d
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:33:06 2020 -0700
Fill in the book options.
commit ae79fd016df7ee1902c6b8015a382e31b7ce802a
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:32:16 2020 -0700
More skeletons
commit 28438e312632aa7b490b33d59da1ddbb14718ac6
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:26:49 2020 -0700
Rewire gnome and gnome-utils to use GncOptionDB.
commit 41e59df71fb74ec157b7cc3af767f17cf1a4e7bb
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:24:43 2020 -0700
Remove unused and un-needed function.
commit 1eef796f098bd20c143040e55ee5b0332181d192
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:23:55 2020 -0700
Add some skeleton functions to make the option-using code in gnucash/gnome-utils and gnucash/gnome happy.
commit 99103ffd104618b40018a7725d7b7c22d66325ef
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 14:16:22 2020 -0700
Change gnc-register-option functions to take GncOptionDB*.
Instead of std::unique_ptr<GncOptionDB> because there's no way
to get a unique_ptr through a C call.
commit 8fe338f315253cf4c82ed5d1553e7628e97604d4
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 13:48:20 2020 -0700
Temporarily disable building dialog-report-column-view.
It will require some major surgery to get working, and disabling
it allows building GnuCash so that the Book Properties dialog
can be runtime-tested.
commit 9111f118e098211a59f1a379d230c557b8e0cc26
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 13:31:34 2020 -0700
Business option create_option_widget specializations.
Required creating a registration class for create_option_widget
overload functions because without it the dispatch function
complained of missing symbols at link time.
commit 01c0fe2364bd620268c25785deab29330930271f
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Apr 4 13:10:19 2020 -0700
Include what we use.
commit 25b717d47a59e10e7930e36832426e75b0f4cbd8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 26 17:43:52 2020 -0700
Add a rudimentary C API for GncOptionDB.
So that most of the gnome-util and gnome consumers don't need to
be converted to C++.
Hide the corresponding functions in options-utils to stop the
compiler whining.
Note that this commit breaks the build but is necessary at
least temporarily to compartmentalize the changes.
commit 4451f58bd6e8c2f6fb7556164d004b1a4b999ecf
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 26 17:09:51 2020 -0700
Rename RelativeDatePeriods missed earlier.
commit 6feb92d4e8f88b03408787e4f5b2a43fd9003ed8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 26 16:56:07 2020 -0700
Provide scheme function new-gnc-optiondb.
Wraps creating a GncOptionDBPtr, freeing up gnc_option_db_new() to
return a GncOptionDB* for use in C code. Convert gnc_option_db_new()
calls in gtest-gnc-optiondb to call std::make_unique() as well.
commit f9e136dbace3c44eeb444c9b574734008ac4295c
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 26 16:09:02 2020 -0700
Get the spelling of GncMultichoiceOptionEntry consistent.
commit eb6e31f8036614e87e998e2483f0c90ac8c3d5b8
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 24 11:06:57 2020 -0700
dialog-options: Change signature of gnc_option_get_gtk_widget()
So that it can be called from C.
commit 67508ea039d3cffd4403c2c0857729bed229f44d
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 15 10:26:26 2020 -0800
Reimplement dialog-options for C++.
commit 3b4785e744a88ab062c6b13b3accd0cc766d9488
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 17 12:24:20 2020 -0700
Convert GncOptionSection from a std::pair to a class.
Provides find_option(const char*) and foreach_option(func) for easy
iteration. find_option and find_section now return plain const ptrs
instead of std::optionals. Much less cumbersome though the compiler
won't nag if you forget the nullptr check.
commit c63db36a60bb30db6636bc42b07f5c769690f6d6
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 17 12:19:26 2020 -0700
Rename string_equal_charptr to operator==(const std::string&, const char*)
Much prettier and more idiomatic as well as being a lot less typing.
commit 0106176436569bcf46d51b90cf4ad6b9fcd45096
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Mar 16 10:27:59 2020 -0700
Provide GncOption::is_alternate() for GncOptionRangeValue<>.
Needed for GncOptionUIType::PLOT_SIZE to indicate whether the option
value represents pixels or percent.
commit 5fd53c94defb6d08bdf5069a2e561006d7e313a5
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Mar 15 13:39:34 2020 -0700
Provide GncOption::GetLimits for setting a NUMBER_RANGE spin button.
commit a995343a8b9b65d1e517225572c2756018764ee3
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 12 17:30:52 2020 -0700
Provide for multiple selections in GncOptionMultichoiceValue
To support the GncOptionUIType::LIST. This UI type is unused in GnuCash
code but might be used in user custom reports.
commit 16da3208fcfa2d393d9f92e6d9c1f08e64c102bd
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 12 17:29:12 2020 -0700
Make GncOptionDateValue::get_period_index return value size_t.
Instead of int8_t to match the built-in vector index type.
commit ac0e7063c79bbc86ab01dbf57d955db131b74deb
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 10 14:49:49 2020 -0700
Move the GncOptionUIType and dirty members to GncOptionUIUtem.
Even though it makes the class not pure virtual any more it is necessary
behavior common to all possible subclasses.
commit 3200bd4966ce5f8a3a8d78f36f5834178b1288b5
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Mar 10 14:48:06 2020 -0700
Add a multiselect boolean member to GncOptionAccountValue.
To support a variation available in dialog-options. Even though it's not
used in any GnuCash code nor documented anywhere it might be in some
custom reports.
commit fce33799afcf2d1bb1633d77e8513dc757ce9e1b
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 5 20:00:48 2020 -0800
Change GncOptionUIItem to be a pure virtual class instead of a templated one.
Simplifies the design because derived classes can have whatever save UI class
they need and implement the void(void) set_ui_item_from option and
set_option_from_ui_item with whatever functions are appropriate for
the UI class. No need for callbacks or std::function members.
commit 00aa0f603deb3af1a8936006f1a8c310474b6fda
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 5 18:07:35 2020 -0800
Add a PLOTSIZE option UI type.
I'd missed this one earlier.
commit 6c8e0e23f7a1ae44edb173243db70a96c99acd81
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 5 18:06:46 2020 -0800
Redesign GncOptionDateValue.
After getting a better understanding of how it interacts with dialog-options and
finding some additional scheme API needing implementation (exposed only in
hello-world.scm, but possibly used in user-written reports).
Creates a new file-pair, gnc-options-date.[ch]pp to separate the creation of
the static structs with the type info and strings for the various
RelativeDatePeriod values from the already too large gnc-option-impl.
Although the result is a rather C-ish design the alternative with classes
or template specializations would be more complicated and offer no
benefit.
Implements the permissible_values functions of GncOptionMultichoiceValue
for GncDateValue and provides for absolute, relative, and both
UI values for the three widget configs afforded by dialog-options.
commit 3b78b6e894623109c0f075b1deaceeaa931da495
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Mar 5 17:55:15 2020 -0800
Change the GncOptionMultichoiceValue permissible value return types to const char*.
From std::string. The consumer is a GtkWidget so we might as well do the conversion
inside the class and this will simplify adding these functions to GncOptionDateValue
in the next commit.
commit d5f6a2539b13c6c9a5984d96575ac52de89cb1a7
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 20 12:09:21 2020 -0800
Replace GncOption::_get_option() with a friend function swig_get_option.
Implemented in gnc-optiondb.i it more clearly indicates the intended
use and restricts the access. Unfortunately further limiting the
friend declaration with #ifdef SWIG prevented the declaration from
working, raising the error "m_option is a private member of GncOption".
commit 93a3716c00f77420f495de1ffd3099e80ddfc1d5
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Feb 18 14:29:29 2020 -0800
Enable retrieval of a GncOptionDateValue's relative period.
So that it can be displayed by dialog-option.
commit dc876d4041729af8fdbae28c2e97bfe808f7b48d
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Feb 18 14:27:41 2020 -0800
Provide an accessor to GncOptionAccountValue::m_allowed
To enable its use by gnc_account_sel_filter
commit 102f36c3be237967842cb6df073fa5a7ffa98b61
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Feb 18 14:23:59 2020 -0800
Provide more than one Date UI type to match options available in dialog-option.c
Also differentiates begin-period and end-period controls.
commit 6c7f976a65dcb952087b1d8f3af62cf38bc053d9
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Feb 16 15:30:26 2020 -0800
Make second arg to gnc_glist_to_scm_list const char*
So that C++ won't complain when passed a static string.
commit 99c2c5e4395a92dff6da76b6cdac2b218f8e2e4b
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Feb 11 13:35:27 2020 -0800
GncOptionUIItem from the GncOptionVariant classes to GncOption.
Separating the UI from the data model. Note that the GncOptionVariant
classes still have a GncOptionUIType member to ensure that a
GncOptionUIItem of the right type is attached.
commit 1bea809cec542cd81f21c94a837b75ca5d22776a
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Feb 14 16:17:41 2020 -0800
Remove the UI interface from GncOptionDB.
UI operations occur only in dialog-option so there's no need to expose
them from GncOptionDB.
commit cbf7d70ecdcf60615c3748aa30df7df6496929f8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 13 10:36:54 2020 -0800
Integrate gnc-option into app-utils.
Includes converting swig-app-utils-guile to c++.
commit 81c5ac66897fe7cdc5c8e078911b2bd4333df157
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Feb 8 15:54:34 2020 -0800
Remove the incomplete book-currency code.
Not everything from the 6 Book-Currency commits is removed: Switching
the Num and split-action fields and restricting edits of transactions
older than n days were included and those changes are left in place.
Some other partly-implemented features were also part of these commits
and were removed: Options for setting a default capital gains account
and currency, completion of the LIFO cap-gains policy, and creation of
a list of cap-gains policies.
If any of these are to be revived they should each be done in a separate
feature branch and submitted via Github pull request for a code review
before merging; a design discussion on gnucash-devel before restarting
work is also advisable.
commit aa246d309693c29a7d08e3fe43b7a4274a3b2c26
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 27 13:40:39 2020 -0800
Make implementation classes and template code visible only in app-utils.
So only GncOption and the GncOptionDB free-function interface are public.
We don't want to expose template headers widely, it would blow up compilation
times and might lead to one definition rule violations.
commit 20b3ef8a892fe55fff30a3e946ceaf2f4528c008
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Jan 23 10:24:42 2020 -0800
Handle some minor differences between libc++ (clang) and libstdc++ (gcc).
commit cd6ccbe3318d6db8427176fa48900cac58a72492
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Jan 23 10:23:14 2020 -0800
Fix account-tree double-free in scheme test when built with gcc.
Oddly when built with clang it doesn't exhibit the crash.
commit 691cb0992e6c227bbbeb6de01b4e2c5d67986f50
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Jan 23 10:21:18 2020 -0800
Follow change in loading method for engine's guile bindings.
commit cbd0607e80e7c17ec3a0cf3bd588b054cd914167
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 20 11:37:21 2020 -0800
Implement load and store options from/to book options.
commit 5a82aac639230c20b7ee77116a9287ad4e54af96
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 20 11:36:37 2020 -0800
Hide constexpr constants from SWIG.
Swig bindings don't need them and SWIG can't digest constexpr.
commit ffc68664063d65c32378fbff370be4db7cf8fdb1
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Jan 20 11:32:10 2020 -0800
Changes to accommodate moving guile engine bindings to bindings/guile.
Plus for changing targets gncmod-engine and gncmod-app-utils to
gnc-engine and gnc-app-utils.
commit d2535fe21bf599eb58803673ca58b9e050628a3a
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Jan 19 15:05:28 2020 -0800
KvpValue: Use boost::typeindex::type_id instead of buildtin typeid.
Under some build conditions boost::typeindex will use an internal type
identifier that's different from the C++ builtin. In that case type equality
tests to C++ typeid in boost::variant will fail, breaking it. Using
boost::typeindex::type_id ensures that the comparisons always work.
commit 009219c63d3f6a075a51fdfd28fbd5c113d42294
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 14 16:44:16 2019 -0800
Much less ugly and fragile.
Finding the right form now relies on the form name instead of its
position in the parse tree.
commit 276641ef157a189e34b559fc70014a8878a8d9d5
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 14 15:43:24 2019 -0800
Change parse of option input to generate a parse tree.
This is I hope less brittle than the previous character-counting, though
it's still brittle because it relies instead on counting form-depth.
commit 51a1430c24443799ac0b7f7daab66d4d5fb54804
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Dec 14 15:37:02 2019 -0800
Remove stray diagnostic.
commit 76172af239edcfb3df3bfba94c41b3c5dbb5bd25
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 5 18:00:07 2019 -0800
Implement saving and loading OptionDB items to/from scheme and
key-value string representations.
commit 6ab5618b768cc4512acaa68f82c874a1cb3fef36
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 5 17:54:02 2019 -0800
Set a 50-character limit on the saved size of option section and name.
Allows use of istream::getline() to retrieve the values, simplifying
delimiter detection.
commit d7a2a0ffff75251d66002564016d74a520467ac3
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 5 17:47:30 2019 -0800
Make a constant for std::numeric_limits<std::size_t>max().
Improves readability.
commit 826d75af16b277bcbab02e1b14e75c3f8c703d23
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 5 17:46:13 2019 -0800
Use istream::getline instead of std::getline for date option type parsing.
commit c5294ed6b3b4cc742ef4821d0ea3ff8f9e43df11
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Dec 5 10:03:57 2019 -0800
Fix missing-declaration errors in swig-gnc-optiondb-guile.cpp.
commit 7ccba53739f1d07a58cd605c739523fc56fefb12
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 3 11:18:34 2019 -0800
Add stream functions to_scheme and from_scheme to GncOption.
These add or parse the textual noise needed to replicate the Scheme options'
serialization technique of saving scheme forms for saving report options
and then evaluating those forms to restore the option values. Required for
backward saved-reports compatibility.
commit 1ea382266524566d239f5d32e01d4de9f612b159
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 3 11:14:06 2019 -0800
More operator <</>> Fixups.
commit 98ca190700cae549d355e4b5508e9e653c8a452e
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 3 11:04:17 2019 -0800
Fix commodity in/out to use namespace & mnemonic instead of GUID.
commit 4b997cd025b9a65a3a7ee354f52fb787e65f7cb8
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Dec 3 10:43:35 2019 -0800
Fixups for GncOptionDateValue better design.
commit b2fb57d39edb6798eaad084e168363dc76438e2a
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Dec 1 15:58:52 2019 -0800
Fix GncOption::set_value() to work with GncOptionDateValue::set_value(RelativeDatePeriod).
Adjusting tests as necessary.
commit 4dcf4a0e6a4df3360017a2750cac75037db8046c
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Dec 1 15:20:46 2019 -0800
Test GncOptionRangeValue as a GncOption.
Better representation of how it will be used.
commit 4cabd6c0529fd85b30c7df1425033e94b0fc5936
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Dec 1 15:10:03 2019 -0800
Change the GncOptionMultichoiceValue test to use a GncOption.
Requires exposing the permissible values functions to GncOption.
commit e2a36a8be3221a5f7a7584697e712bfe45d06af0
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Dec 1 15:05:18 2019 -0800
Expose function validate to GncOption and test it on GncOptionValidatedValue.
commit 6df516dfcdbefe59ba60914a98f14ae2832dd8b6
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Dec 1 15:00:04 2019 -0800
Clean up the commodity/currency tests with a better fixture class.
commit 52d0ec52901fca6919e4d9ce09a525d992d15361
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Nov 25 11:20:44 2019 -0800
Change GncOptionDateValue design to better match usage.
Added advantage that it handles (not correctly, but in the same way as
the old code) the ambiguity between a period starting or ending with
the stored value "relative . today".
commit 883127a59d7081ac2a791331ae9e9aa1af3959dc
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 22 15:45:42 2019 -0800
Implement operators >> and << on GncOption.
commit e583c84f4e0291077eb04c673afd69b41b1fe0f2
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 17 15:47:42 2019 -0800
Clean up comments for GncOptionDateValue.
commit aaf6b14c67d158aa3bfd997a1973181ea9a2fb67
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 17 15:47:17 2019 -0800
Remove commented-out code.
commit 1b00399b14929961a532fd13a97c1f49712bed07
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 17 12:50:57 2019 -0800
Remove GncOptionValue<std::Vector<GncGUID>>.
This going to be the Account List option implementation, but a more
customized approach is better.
commit 5a9c4ccaf88174973cfc848d263a7cba1e2eaa04
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 17 12:48:10 2019 -0800
Clean out copies of the option.scm comments used as a development guide.
commit b95ea2c4aa4518ae7babc4cb1a237f107bccf670
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 17 11:15:56 2019 -0800
Add Account-list options.
commit 7183e7c43ab47d0d334d6433325b38eff9c1fa9f
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Nov 10 15:34:21 2019 -0800
Fix begin/end of quarter calculations.
Set the period to the calendar year if it's not set in prefs.
Handle correctly the FY start month being after the current month.
commit 399573a89ddf508ee86214e480d974ce11043461
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 8 16:31:36 2019 -0800
Fix multichoice test construction.
commit 12c5b9443000aafcd21214175762d04a49365ce5
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Nov 2 11:06:49 2019 -0700
New scheme function gnc_option_default_value.
commit 3f576671aa6246fc8d9d394400ce9f2852a0f0ba
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Nov 2 11:06:12 2019 -0700
Adapt GncOptionMultiChoiceValue to support list options.
Main change adds a value field to the constructor to set the value and
default value.
commit 2f2ac99944e8326168ce8e086bfe1d0c6975861a
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 1 16:14:30 2019 -0700
Replace the direct wrapping of GncOptionDB-set-option-string-foo.
With a simple type-free function gnc_option_set. This mirrors the current
(gnc:option-set(gnc:lookup-option... and takes care of SCM type conversion.
commit 252ba9b4779b9b6a3c66d2e54368a93b89394ddf
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Nov 1 14:59:49 2019 -0700
Change GncOptionDB::lookup_option to gnc_option_value().
The old gnc:lookup-option returned the option object so that it could be
manipulated rather than getting its value; gnc_option_value replicates
the behavior of (gnc:option-value (gnc:lookup-option)).
commit ff7b263a5f98cc7e48765a571b86f39ac3360aaf
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 31 18:17:03 2019 -0700
Fix up and test the int specialization of GncOptionRangeValue.
Not sure yet that a double one is really needed.
commit 39b7c9c74da0c903a6a59292c3d99fee416b839c
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 31 18:14:41 2019 -0700
Convert scm_from_value() to templates for stricter overload resolution.
commit 3dc4bc237730adecd9b375c53c48a5e4958291d6
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 29 16:34:44 2019 -0700
Implement GncOptionDateValue.
commit 435667e8fe16c9a66b1e765ac417135415a6bab3
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Oct 20 15:13:33 2019 -0700
Implement GncOptionMultichoiceValue
Replaces GncOptionValue<GncMultiChoiceOptionChoices> because having the
vector as the value obviously wouldn't work and besides it needs
additional functions.
commit 8eedcb6d6dcb18b2e536369ee2f4325d21877957
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 15 16:33:55 2019 -0700
Extract all SCM functions to gnc-optiondb.i.
So that it can be moved to bindings/ when gnc-module-load-begone is ready.
commit d544f852568cdaa271980153e699cbd3ec242918
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 15 14:49:49 2019 -0700
Replace boost::variant and boost::optional with the C++17 std equivs.
commit 694a15ed21ff8f21b521ea64c5f901dfc0b539bf
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Oct 13 09:40:08 2019 -0700
Extract SCM GncOptionDB::lookup_option to gnc-optiondb.i.
commit 16d1f0655bc69671bce3ed21eeb3a454fee8f3cf
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Oct 12 18:17:09 2019 -0700
Get libswig-gnc-optiondb to install in the right place on Windows.
commit cee3cdaff9a29a3f64e4d38faad6f96dc5873be4
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Oct 12 18:16:05 2019 -0700
Instantiate GncOption::set_option for guile, initial types string and int.
For proof-of-concept. Guile obviously doesn't know about templates.
commit 9cdcaf0da876dca96630f6e025bdb77843607d29
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Oct 12 18:14:22 2019 -0700
Remove GncOptionDB::set_selectable and convert set_option to a template.
commit 935ce6db99461415bf61e292362ae41118c3c4a3
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Oct 12 18:12:46 2019 -0700
Move the SCM option value conversion from the GncOptionValue classes to GncOption.
commit e51faff3e3dd4b4510f8da7edea6ddb047eaf044
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Oct 12 18:10:43 2019 -0700
Throw an exception if one tries to set a GncOption with an unsupported type.
commit c5fac51a8b6bf316d47bd6e613efaf1f8f277e87
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Oct 3 13:30:49 2019 -0700
Change the type of OptionUIItem's m_ui_item from void* to GncOptionUIItem.
A locally-opaque class wrapping whatever sort of widget ptr one needs.
Thanks, warlord!
commit 3296212aef4b87b7a37acf56d460cb6eaf25f1fc
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Oct 1 16:03:15 2019 -0700
Sketch out the rest of the option types.
Minimal implentation to get it to compile and pass tests, not functional yet.
commit 0a13b4c51868e0995217dec9783aa1a6f966f43c
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 12:12:32 2019 -0700
Fix up the SWIG wrapper for GncOptionDBPtr.
Thanks to Flexo at stackoverflow for
https://stackoverflow.com/questions/27693812/how-to-handle-unique-ptrs-with-swig
5 years later, why isn't this in SWIG yet?
commit 4146251cc79272df458cbfc509eb2ab5bdc89bc6
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 10:28:04 2019 -0700
Add GncOptionUIItem manipulation to GncOptionDB.
commit 6ccb9dbb9e04e251892fe2fd46441e3f7eb4b932
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 10:24:24 2019 -0700
Use a std::unique_ptr<GncOptionDB> instead of a raw ptr.
Passing references to it to the gnc_register_option functions.
Not tested yet with SWIG, might not work.
Includes introducing fixtures to gtest-gnc-optiondb.cpp.
commit 94628097e439e53a86d4df216afff6e4ea2741b9
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 10:11:48 2019 -0700
Use GncOptionUIType parameters in gnc_register_option functions.
commit 3769a356d55d918f22a0a2aac556d82415374676
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 10:06:00 2019 -0700
Extract functions find_section and find_option using boost::optional
to handle not-found condition.
commit 6deedd441f9fadd6250ee4d1793a4bb05c4b6797
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 09:58:07 2019 -0700
Make the ptr returned by GncOption::get_ui_item() const
but not the GtkWidget it points to.
commit 40361ec854e71220964831356b66ba8c4fb7e304
Author: John Ralls <jralls at ceridwen.us>
Date: Sun Sep 29 09:56:18 2019 -0700
gnc-opption.hpp needs to include <functional>.
commit 41ef2c5d44ba8a9667fb9393cd89945c22f432c3
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Sep 20 13:56:54 2019 -0700
Add OptionUIItem composition class to GncOption.
Provides a type and a raw pointer member with accessors. The type is one of
enum GncOptionIUType and is either VOID (for internal options that don't
get UI items) or one of the widget types specified in dialog-option.c or
business-options-gnome.c.
commit 083e5b93dfab92ded9487ab34d0c5adf83eb217c
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Sep 20 13:13:53 2019 -0700
Replace the CRTP class GncOptionBase with direct calls in its former children.
Benefit of CRTP too limited to accept the cost of understanding it.
commit cf0b1da4fa43699b233dd76516ff3971beb366bb
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Sep 20 12:40:43 2019 -0700
Remove GncOptionWrapper.
Move the GncOptions into the GncOptionDB. This works with tests but
might not with real reports.
commit 2ee0edaa163d17d2f2e6bf99b4a246d9e7d6738e
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Sep 20 12:36:45 2019 -0700
Use targets instead of variables for GncOption* tests.
commit d2655d3fb0e4fa78ce0ca3f2f210194ddeac290f
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 22 15:39:39 2019 -0700
Remove gnc-option-db business convenience functions.
gnc_option_db_lookup_invoice_option used only once, so moved its
guts there. The others weren't used at all.
commit ade7fc8b6e29a43d7b47db246066c57e6c6af309
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 6 15:31:44 2019 -0700
Initial SWIG of GncOptionDB and Scheme tests.
This class will be heavily used by reports so we need to ensure SWIG and
Scheme compatibility from the start.
commit f3eee511e88d406091151cfd4c8122ca0bbc40c8
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 6 15:29:58 2019 -0700
Add free functions to create a new GncOptionDB and to register options.
The objective of the free functions is to hide the GncOption from language
bindings so that the GncOptions can be moved into the GncOptionDB instead
of having shared ptrs splattered around the heap. Nearly all access to
the options can then be mediated through the GncOptionDB container.
Note that gnc_option_db_new creates the GncOptionDB on the heap and
returns a raw ptr, so it's up to the creator of the GncOptionDB to
call delete on it when it's no longer needed.
commit 455d3c2d6015c197c4000b2d48b925c0da498669
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 6 15:03:48 2019 -0700
Add GncOptionDB class.
commit 16fd632ec85a98358449a25579c5491ded376d4c
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 6 10:17:06 2019 -0700
Make the GncOption member variables private.
GncOption is intended to be final, so there's no point in protected members.
commit 13b94d2370b399a5d88cea5a4766ad5aef96c2a6
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Aug 6 10:24:42 2019 -0700
Test integer options, calling get_value with wrong type.
commit d88ec0dc1b59e3c15147dcd832d360331582cf8f
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 5 11:03:34 2019 -0700
Replace the gnc_make_foo_option free functions with a template ctor.
The free functions will reappear for GncOptionDB. This is to avoid
having to pass naked pointers to Scheme with the attendant object
lifetime issues.
commit 01dc70cc60ae546943200cb726723a419d35928f
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Aug 3 10:38:05 2019 -0700
Add GncOption accessors for Classifier strings.
commit 01fcae6ac8aa886db2efdbd6f61e847da1e6a553
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Aug 3 10:11:49 2019 -0700
Make the OptionClassifier members non-const.
Constness deletes the default copy assignment operator, making GncOption
not copy-assignable.
commit b6fd8447743e2d741ebfb8cf49bc24acdf0f470e
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Jul 20 15:09:11 2019 -0700
Wrap GncOptionValue/GncOptionValidatedValue in Boost::Variant.
To provide a single type for containers.
commit c0ba3e2706985d15ac53c95a85a81aeec1587ad0
Author: John Ralls <jralls at ceridwen.us>
Date: Tue Jul 9 09:40:29 2019 -0700
[C++ Options] Begin Implementation for basic and validated options.
commit b495da4e2952fa45c8a98c70e914ec5d12049e2e
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Jul 11 14:35:55 2019 -0700
[C++ Options] Remove some unused C API from options-utils.
commit 0b77641e9f0506be331c69afbb98a9f103e9d880
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Jul 5 14:29:33 2019 -0700
Remove gnc_options_dialog bindings from gnome-utils.i.
They're unused.
Summary of changes:
CMakeLists.txt | 2 +-
bindings/engine.i | 4 -
bindings/guile/glib-guile.c | 2 +-
bindings/guile/glib-guile.h | 2 +-
gnucash/gnome-utils/CMakeLists.txt | 8 +-
gnucash/gnome-utils/dialog-options.c | 4351 --------------------
gnucash/gnome-utils/dialog-options.cpp | 2789 +++++++++++++
gnucash/gnome-utils/dialog-options.h | 116 -
gnucash/gnome-utils/dialog-options.hpp | 200 +
gnucash/gnome-utils/dialog-utils.c | 45 -
gnucash/gnome-utils/gnc-gnome-utils.c | 63 -
gnucash/gnome-utils/gnc-gnome-utils.h | 16 -
gnucash/gnome-utils/gnc-gobject-utils.h | 2 +-
gnucash/gnome-utils/gnc-icons.c | 1 +
.../{gnc-main-window.c => gnc-main-window.cpp} | 709 ++--
gnucash/gnome-utils/gnc-main-window.h | 11 +-
gnucash/gnome-utils/gnome-utils.i | 8 -
gnucash/gnome/CMakeLists.txt | 14 +-
...sistant-hierarchy.c => assistant-hierarchy.cpp} | 241 +-
gnucash/gnome/assistant-hierarchy.h | 7 +
gnucash/gnome/business-options-gnome.c | 501 ---
gnucash/gnome/business-options-gnome.cpp | 224 +
gnucash/gnome/business-options-gnome.h | 11 +-
gnucash/gnome/dialog-custom-report.c | 2 -
gnucash/gnome/dialog-report-column-view.c | 705 ----
gnucash/gnome/dialog-report-column-view.cpp | 565 +++
...column-view.h => dialog-report-column-view.hpp} | 6 +-
...style-sheet.c => dialog-report-style-sheet.cpp} | 96 +-
gnucash/gnome/dialog-report-style-sheet.h | 11 +-
gnucash/gnome/gnc-budget-view.c | 2 -
gnucash/gnome/gnc-plugin-page-budget.c | 3 +-
...in-page-report.c => gnc-plugin-page-report.cpp} | 308 +-
gnucash/gnome/gnc-plugin-page-report.h | 9 +-
gnucash/gnome/top-level.c | 1 -
.../gnome/{window-report.c => window-report.cpp} | 132 +-
gnucash/gnome/window-report.h | 12 +-
gnucash/gnucash-commands.cpp | 2 +-
gnucash/gnucash-core-app.cpp | 2 +-
gnucash/gnucash.cpp | 5 +-
gnucash/html/gnc-html-extras.h | 2 +-
gnucash/html/gnc-html-history.h | 2 +-
gnucash/html/gnc-html-webkit2.c | 4 +-
gnucash/html/gnc-html.c | 14 +-
gnucash/html/gnc-html.h | 1 +
gnucash/html/gnc-html.i | 4 +-
gnucash/report/CMakeLists.txt | 2 +-
gnucash/report/{gnc-report.c => gnc-report.cpp} | 44 +-
gnucash/report/gnc-report.h | 47 +-
gnucash/report/html-utilities.scm | 6 +-
gnucash/report/report-core.scm | 9 +-
.../report/reports/standard/account-summary.scm | 111 +-
.../standard/test/test-equity-statement.scm | 4 +-
.../reports/standard/test/test-portfolios.scm | 4 +-
.../report/reports/standard/test/test-register.scm | 4 +-
.../reports/standard/test/test-stress-options.scm | 9 +-
.../reports/standard/test/test-trial-balance.scm | 4 +-
gnucash/report/reports/standard/view-column.scm | 27 +-
libgnucash/app-utils/CMakeLists.txt | 51 +-
libgnucash/app-utils/app-utils.i | 32 +-
libgnucash/app-utils/app-utils.scm | 4 +-
libgnucash/app-utils/business-options.c | 92 -
libgnucash/app-utils/business-options.h | 56 -
libgnucash/app-utils/business-options.scm | 386 --
libgnucash/app-utils/business-prefs.scm | 199 -
libgnucash/app-utils/gnc-option-date.cpp | 576 +++
libgnucash/app-utils/gnc-option-date.hpp | 189 +
libgnucash/app-utils/gnc-option-impl.cpp | 986 +++++
libgnucash/app-utils/gnc-option-impl.hpp | 1078 +++++
libgnucash/app-utils/gnc-option-ui.hpp | 63 +
.../app-utils/gnc-option-uitype.hpp | 79 +-
libgnucash/app-utils/gnc-option.cpp | 546 +++
libgnucash/app-utils/gnc-option.hpp | 261 ++
libgnucash/app-utils/gnc-optiondb-impl.hpp | 191 +
libgnucash/app-utils/gnc-optiondb.cpp | 1251 ++++++
libgnucash/app-utils/gnc-optiondb.h | 175 +
libgnucash/app-utils/gnc-optiondb.hpp | 893 ++++
libgnucash/app-utils/gnc-optiondb.i | 1913 +++++++++
libgnucash/app-utils/gnc-ui-util.c | 119 -
libgnucash/app-utils/gnc-ui-util.h | 34 -
libgnucash/app-utils/option-util.c | 2823 -------------
libgnucash/app-utils/option-util.h | 287 --
libgnucash/app-utils/options.scm | 2493 ++---------
libgnucash/app-utils/test/CMakeLists.txt | 42 +-
libgnucash/app-utils/test/gtest-gnc-option.cpp | 1329 ++++++
libgnucash/app-utils/test/gtest-gnc-optiondb.cpp | 408 ++
libgnucash/app-utils/test/test-app-utils.c | 55 -
.../test/test-gnc-option-scheme-output.scm | 591 +++
libgnucash/app-utils/test/test-gnc-optiondb.scm | 249 ++
libgnucash/app-utils/test/test-gnc-ui-util.c | 262 --
libgnucash/app-utils/test/test-option-util.cpp | 137 -
libgnucash/app-utils/test/test-options.scm | 32 +-
libgnucash/engine/engine-helpers.c | 16 -
libgnucash/engine/engine-helpers.h | 5 -
libgnucash/engine/gnc-date.cpp | 4 +-
libgnucash/engine/gnc-features.c | 1 -
libgnucash/engine/gnc-features.h | 1 -
libgnucash/engine/gnc-numeric.cpp | 2 +-
libgnucash/engine/kvp-value.cpp | 36 +-
libgnucash/engine/kvp-value.hpp | 2 +-
libgnucash/engine/policy-p.h | 3 -
libgnucash/engine/policy.c | 83 -
libgnucash/engine/policy.h | 34 +-
libgnucash/engine/qofbook.cpp | 126 +-
libgnucash/engine/qofbook.h | 50 +-
libgnucash/engine/qofbookslots.h | 10 -
libgnucash/engine/test/test-qofbook.c | 106 -
po/POTFILES.in | 26 +-
107 files changed, 15978 insertions(+), 13895 deletions(-)
delete mode 100644 gnucash/gnome-utils/dialog-options.c
create mode 100644 gnucash/gnome-utils/dialog-options.cpp
delete mode 100644 gnucash/gnome-utils/dialog-options.h
create mode 100644 gnucash/gnome-utils/dialog-options.hpp
rename gnucash/gnome-utils/{gnc-main-window.c => gnc-main-window.cpp} (89%)
rename gnucash/gnome/{assistant-hierarchy.c => assistant-hierarchy.cpp} (91%)
delete mode 100644 gnucash/gnome/business-options-gnome.c
create mode 100644 gnucash/gnome/business-options-gnome.cpp
delete mode 100644 gnucash/gnome/dialog-report-column-view.c
create mode 100644 gnucash/gnome/dialog-report-column-view.cpp
rename gnucash/gnome/{dialog-report-column-view.h => dialog-report-column-view.hpp} (95%)
rename gnucash/gnome/{dialog-report-style-sheet.c => dialog-report-style-sheet.cpp} (88%)
rename gnucash/gnome/{gnc-plugin-page-report.c => gnc-plugin-page-report.cpp} (90%)
rename gnucash/gnome/{window-report.c => window-report.cpp} (65%)
rename gnucash/report/{gnc-report.c => gnc-report.cpp} (91%)
delete mode 100644 libgnucash/app-utils/business-options.c
delete mode 100644 libgnucash/app-utils/business-options.h
delete mode 100644 libgnucash/app-utils/business-options.scm
delete mode 100644 libgnucash/app-utils/business-prefs.scm
create mode 100644 libgnucash/app-utils/gnc-option-date.cpp
create mode 100644 libgnucash/app-utils/gnc-option-date.hpp
create mode 100644 libgnucash/app-utils/gnc-option-impl.cpp
create mode 100644 libgnucash/app-utils/gnc-option-impl.hpp
create mode 100644 libgnucash/app-utils/gnc-option-ui.hpp
copy gnucash/register/ledger-core/split-register-layout.h => libgnucash/app-utils/gnc-option-uitype.hpp (57%)
create mode 100644 libgnucash/app-utils/gnc-option.cpp
create mode 100644 libgnucash/app-utils/gnc-option.hpp
create mode 100644 libgnucash/app-utils/gnc-optiondb-impl.hpp
create mode 100644 libgnucash/app-utils/gnc-optiondb.cpp
create mode 100644 libgnucash/app-utils/gnc-optiondb.h
create mode 100644 libgnucash/app-utils/gnc-optiondb.hpp
create mode 100644 libgnucash/app-utils/gnc-optiondb.i
delete mode 100644 libgnucash/app-utils/option-util.c
delete mode 100644 libgnucash/app-utils/option-util.h
create mode 100644 libgnucash/app-utils/test/gtest-gnc-option.cpp
create mode 100644 libgnucash/app-utils/test/gtest-gnc-optiondb.cpp
delete mode 100644 libgnucash/app-utils/test/test-app-utils.c
create mode 100644 libgnucash/app-utils/test/test-gnc-option-scheme-output.scm
create mode 100644 libgnucash/app-utils/test/test-gnc-optiondb.scm
delete mode 100644 libgnucash/app-utils/test/test-gnc-ui-util.c
delete mode 100644 libgnucash/app-utils/test/test-option-util.cpp
More information about the gnucash-patches
mailing list