gnucash stable: Bug 798863 - Crash on clicking Settings button second time

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/4a5b897d (commit)
	from  https://github.com/Gnucash/gnucash/commit/50ff4a3a (commit)



commit 4a5b897d8918c1a22ed0da5b6be1daf5a6b41b50
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Apr 20 20:08:38 2023 -0700

    Bug 798863 - Crash on clicking Settings button second time
    
    Ensure that dialog resources stored in options are freed when the
    dialog is destroyed.
    
    The crash happened when a new dialog replaced the old one on the options
    and the old one's destructors tried to access a dangling reference to
    a GtkWidget.



Summary of changes:
 gnucash/gnome-utils/dialog-options.cpp | 7 +++++++
 libgnucash/engine/gnc-option.cpp       | 3 ++-
 2 files changed, 9 insertions(+), 1 deletion(-)