gnucash master: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Mon Feb 6 14:31:22 EST 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/464d1d23 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bd8e81f3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1c667972 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/78ec2051 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c819b03a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/ea2d3be2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4e25bbfc (commit)
	from  https://github.com/Gnucash/gnucash/commit/9446ae7f (commit)



commit 464d1d237b087f17befcf9f5f5b1a1d899fbf126
Merge: 9446ae7fb bd8e81f35
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Feb 6 11:27:16 2023 -0800

    Merge Richard Cohen's 'fix-unused-variables-part1' into master.

commit bd8e81f35c86a98ac32827c6352e2927343a740d
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Mon Feb 6 12:16:07 2023 +0000

    Move an unused variable into an #ifdef where it is used

commit 1c6679720b5088d16a251352d4452cf413bc91c5
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Wed Jan 25 13:13:12 2023 +0000

    Use some unused variables

commit 78ec20515ba5d22766f81b20d88a34780201ff47
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Wed Jan 25 13:06:53 2023 +0000

    Remove some unused variables - and the initialization
    
    - checked that any side effects were irrelevant

commit c819b03a17b63b2db3e2c371382b274b61f10f2f
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Wed Jan 25 16:20:53 2023 +0000

    Remove some unused variables - leave the side effect

commit ea2d3be217d499e3d002b86b57e03a69a18b1518
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 16:23:52 2023 +0000

    Remove some unused variables with obviously no side effects

commit 4e25bbfc43819fc456d12b1f3ede44c24f9ee1f8
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Sat Feb 4 14:23:36 2023 +0000

    Mark some QofLogModules as potentially unused
    
    - __attribute__((unused)) for C
    - [[maybe_unused]] for cpp



Summary of changes:
 bindings/guile/gnc-engine-guile.cpp                |  2 --
 bindings/guile/gnc-optiondb.i                      | 12 ---------
 borrowed/jenny/jenny.c                             |  6 +----
 gnucash/gnome-utils/account-quickfill.c            |  1 -
 gnucash/gnome-utils/dialog-doclink-utils.c         |  1 -
 gnucash/gnome-utils/dialog-dup-trans.c             |  1 -
 gnucash/gnome-utils/dialog-file-access.c           |  1 -
 gnucash/gnome-utils/dialog-options.cpp             |  1 -
 gnucash/gnome-utils/gnc-amount-edit.c              |  1 -
 gnucash/gnome-utils/gnc-autoclear.c                |  2 --
 gnucash/gnome-utils/gnc-cell-renderer-text-flag.c  |  1 -
 gnucash/gnome-utils/gnc-cell-view.c                |  1 -
 gnucash/gnome-utils/gnc-frequency.c                | 11 --------
 gnucash/gnome-utils/gnc-gtk-utils.c                |  1 -
 gnucash/gnome-utils/gnc-main-window.cpp            | 10 --------
 gnucash/gnome-utils/gnc-plugin-file-history.c      |  1 -
 gnucash/gnome-utils/gnc-query-view.c               |  1 -
 gnucash/gnome/assistant-hierarchy.cpp              |  2 --
 gnucash/gnome/dialog-doclink.c                     |  1 -
 gnucash/gnome/dialog-fincalc.c                     |  7 ++++--
 gnucash/gnome/dialog-new-user.c                    |  2 --
 gnucash/gnome/dialog-payment.c                     |  1 -
 gnucash/gnome/dialog-price-edit-db.cpp             |  1 -
 gnucash/gnome/dialog-report-column-view.cpp        |  2 --
 gnucash/gnome/gnc-plugin-basic-commands.c          |  2 --
 gnucash/gnome/gnc-plugin-business.c                |  1 -
 gnucash/gnome/gnc-plugin-page-account-tree.c       |  2 --
 gnucash/gnome/gnc-plugin-page-budget.c             |  3 +--
 gnucash/gnome/gnc-plugin-page-invoice.c            | 12 +++------
 gnucash/gnome/gnc-plugin-page-owner-tree.c         | 22 ----------------
 gnucash/gnome/gnc-plugin-page-register.c           | 13 ----------
 gnucash/gnome/gnc-plugin-page-report.cpp           |  9 +++----
 gnucash/gnome/gnc-plugin-page-sx-list.c            |  4 ---
 gnucash/gnome/gnc-split-reg.c                      |  3 ---
 gnucash/gnome/window-autoclear.c                   |  2 +-
 gnucash/gnome/window-reconcile.c                   |  2 +-
 gnucash/gnucash-cli.cpp                            |  2 +-
 gnucash/html/gnc-html-webkit2.c                    |  5 +---
 gnucash/import-export/aqb/assistant-ab-initial.c   |  3 +--
 .../aqb/dialog-ab-select-imexporter.c              |  2 +-
 gnucash/import-export/aqb/dialog-ab-trans.c        |  3 +--
 gnucash/import-export/aqb/gnc-ab-getbalance.c      |  1 -
 gnucash/import-export/aqb/gnc-ab-gettrans.c        |  1 -
 gnucash/import-export/aqb/gnc-ab-transfer.c        |  1 -
 gnucash/import-export/aqb/gnc-ab-utils.c           |  2 +-
 gnucash/import-export/aqb/gnc-gwen-gui.c           |  2 +-
 gnucash/import-export/aqb/gnc-plugin-aqbanking.c   |  1 -
 .../import-export/csv-exp/assistant-csv-export.c   |  1 -
 .../csv-imp/assistant-csv-account-import.c         |  1 -
 gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp |  1 -
 gnucash/import-export/import-main-matcher.c        |  9 ++-----
 gnucash/import-export/import-match-picker.c        |  6 -----
 gnucash/import-export/ofx/gnc-ofx-import.c         |  5 ----
 .../import-export/qif-imp/assistant-qif-import.c   |  1 -
 .../test/gtest-import-account-matcher.cpp          |  2 --
 .../import-export/test/gtest-import-backend.cpp    |  1 -
 .../register/ledger-core/split-register-copy-ops.c |  5 +---
 .../register/ledger-core/split-register-model.c    |  1 -
 gnucash/register/ledger-core/split-register.c      |  1 -
 .../test/utest-split-register-copy-ops.c           |  5 ++--
 gnucash/register/register-gnome/combocell-gnome.c  |  2 --
 gnucash/register/register-gnome/gnucash-header.c   |  1 -
 .../register/register-gnome/gnucash-item-edit.c    |  3 +--
 gnucash/register/register-gnome/gnucash-register.c |  1 -
 gnucash/register/register-gnome/gnucash-sheet.c    |  4 ---
 gnucash/register/register-gnome/gnucash-style.c    |  1 -
 libgnucash/app-utils/gnc-gsettings.cpp             |  1 -
 libgnucash/app-utils/gnc-sx-instance-model.c       |  2 +-
 libgnucash/app-utils/gnc-ui-balances.c             |  2 --
 libgnucash/app-utils/test/gtest-gnc-quotes.cpp     |  2 --
 libgnucash/backend/dbi/gnc-backend-dbi.cpp         |  4 +--
 libgnucash/backend/dbi/gnc-dbisqlconnection.cpp    |  1 -
 .../backend/dbi/test/test-backend-dbi-basic.cpp    |  9 +++----
 libgnucash/backend/sql/gnc-address-sql.cpp         |  3 ---
 libgnucash/backend/sql/gnc-budget-sql.cpp          |  2 +-
 libgnucash/backend/sql/gnc-commodity-sql.cpp       |  2 +-
 libgnucash/backend/sql/gnc-order-sql.cpp           |  2 +-
 libgnucash/backend/sql/gnc-recurrence-sql.cpp      |  1 -
 libgnucash/backend/sql/gnc-slots-sql.cpp           |  2 --
 libgnucash/backend/sql/gnc-sql-backend.cpp         |  2 --
 .../backend/sql/gnc-sql-column-table-entry.cpp     |  3 ---
 libgnucash/backend/sql/gnc-transaction-sql.cpp     |  5 ----
 libgnucash/backend/xml/gnc-transaction-xml-v2.cpp  |  2 +-
 libgnucash/backend/xml/io-gncxml-v1.cpp            |  2 --
 libgnucash/backend/xml/io-gncxml-v2.cpp            |  4 ---
 libgnucash/backend/xml/sixtp-dom-generators.cpp    |  2 --
 libgnucash/backend/xml/test/test-kvp-frames.cpp    |  3 ---
 libgnucash/core-utils/binreloc.c                   |  3 +--
 libgnucash/core-utils/gnc-filepath-utils.cpp       |  1 -
 libgnucash/engine/Account.cpp                      |  3 ---
 libgnucash/engine/Scrub.c                          |  1 -
 libgnucash/engine/Split.c                          |  2 --
 libgnucash/engine/TransLog.c                       |  1 -
 libgnucash/engine/Transaction.c                    |  3 ---
 libgnucash/engine/gnc-date.cpp                     |  3 ---
 libgnucash/engine/gnc-datetime.cpp                 |  3 ---
 libgnucash/engine/gnc-int128.cpp                   |  1 -
 libgnucash/engine/gnc-lot.c                        |  2 --
 libgnucash/engine/gnc-numeric.cpp                  |  3 ---
 libgnucash/engine/gnc-option-impl.cpp              |  1 -
 libgnucash/engine/gnc-timezone.cpp                 |  4 +--
 libgnucash/engine/gncCustomer.c                    |  2 --
 libgnucash/engine/gncInvoice.c                     |  4 +--
 libgnucash/engine/gncJob.c                         |  2 --
 libgnucash/engine/gncVendor.c                      |  2 --
 libgnucash/engine/guid.cpp                         |  3 +--
 libgnucash/engine/kvp-frame.cpp                    |  2 --
 libgnucash/engine/qofbook.cpp                      |  4 ---
 libgnucash/engine/qofinstance.cpp                  |  2 --
 libgnucash/engine/qofquery.cpp                     |  2 +-
 libgnucash/engine/test-core/test-engine-stuff.cpp  |  6 -----
 libgnucash/engine/test/gtest-gnc-int128.cpp        | 29 ++++++++++------------
 libgnucash/engine/test/gtest-import-map.cpp        |  3 ---
 libgnucash/engine/test/gtest-qofevent.cpp          |  1 -
 libgnucash/engine/test/test-gnc-date.c             |  1 -
 libgnucash/engine/test/test-gnc-guid.cpp           |  4 +--
 libgnucash/engine/test/test-qofinstance.cpp        |  3 ---
 libgnucash/engine/test/test-qofsession.cpp         |  2 +-
 libgnucash/engine/test/utest-Account.cpp           |  2 +-
 libgnucash/engine/test/utest-Budget.c              |  1 -
 libgnucash/engine/test/utest-Invoice.c             |  2 --
 libgnucash/engine/test/utest-Split.cpp             |  2 --
 libgnucash/engine/test/utest-Transaction.cpp       | 11 +-------
 libgnucash/engine/test/utest-gnc-pricedb.c         |  1 -
 libgnucash/tax/gnc-locale-tax.c                    |  1 -
 125 files changed, 63 insertions(+), 335 deletions(-)



More information about the gnucash-patches mailing list