gnucash master: Multiple changes pushed

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/3f3460fe (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6ada3822 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/625978cc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/57c525fb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/47376652 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9384308b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/dd830429 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/807340bc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/81e17531 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/88fd034f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3af93741 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e5de32fd (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8156f42c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a31ffd1b (commit)
	from  https://github.com/Gnucash/gnucash/commit/3686ad41 (commit)



commit 3f3460fec9258ba89c5ce9fd8a30f94b5f832b9a
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Mon Feb 13 12:58:01 2023 +0100

    Bug 782141 - Import CSV - Multi-currency support can cause rounding errors
    
    This commit introduces new column types 'Value' and 'Value (Negated)'
    which can be used to indicate what the value of a split's amount
    is in the transaction currency. These will only be used if the
    transaction currency is different from the account commodity
    of the given split. Otherwise the amount will simply be
    used as value.

commit 6ada3822f28bf14c199d704c410c180110c15862
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sun Feb 12 21:17:25 2023 +0100

    CsvTransImp - drop obsolete sanity check
    
    Incomplete transfer split data will now be used by
    the generic import matcher to create the balancing split.

commit 625978cc3395e94a774e70490a25a29c2d4ed955
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sun Feb 12 21:15:48 2023 +0100

    CsvTransImp - rework verification code to prevent new cases of invalid transactions
    
    With the added multi-currency support it would be possible
    to create imbalanced splits. A new check is added to detect
    this beforehand and prevent users from continuing.
    This required much of the verification logic to be revisited.

commit 57c525fb190bea65cdbd8cfbc9f830788f32f1c2
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 18:22:54 2023 +0100

    Remove unused function

commit 4737665289971f8ce853b53c54863a57542e3372
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 14:40:06 2023 +0100

    Don't use boost::optional for gnc_commodity pointers
    
    These pointers can simply be checked for null to determine
    whether they are set or not.

commit 9384308b0554fd196a23b0987f90cd384b2fc421
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 14:38:44 2023 +0100

    Remove unneeded forward declaration

commit dd83042904db886338ebfc4bd9d5bd391f6b82ba
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 14:20:39 2023 +0100

    CsvTxImp - make PreTrans a member of PreSplits
    
    Before it was tracked in a separate column in the parse table.
    However future checks on multi-currency inconsistencies
    will be easier to implement if it's a member in each PreSplit.

commit 807340bcd7717c018fbdf3e1b3b7fb3dd718e1ff
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 14:15:10 2023 +0100

    CsvTxImpProps - simplify exception handling
    
    - catch multiple exception types in one block
      the exception handling code was the same anyway
    - stop rethrowing the exception. The calling code
      doesn't need this and just ignores it.

commit 81e17531b94bf17d2b29b1c1d8860fed86088f4b
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 14:00:58 2023 +0100

    Csv Tx Imp Props - don't reset multi column property errors by default
    
    This would mask errors encountered in previous columns.

commit 88fd034f896aa17fd9bb698f93f0e9bf510b87a0
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 11:33:22 2023 +0100

    Csv Trans Imp - remove redundant test
    
    Remainder of the code ensures a GncPreSplit account is always
    set to either the base account value or a value of an account
    column. It's useless to try once more to set a base account
    right before creating the preliminary transactions.

commit 3af93741269fef7048907ae81c24bacca5536251
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 11:17:44 2023 +0100

    GncTransPropType - use consistent naming
    
    A few freshly added values had a superfluous _ in the name

commit e5de32fd730d8dae06f196e7a7dcb739575418c1
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 11 11:14:15 2023 +0100

    Csv Trans Import - rework error propagation
    
    Use maps and vectors to move error messages around.
    Only merge them into a string right before they
    need to be passed to Gtk for presentation to the user.

commit 8156f42c2b2539967879a40f71d62cfe4a51bb8f
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Wed Feb 8 13:08:05 2023 +0100

    Fix setting and resetting of split properties that can be set more than once
    
    Define them as a separate group and add a function
    to test for this trait. Use that function
     consistently instead of testing individual values
    everywhere.

commit a31ffd1b70387ac27fcf5caf399e667d001ce067
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Wed Feb 8 12:49:25 2023 +0100

    Bug 797383 - Import transaction via CSV selects the commodity as a currency
    
    ..., results in an invalid transaction that is uneditable, and a corrupted price database
    
    This commit will change the transaction currency
    to the from or base account's parent account currency if
    the from or base account is not denominated in a currency.
    This allows to import stock transactions directly into the stock
    account.



Summary of changes:
 .../gtkbuilder/assistant-csv-trans-import.glade    |  11 +-
 .../csv-imp/assistant-csv-trans-import.cpp         | 122 ++++---
 gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp | 392 +++++++++++++--------
 gnucash/import-export/csv-imp/gnc-imp-props-tx.hpp |  67 +++-
 gnucash/import-export/csv-imp/gnc-import-tx.cpp    | 316 +++++++++--------
 gnucash/import-export/csv-imp/gnc-import-tx.hpp    |  26 +-
 6 files changed, 570 insertions(+), 364 deletions(-)