gnucash stable: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Sun Jun 11 16:16:14 EDT 2023 

Updated	 via  https://github.com/Gnucash/gnucash/commit/6d60c112 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/96e349ba (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c4e0ddb8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/18696310 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/43b161c2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f4ac1f40 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fdfa8353 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b3b071e0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/cebc7198 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/925999e0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4ebc0287 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/74f707bf (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6d36d1d7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/0d9dd3b7 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/55046f22 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d67f0b3c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d92d5b4b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f36e5d56 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f7bfd0bc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3c81b4c8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/f46a958d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/7fb03b1b (commit)
	from  https://github.com/Gnucash/gnucash/commit/3307b802 (commit)



commit 6d60c112525c9b8be04332eb9968199c5468f57e
Merge: 96e349ba8d f7bfd0bcf8
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Jun 11 13:11:41 2023 -0700

    Merge Bob Fewell's 'revised-reg-desc' into stable.

commit 96e349ba8d1d1b6102ddbad9049629e71dbfbaae
Merge: 3307b802fe c4e0ddb819
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Jun 11 13:08:51 2023 -0700

    Merge Christopher Lam's 'stock-txns-mvc' into stable.

commit c4e0ddb8192950718b8617b365730ed6f6da9ce8
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 10 18:00:21 2023 -0700

    [stock-txn-asst] Don't use the initial value in amount edit widgets.
    
    Unless they're valid. Otherwise the invalid value will log an error
    that will prevent later valid input from working.

commit 186963109d86615e5786c6a36051a522d3847d58
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 10 17:23:35 2023 -0700

    [stock-txn-asst] Remove some superflous declarations.

commit 43b161c28b1345d8c9fd22ef7efb0a8e23c90341
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 10 13:44:34 2023 -0700

    [stock-txn-asst] Add comments explaining workings.

commit f4ac1f40fe6fcafb28daff4396177aea3208f084
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Feb 21 10:32:41 2023 -0800

    [stock-txn-asst] Extract page classes for StockAssistantView.

commit fdfa8353dda70abf12852fe4a2987c908074600e
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Jan 29 14:01:59 2023 -0800

    [stock-txn-asst] Extract StockTransactionEntry classes.

commit b3b071e0112c926ad02be13f9c85e3c35d1bf7d3
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jan 28 10:49:33 2023 -0800

    [stock-txn-asst] StockAssistantModel variable names
    
    Rename member variables with m_ prefix, remove this-> from
    in-class references to those variables.

commit cebc7198f2e46bb954c56e71ae1cab683c98c773
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jan 27 16:46:46 2023 -0800

    [stock-txn-asst] Reformat StockAssistantModel
    
    Moving the ctor and dtor to immediately after the variables and
    moving the longer function defs out of the class decl.

commit 925999e070e93bd5602f5ae90a6522ca7442fb7e
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jan 27 15:45:17 2023 -0800

    [stock-txn-asst] Refactor check_page into a constructor.
    
    Because it is one.

commit 4ebc028740e70ac760e4d2b105b9391b645be5b0
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Jan 27 15:23:25 2023 -0800

    [stock-txn-asst] Refactor gtest-assistant-stock-transaction.cpp
    
    For better readability. Removes gratuitous parameterized test
    suite because the StockAssistantModel is stateful and can't
    use easyTestCases when it and the book are re-created for
    each instance, as is the case when the easyTestCases is passed
    as a parameter set to a test suite.
    
    Also replaced the shared_ptr<QofBook> with a unique_ptr.

commit 74f707bfa73b4fd0cc72968605d43d6e97bb7361
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Jan 26 13:54:21 2023 -0800

    [asst-stock-trans] StockAssistantModel instance variable names
    
    Should start with m_. Also designating them with this-> isn't
    idiomatic or necessary, and long functions shouldn't be defined
    in the class/struct body.

commit 6d36d1d7eea8aad3182084448b00e8357e5f3aed
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Jan 26 13:27:43 2023 -0800

    [asst-stock-trans] Rename primary callbacks to clarify their purpose.

commit 0d9dd3b789ac6a8bd9222d07715455760c39dd15
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Jan 17 22:30:34 2023 +0800

    [assistant-stock-transaction] support additional txn_types

commit 55046f22d26c71dd813d71b2da7fa62e2d2b2b82
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Jan 17 21:58:25 2023 +0800

    reduce number of bools in txn_type info: fees_capitalize

commit d67f0b3c999aa5c2120aed6f2e1b94ed6c4bc4cc
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Jan 17 21:51:01 2023 +0800

    reduce number of bools in txn_type info: input_new_balance
    
    input_new_balance merged into stock_amount FieldMask

commit d92d5b4bd213a0dc439418149696d1cefd2241ab
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Oct 23 20:21:37 2022 +0800

    test suite for assistant-stock-transaction.cpp

commit f36e5d56ed09ad8a4effd867be8a71a59a8ec628
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Oct 1 22:41:22 2022 +0800

    [assistant-stock-transaction] refactor using MVC

commit f7bfd0bcf8dea7f8e0510cde98acf3a266404efc
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun May 28 14:07:23 2023 +0100

    Add a don't complete entry to the top of the list

commit 3c81b4c85c08ffec1650e35d61cac26fd15c7f4e
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun May 28 14:06:16 2023 +0100

    Use new completion cell for register description field

commit f46a958da21e35c3256e5fdb8e620d92a5f45529
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun May 28 14:05:10 2023 +0100

    Modify GncItemList by adding a couple of functions.
    
    It is more efficient to disconnect the list store from the tree store
    and then reconnect it before doing large number additions to the list
    store so add a couple of functions to do this.

commit 7fb03b1be29d1aef8859100f549d12fc0658636d
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Tue May 2 14:48:00 2023 +0100

    Create a new register cell type 'completioncell'
    
    Used to present a pop up list of text entries that has been filtered by
    entered keystrokes anywhere in the text entries.



Summary of changes:
 gnucash/gnome/assistant-stock-transaction.cpp      | 2465 +++++++++++++-------
 gnucash/gnome/test/CMakeLists.txt                  |   37 +
 .../test/gtest-assistant-stock-transaction.cpp     |  274 +++
 .../org.gnucash.GnuCash.dialogs.gschema.xml.in     |   11 +
 .../gtkbuilder/assistant-stock-transaction.glade   |    6 +-
 .../register/ledger-core/split-register-layout.c   |    2 +-
 gnucash/register/ledger-core/split-register-load.c |   44 +-
 gnucash/register/ledger-core/split-register.c      |   17 +-
 gnucash/register/register-core/CMakeLists.txt      |    1 +
 gnucash/register/register-core/combocell.h         |    8 -
 gnucash/register/register-core/completioncell.h    |   79 +
 gnucash/register/register-core/register-common.c   |    1 +
 gnucash/register/register-core/register-common.h   |    1 +
 gnucash/register/register-gnome/CMakeLists.txt     |    1 +
 gnucash/register/register-gnome/combocell-gnome.c  |   92 +-
 .../register/register-gnome/completioncell-gnome.c |  960 ++++++++
 .../register/register-gnome/gnucash-item-list.c    |   48 +-
 .../register/register-gnome/gnucash-item-list.h    |    6 +-
 gnucash/register/register-gnome/gnucash-register.c |    2 +
 19 files changed, 3007 insertions(+), 1048 deletions(-)
 create mode 100644 gnucash/gnome/test/gtest-assistant-stock-transaction.cpp
 create mode 100644 gnucash/register/register-core/completioncell.h
 create mode 100644 gnucash/register/register-gnome/completioncell-gnome.c

More information about the gnucash-patches mailing list