gnucash master: Multiple changes pushed
Geert Janssens
gjanssens at code.gnucash.org
Mon Mar 13 15:02:29 EDT 2023
Updated via https://github.com/Gnucash/gnucash/commit/16cc2180 (commit)
via https://github.com/Gnucash/gnucash/commit/0ed0be4e (commit)
via https://github.com/Gnucash/gnucash/commit/4ae15e67 (commit)
via https://github.com/Gnucash/gnucash/commit/37e0f407 (commit)
via https://github.com/Gnucash/gnucash/commit/d75ab275 (commit)
via https://github.com/Gnucash/gnucash/commit/13ec4bb5 (commit)
via https://github.com/Gnucash/gnucash/commit/8010d964 (commit)
from https://github.com/Gnucash/gnucash/commit/427c1b96 (commit)
commit 16cc21809743337494178f5ab46eacba086dca13
Author: Geert Janssens <geert at kobaltwit.be>
Date: Fri Dec 30 19:28:00 2022 +0100
C++ - use more expressive std::any_of rather than std::find
What's looked for is encapsulated in a lambda function
named is_req_column_type. This compares values in the vector
with a value captured from the main context, which is updated
for each call of std::any.
commit 0ed0be4ef233368ff21bcf8976a25bcd59b607a5
Author: Geert Janssens <geert at kobaltwit.be>
Date: Fri Dec 30 19:20:43 2022 +0100
C++ - use more expressive std::accumulate algo rather than std::for_each
It encapsulates the custom string concatenation bits into a
lambda called "add_bullet_item" and streamlines the logic
of when to add what to the summary.
commit 4ae15e675c46131632ca4228323a67c8a4982746
Author: Geert Janssens <geert at kobaltwit.be>
Date: Tue Feb 28 22:25:19 2023 +0100
CsvImport - actually do as the warning indicates
If an invalid column is found in a preset, replace it
with a NONE column, rather than not inserting a column
at all.
commit 37e0f407e94ea947ad0343b89fab8fc5933f6884
Author: Geert Janssens <geert at kobaltwit.be>
Date: Tue Feb 28 15:50:48 2023 +0100
First test for gnc-trans-props-tx
Start with test for parse_monetary
- a few basic tests
- extra tests for recent bug fixes, like
- allow blank as thousands separator
- double minus sign equals positive number
commit d75ab275f1c481014107ba8b66bca3daccb8c6ac
Author: Geert Janssens <geert at kobaltwit.be>
Date: Tue Feb 28 15:49:10 2023 +0100
Eliminate gnc-csv-account-map.[ch]
The code is was only used by the csv import assistant and forced
gtk as a dependency on gnc-imp-props-tx
Part has been moved to Account, other bits have
been moved to the importer code where they were
used.
commit 13ec4bb5941945a5e1796e3260aabc610a543e2a
Author: Geert Janssens <geert at kobaltwit.be>
Date: Sun Feb 26 20:04:48 2023 +0100
xaccParseAmount... - some code cleanups
- declare at first use
- compact tests
- reduce use of {}
commit 8010d9646c003e5056a063c817515e421255011b
Author: Geert Janssens <geert at kobaltwit.be>
Date: Sun Feb 26 19:39:12 2023 +0100
Restore proper indentation
It got mixed up while refactoring the various xaccParseAmountXYZ functions
Summary of changes:
gnucash/gnome/assistant-stock-transaction.cpp | 24 ++-
gnucash/import-export/csv-imp/CMakeLists.txt | 2 -
.../csv-imp/assistant-csv-price-import.cpp | 18 +-
.../csv-imp/assistant-csv-trans-import.cpp | 48 ++++-
.../import-export/csv-imp/gnc-csv-account-map.c | 139 -------------
.../import-export/csv-imp/gnc-csv-account-map.h | 69 ------
gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp | 5 +-
gnucash/import-export/csv-imp/gnc-imp-props-tx.hpp | 2 +
.../csv-imp/gnc-imp-settings-csv-price.cpp | 6 +-
.../csv-imp/gnc-imp-settings-csv-tx.cpp | 7 +-
gnucash/import-export/csv-imp/test/CMakeLists.txt | 22 +-
.../csv-imp/test/gtest-gnc-imp-props-tx.cpp | 74 +++++++
libgnucash/app-utils/gnc-ui-util.c | 231 +++++++++------------
libgnucash/engine/Account.cpp | 25 +++
libgnucash/engine/Account.h | 5 +
po/POTFILES.in | 1 -
16 files changed, 300 insertions(+), 378 deletions(-)
delete mode 100644 gnucash/import-export/csv-imp/gnc-csv-account-map.c
delete mode 100644 gnucash/import-export/csv-imp/gnc-csv-account-map.h
create mode 100644 gnucash/import-export/csv-imp/test/gtest-gnc-imp-props-tx.cpp
More information about the gnucash-patches
mailing list