gnucash master: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/00c560d8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/352ab8a0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/24f52d9b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b5f3f990 (commit)
	from  https://github.com/Gnucash/gnucash/commit/f6e5d209 (commit)



commit 00c560d8f5fddb2516baf75d9371db743bbe5dcb
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Mar 18 13:53:49 2023 -0700

    Move operator==(const GncGUID&, const GncGUID&) to guid.[ch]pp.

commit 352ab8a0e56c343640394208cf6d8dba282edf3c
Merge: f6e5d209cd 24f52d9b17
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Mar 18 12:19:50 2023 -0700

    Merge Richard Cohen's 'minor-options-fixes' into master.

commit 24f52d9b171f5474a4d1e8c2f10a198dc462ae65
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Mar 7 11:44:20 2023 +0000

    Remove incorrect operator!= for GncItem
    
    It's better to use the default std::pair implementation
    
    - spotted by clang-tidy bugprone-suspicious-string-compare
    - will always return false, because type is the same
    
    Also,
    - remove redundant "using GncItem ..."

commit b5f3f99035a763e41217cfd7b792e4669ce17ba7
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Mar 7 11:27:21 2023 +0000

    Fix incorrect use of remove_if()
    
    - spotted by clang-tidy bugprone
    - probably no visible effects because of uniqueness, and other checks
    
    libgnucash/engine/gnc-optiondb.cpp:149:5: warning: this call will remove at most one item even when multiple items should be removed [bugprone-inaccurate-erase]
        m_options.erase(std::remove_if(m_options.begin(), m_options.end(),
        ^
    
    libgnucash/engine/gnc-optiondb.cpp:358:5: warning: the value returned by this function should be used [bugprone-unused-return-value]
        std::remove_if(m_callbacks.begin(), m_callbacks.end(),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    libgnucash/engine/gnc-optiondb.cpp:358:5: note: cast the expression to void to silence this warning



Summary of changes:
 libgnucash/engine/gnc-option-impl.cpp | 16 ----------------
 libgnucash/engine/gnc-optiondb.cpp    |  7 ++++---
 libgnucash/engine/guid.cpp            |  7 +++++++
 libgnucash/engine/guid.hpp            |  4 +++-
 4 files changed, 14 insertions(+), 20 deletions(-)