gnucash stable: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Wed May 17 22:58:27 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/5563d535 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8ccc6da8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b09fe481 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/74e5f87c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/848f4eb8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d36cf217 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/81fba56b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bed43c7f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/dc629595 (commit)
	from  https://github.com/Gnucash/gnucash/commit/26162da4 (commit)



commit 5563d535171f11b3a3a367d236341fd240c5df80
Merge: 8ccc6da87e b09fe48176
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 17 21:56:11 2023 -0500

    Merge Richard Cohen's 'remove-unneeded-code' into stable.

commit 8ccc6da87ea571be7181ee5ec4c7355cb4126b6d
Merge: 26162da450 81fba56bbb
Author: John Ralls <jralls at ceridwen.us>
Date:   Wed May 17 21:20:44 2023 -0500

    Merge Richard Cohen's 'fix-test-engine-crash' into stable.

commit b09fe48176fbfe556dcd7f9596d0afa45f31e9f0
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Wed May 17 13:48:36 2023 +0100

    Remove unused GnucashItemCursor

commit 74e5f87c69276a327fd782e08d4031c69545c682
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Thu May 11 16:04:17 2023 +0100

    Remove unused signal GNCSplitReg::include-date
    
    - time64 is NOT an int

commit 848f4eb81df0c4b692a17ae23ce320ecf8fa4a30
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Sun May 7 13:28:11 2023 +0100

    Remove unused GNCDateDelta

commit d36cf2177e257ea0b81dedf7d6324035c9143b5f
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Fri Mar 10 15:20:28 2023 +0000

    Remove action callbacks that simply set the state
    
    - it is the default behaviour

commit 81fba56bbb5266cc58417236418175ddb257cebd
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Mon May 15 19:36:30 2023 +0100

    Initialise guids in test-engine-kvp-properties.c
    
    Valgrind: Conditional jump or move depends on uninitialised value(s)

commit bed43c7f3b8a2dce20aa241800b26f3ae65f0b8d
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Mon May 15 19:12:33 2023 +0100

    Fix potential crash in test-engine
    
    ==515314== Invalid read of size 1
    ==515314==    at 0x484AD67: __strcmp_sse42 (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==515314==    by 0x171D36: do_test_list_handler (unittest-support.c:181)
    ==515314==    by 0x171DCE: test_list_handler (unittest-support.c:197)
    ==515314==    by 0x51BD4C1: g_logv (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x51BD7A2: g_log (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x4D5D0D9: xaccSplitEqualCheckBal (Split.c:753)
    ==515314==    by 0x4D5D841: xaccSplitEqual (Split.c:869)
    ==515314==    by 0x4D647A5: xaccTransEqual (Transaction.c:981)
    ==515314==    by 0x15C0E8: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:901)
    ...
    ==515314==  Address 0x8725260 is 0 bytes inside a block of size 59 free'd
    ==515314==    at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==515314==    by 0x15BDB1: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:883)
    ...
    ==515314==  Block was alloc'd at
    ==515314==    at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==515314==    by 0x5618677: __vasprintf_internal (vasprintf.c:116)
    ==515314==    by 0x520E8C1: g_vasprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x51DBBE0: g_strdup_vprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x51DBC9C: g_strdup_printf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x15BBAC: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:879)
    ...
    
    ok 78 /engine/Transaction/xaccTransEqual

commit dc62959553f59a0a88dcc803eeac6d0eb6a2b77b
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Mon May 15 18:58:10 2023 +0100

    Fix crash in test-engine on Arch
    
    Thanks, Valgrind:
    
    ==515314== Invalid read of size 8
    ==515314==    at 0x4ED46F3: gncInvoiceRemoveEntries (gncInvoice.c:767)
    ==515314==    by 0x142B35: teardown_with_invoice (utest-Invoice.c:274)
    ...
    ==515314==  Address 0x8557b98 is 8 bytes inside a block of size 24 free'd
    ==515314==    at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==515314==    by 0x51B565D: g_list_remove (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x4ED42EF: gncInvoiceRemoveEntry (gncInvoice.c:688)
    ==515314==    by 0x4ED46A2: gncInvoiceRemoveEntries (gncInvoice.c:781)
    ==515314==    by 0x142B35: teardown_with_invoice (utest-Invoice.c:274)
    ...
    ==515314==  Block was alloc'd at
    ==515314==    at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==515314==    by 0x51BD948: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x51B1CB9: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
    ==515314==    by 0x4ED4271: gncInvoiceAddEntry (gncInvoice.c:676)
    ==515314==    by 0x142401: setup_with_invoice (utest-Invoice.c:142)
    ...
    
    ok 57 /engine/gncInvoice/post trans - vendor bill



Summary of changes:
 gnucash/gnome-utils/CMakeLists.txt                 |   2 -
 gnucash/gnome-utils/gnc-date-delta.c               | 431 ---------------------
 gnucash/gnome-utils/gnc-date-delta.h               |  94 -----
 gnucash/gnome-utils/gnc-main-window.cpp            |  26 +-
 gnucash/gnome/gnc-plugin-page-invoice.c            |  11 +-
 gnucash/gnome/gnc-plugin-page-register.c           |  22 +-
 gnucash/gnome/gnc-split-reg.c                      |  53 +--
 gnucash/gnome/gnc-split-reg.h                      |   1 -
 gnucash/import-export/aqb/gnc-plugin-aqbanking.c   |  10 +-
 gnucash/register/register-gnome/gnucash-cursor.h   |   7 -
 libgnucash/engine/gncInvoice.c                     |   7 +-
 .../engine/test/test-engine-kvp-properties.c       |  24 +-
 libgnucash/engine/test/utest-Transaction.cpp       |   1 +
 po/POTFILES.in                                     |   1 -
 14 files changed, 33 insertions(+), 657 deletions(-)
 delete mode 100644 gnucash/gnome-utils/gnc-date-delta.c
 delete mode 100644 gnucash/gnome-utils/gnc-date-delta.h



More information about the gnucash-patches mailing list