gnucash stable: Bug 798983 - Empty Orphan account appears after entering transactions in 5.3

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/89360252 (commit)
	from  https://github.com/Gnucash/gnucash/commit/76ac345e (commit)



commit 89360252fb597077df82edc1d208d381f66ca828
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Sep 8 15:08:44 2023 -0700

    Bug 798983 - Empty Orphan account appears after entering transactions in 5.3
    
    Caused by trying to set the account on the blank split. The blank split
    was present because the method used to clear the split list for the
    receiving transaction in gnc_float_txn_to_txn_swap_accounts only removed
    splits that belong to the transaction, and the blank split doesn't.
    
    Adds new function xaccTransClearSplits to do a more thorough job.
    Also improve the documentation for xaccSplitDestroy to better explain when
    a transaction will be destroyed if it empties the split list.
    
     # Please enter the commit message for your
    changes. Lines starting



Summary of changes:
 gnucash/register/ledger-core/split-register-copy-ops.c |  5 ++---
 libgnucash/engine/Split.h                              |  7 ++++---
 libgnucash/engine/Transaction.c                        |  9 +++++++++
 libgnucash/engine/Transaction.h                        | 11 +++++++++++
 4 files changed, 26 insertions(+), 6 deletions(-)