gnucash stable: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/4dec95e6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a09228a8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/637522fe (commit)
	 via  https://github.com/Gnucash/gnucash/commit/215a16a5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e17345d4 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/94db524c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/83ecabeb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c03b57b8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fbf5ab8b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4ff0ac38 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/58c4d5f0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8a60a3cf (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2e1a8bc8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a31eefd6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c3f56e89 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/acff356f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fe728708 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/176ff441 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/35946c8e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/eebf5055 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b5e5a0ed (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a2bd020b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/81475489 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/fc4f4ae6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c284f962 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/917b4b24 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/502dcc03 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e46195cb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4c916ada (commit)
	 via  https://github.com/Gnucash/gnucash/commit/30b41544 (commit)
	from  https://github.com/Gnucash/gnucash/commit/ccd6d5cc (commit)



commit 4dec95e64275d8e17b3b1b77d2d71912e293233c
Merge: ccd6d5ccf4 a09228a83e
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Sep 10 10:44:26 2023 -0700

    Merge John Ralls's 'more-stock-assistant' into stable

commit a09228a83ef39f50fb80868dc2cfaec0a6fabf8c
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Sep 10 10:22:57 2023 -0700

    [stock-txn-asst] Remove superflouos FieldMask::DISABLED tags
    
    From the stock entry of stock split and reverse split templates. Since
    there are other flags on the line the DISABLED flag isn't useful.

commit 637522fed163982560612761adb134fd1a32571e
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Sep 9 14:30:00 2023 -0700

    [stock-txn-asst] Don't report account missing if it's not required.

commit 215a16a5e8dbd092ae8fd17d61ce86d5c2960fc6
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Sep 9 14:16:05 2023 -0700

    [stock-txn-asst] Add multicurrency note to introduction.
    
    Warning the user that they're not supported.

commit e17345d4b6ccbce04a1ec75673987f61cfcc55bf
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Sep 9 13:16:07 2023 -0700

    [stock-txn-asst] Include a marker split in the stock account for divs.

commit 94db524c60d67650d5402baca307d794f3a13ff7
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Sep 8 16:23:52 2023 -0700

    [stokc-txn-asst] Add default currency to GncAccountSelector
    
    Set the default currency to the transaction currency for creating
    new accounts.

commit 83ecabebce46f0ced4b40299a480c6a4a0a76def
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Sep 5 14:08:09 2023 -0700

    [stock-txn-asst] Remove unused method.

commit c03b57b8fbf9cb9388efe8d30bc350f9b9a0d988
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Aug 31 18:29:22 2023 -0700

    [stock-txn-asst] Doxygen documentation of classes.
    
    And non-trivial functions.

commit fbf5ab8b4789ff8e0db6d463fe82dcf1f48fd1c3
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Aug 31 12:24:49 2023 -0700

    [stock-txn-asst] Ensure correct memory management flow.
    
    For the StockTransferController and GncGuiManager events.

commit 4ff0ac383a52de68f52e352b29678697d2211d7c
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Aug 31 11:41:29 2023 -0700

    [stock-txn-asst] Change structs to classes.
    
    With private data members, replacing direct member access with
    accessor functions and refactoring functionality away from the
    Model, View, and Controller container classes to the classes
    that own the members.
    
    This removes the need for RTTI inspection as regular virtual
    function dispatch accounts for differences in Entry classes.

commit 58c4d5f0ca24b3e7a259175bb6966b705b7acf76
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Aug 29 13:09:47 2023 -0700

    [stock-txn-asst] Variable-specific callbacks take an entry pointer.
    
    Prerequisite for making class member variables private.

commit 8a60a3cf0f6633f8e1fee46f618099949d190606
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Aug 29 09:49:34 2023 -0700

    [stock-txn-asst] model::calculate_price becomes entry::print_price
    
    Replace multiple-responsibility function in the wrong class with a
    single-responsibility function in the right class.
    
    Changes the signature of a couple of PageStockValue functions.

commit 2e1a8bc8a7a8f75133d219e8c38e2daa0e314393
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Aug 28 16:41:01 2023 -0700

    [stock-txn-asst] Separate setting the amount/value and validating it.
    
    Setting happens via callbacks and they were handed direct access
    to the member variables so the validation wasn't happening.
    Validation also requires a logger and passing that to the callbacks
    would be hard.

commit a31eefd6735ba003e34c00796ea553c1c7e0ce23
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Aug 27 16:41:23 2023 -0700

    [stock-txn-asst] Fix setting the initial focussed widget.
    
    One can't grab the widget in prepare, the page runs its own focus so
    one must handle the page's focus event.

commit c3f56e89e54499d4b6bf5348646ff52ce67f138b
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Aug 27 12:21:40 2023 -0700

    [stock-txn-asst] Handle correctly capitalizing fees.

commit acff356fec1f2b95a22d7b8152b1efcc4a3681b0
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Aug 27 12:19:43 2023 -0700

    [stock-txn-asst] Set all the needed parameters for StockCGEntry.
    
    So that it will create the split and do so with the right memo.

commit fe728708ce7244f3c209b87cbbab3c46a4f35dd5
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 25 13:04:40 2023 -0700

    [stock-txn-asst] Move stock amount calculation to StockEntry.
    
    It's StockEntry's responsibility not Model's. This lets us remove
    the model parameter from PageStockAmount::prepare. It also requires
    that we use StockEntry's set_amount method instead of just setting
    m_amount it StockAssistantTest::instantiate_model.

commit 176ff44128020f2d5d8e79d774a199ce7a607546
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 25 12:09:26 2023 -0700

    [stock-txn-asst] Remove StockTransactionSplitInfo
    
    With action a StockTransactionEntry member it's no longer useful.

commit 35946c8e1cb2612e3cc8e34cf0d5b69f9bca2501
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 25 11:53:02 2023 -0700

    [stock-txn-asst] Make action a StockTransactionEntry member.
    
    Instead of a function paramter that's set and translated
    inconsistently.

commit eebf505548823ae856106c2683121b5327fdf332
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Aug 24 11:32:59 2023 -0700

    [stock-txn-asst] Reformat explanation messages to remove long lines.

commit b5e5a0ed2f35bcef5c069e1b0289cd70a9b03e73
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Aug 24 11:24:14 2023 -0700

    [stock-txn-asst] Add notes about cash-in-lieu and capgains.
    
    Cash in lieu must be reported as a separate transaction. There was
    already a note about that in reverse splits, apply it to regular
    splits.
    
    Add suggestion to enter a placeholder number when one can't
    immediately calculate the capital gain on a sale or cover buy.

commit a2bd020b13b9575e7d60bd532def58398418d9d0
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Aug 20 15:48:24 2023 -0700

    [stock-txn-asst] Call gettext on the transaction type explanation.

commit 814754891fde3fda6c21a71a04351f77d1106b76
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Aug 14 18:06:04 2023 -0700

    [stock-txn-asst] Don't generate stock splitinfo if no stock split.

commit fc4f4ae6d7784d6ac1e6f66e92993ec68b35fdea
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Aug 14 16:48:14 2023 -0700

    Bug 799054 - Stock Assist not functioning
    
    * Get the sign right when calculating new shares
    * Fix displaying values and units on the summary page
    * Don't display "missing" for values when the user skips
      entering a 0 value.
    * Create the Stock-account's fees split (when capitalizing)
      and cap-gains split.

commit c284f96286e106b47046c3de8438cb105a4d358e
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 11 15:09:51 2023 -0700

    [asst-stock-txn] Fix typo.

commit 917b4b247c136b6a8d89911ee592383cc304c846
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Aug 10 16:58:49 2023 -0700

    [stock-txn-asst] Fix sell-side stock amounts.
    
    It was setting a negative amount in one too many places.

commit 502dcc03ce683563f45e0f0d748aa69b0cada541
Author: John Ralls <jralls at ceridwen.us>
Date:   Sun Aug 6 14:36:20 2023 -0700

    [stock-txn-asst] Extract Logger class

commit e46195cba7410e1383524f5d33f3b89158c7f042
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Aug 5 17:12:09 2023 -0700

    [stock-txn-asst] Move prepare details into Assistant Page member funcs.
    
    Substantially simplifies the code by reducing the needed indirection.
    In most cases the StockTransactionEntry has everything the page needs
    and can be passed as a parameter, further simplifying the code.

commit 4c916ada2205b68e290dc0896ddfc665c120ab64
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 4 16:29:03 2023 -0700

    Make connect_signals and prepare StockAssistantController members.

commit 30b41544ce0b406333b5cd01564f7b95b49937bf
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 4 14:12:03 2023 -0700

    Make StockAssistantController's view member in-place instead of a unique_ptr.
    
    Requires moving some parameters around so we can initialize it
    correctly:
    All of the view's pages need to take an Account* and get its commodity
    or currency in their ctors, and creation of the builder has to move to
    gnc_stock_transaction_assistant and get passed in.



Summary of changes:
 gnucash/gnome/assistant-stock-transaction.cpp      | 2061 +++++++++++++-------
 .../test/gtest-assistant-stock-transaction.cpp     |   35 +-
 .../gtkbuilder/assistant-stock-transaction.glade   |    2 +-
 3 files changed, 1345 insertions(+), 753 deletions(-)