gnucash stable: Revert "Fix two use-after-free issues found by address sanitizer."

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/8546aa97 (commit)
	from  https://github.com/Gnucash/gnucash/commit/4dbf8030 (commit)



commit 8546aa975ef590c245c9654395d841ea140c057f
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Feb 19 21:11:54 2024 -0800

    Revert "Fix two use-after-free issues found by address sanitizer."
    
    This reverts commit 4dbf8030411a1e2287be6e939336668e10f4a03a.
    
    The use-after free errors are caused by the compiler reordering the
    steps in xaccSplitFree and Transaction's do_destroy. Unfortunately the
    corrections here caused trouble in other places, leading to test failures.



Summary of changes:
 libgnucash/engine/Split.cpp       | 8 +-------
 libgnucash/engine/Transaction.cpp | 9 +++------
 2 files changed, 4 insertions(+), 13 deletions(-)