gnucash stable: [backend/xml] dom_tree_to_guid returns std::optional<GncGUID> instead of GncGUID*

Christopher Lam clam at code.gnucash.org
Sat Dec 6 19:37:52 EST 2025


Updated	 via  https://github.com/Gnucash/gnucash/commit/a57cd653 (commit)
	from  https://github.com/Gnucash/gnucash/commit/2e3fd090 (commit)



commit a57cd653e518165cc5b9cf02fda28d0a88895320
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Dec 5 10:27:09 2025 +0800

    [backend/xml] dom_tree_to_guid returns std::optional<GncGUID> instead of GncGUID*
    
    therefore GncGUID is stack-allocated, removing the need for guid_free



Summary of changes:
 libgnucash/backend/xml/gnc-account-xml-v2.cpp      | 15 ++-----
 libgnucash/backend/xml/gnc-bill-term-xml-v2.cpp    | 17 +++-----
 libgnucash/backend/xml/gnc-book-xml-v2.cpp         |  6 +--
 libgnucash/backend/xml/gnc-budget-xml-v2.cpp       |  7 +---
 libgnucash/backend/xml/gnc-customer-xml-v2.cpp     | 23 ++++-------
 libgnucash/backend/xml/gnc-employee-xml-v2.cpp     | 15 +++----
 libgnucash/backend/xml/gnc-entry-xml-v2.cpp        | 47 ++++++++--------------
 libgnucash/backend/xml/gnc-invoice-xml-v2.cpp      | 33 +++++----------
 libgnucash/backend/xml/gnc-job-xml-v2.cpp          |  9 ++---
 libgnucash/backend/xml/gnc-lot-xml-v2.cpp          |  5 +--
 libgnucash/backend/xml/gnc-order-xml-v2.cpp        |  9 ++---
 libgnucash/backend/xml/gnc-owner-xml-v2.cpp        | 21 +++++-----
 libgnucash/backend/xml/gnc-pricedb-xml-v2.cpp      |  5 +--
 libgnucash/backend/xml/gnc-schedxaction-xml-v2.cpp | 10 ++---
 libgnucash/backend/xml/gnc-tax-table-xml-v2.cpp    | 23 ++++-------
 libgnucash/backend/xml/gnc-transaction-xml-v2.cpp  | 29 +++++--------
 libgnucash/backend/xml/gnc-vendor-xml-v2.cpp       | 23 ++++-------
 libgnucash/backend/xml/io-gncxml-v1.cpp            |  5 +--
 libgnucash/backend/xml/sixtp-dom-parsers.cpp       | 17 ++++----
 libgnucash/backend/xml/sixtp-dom-parsers.h         |  3 +-
 .../backend/xml/test/test-dom-converters1.cpp      |  6 +--
 libgnucash/backend/xml/test/test-file-stuff.cpp    |  8 +---
 .../backend/xml/test/test-xml-transaction.cpp      | 17 +++-----
 23 files changed, 126 insertions(+), 227 deletions(-)



More information about the gnucash-patches mailing list