[GNC] Custom invoices don't work after upgrade

[John Ralls]

> On Jul 2, 2020, at 8:37 AM, Frank H. Ellenberger <frank.h.ellenberger at gmail.com> wrote:
> 
> Hi,
> 
> Am 02.07.20 um 17:01 schrieb lomax at clickworkorange.com:
>> On Thu, 2020-07-02 at 13:32 +0100, lomax at clickworkorange.com wrote:
>>> My custom invoice template that I've used for many years stopped
>>> working after upgrading to 3.4 as part of a dist-upgrade. I had to
>>> remove a few things such as 
> :
> 
> also 3.4 is several years old. If you prefer to stay on a distribution
> shipping such old program versin, you should consider to use
> https://wiki.gnucash.org/wiki/Flatpak.
> 
>> I have compared this with the shipped reports (e.g. taxinvoice.scm) and
>> it looks correct. So, a few hours killed, no progress. Any suggestions?
> 
> Yes, you should compare the shipped reports, but of a *recent* GnuCash
> version 3.11 or 4.0. ISTR they got several improvements in between.

Note, however that part of those improvements have come with API deprecated in 3.x and removed outright from 4.0.

Report options are implemented as vectors. The second snippet of code that you commented out created an option, so I'd guess that the exception is from an attempt to use that no-longer existing option. 

For the previous issue about qof-book-get-slots, if you weren't calling that where did the slots argument to (coy-info) come from?

Yup, GnuCash's API changes. The release notes accompanying each release explain the changes and since 3.0 functions that are removed are first deprecated so that they emit warnings, but you have to check the trace file to see the warnings. If you don't want to keep up with GnuCash development you have two choices: Never upgrade or don't use custom reports.

Regards,
John Ralls