[GNC] Problems upgrading to 4.8a

[john]

This is https://bugs.gnucash.org/show_bug.cgi?id=798612

I discovered while researching this that yelp v.42 just dropped support for the ghelp: scheme. help:gnucash-help and help:gnucash-guide are able to find the GnuCash docs so another option for the packager (and BTW I think the one in question is the Debian packager, Dmitry Smirnov whom I've cc'd ) would be to apply this:
diff --git a/gnucash/gnome-utils/gnc-gnome-utils.c b/gnucash/gnome-utils/gnc-gnome-utils.c
index 2c3cfac02..6cfbf3473 100644
--- a/gnucash/gnome-utils/gnc-gnome-utils.c
+++ b/gnucash/gnome-utils/gnc-gnome-utils.c
@@ -277,7 +277,7 @@ gnc_gnome_help_yelp_anchor_fix (GtkWindow *parent, const char *file_name, const
     g_free (help_file);

     if (full_path)
-        uri = g_strconcat ("ghelp:", full_path, "?", anchor, NULL);
+        uri = g_strconcat ("help:", full_path, "?", anchor, NULL);
     else
     {
         gnc_error_dialog (parent, "%s\n%s", _(msg_no_help_found), _(msg_no_help_reason));
@@ -475,7 +475,7 @@ gnc_gnome_help (GtkWindow *parent, const char *file_name, const char *anchor)
     if (anchor)
         uri = gnc_gnome_help_yelp_anchor_fix (parent, file_name, anchor);
     else
-        uri = g_strconcat ("ghelp:", file_name, NULL);
+        uri = g_strconcat ("help:", file_name, NULL);

     DEBUG ("Attempting to opening help uri %s", uri);

We could elaborate that by making it conditional on the yelp version and put it in GnuCash 4.12 that we'll release at the end of the month. 

BTW the Gnome 43 runtime also releases in two weeks. IIRC Flathub will force us to update our current 41 to 42 or 43 for the 4.12 release, meaning that we need that change for the flatpak build too.

Regards,
John Ralls


> On Sep 5, 2022, at 9:03 AM, Geert Janssens <geert.gnucash at kobaltwit.be> wrote:
> 
> Hi Phil,
> 
> My response was not for flatpak. It's how the gnucash-docs build scripts (written by the 
> gnucash developers) currently install things. And on Fedora 36 for example that is still the 
> case.
> 
> The documentation links you are listing are the html versions of our documentation and is 
> not what is presented when invoking "Tutorial" or "Contents" from the GnuCash menus. 
> GnuCash will look for the docbook version of the documentation, which at this point is still 
> installed in /usr/share/gnome/help/C/gnucash-guide and /usr/shar/gnome/help/C/gnucash-
> help. (Well, pedantically it will ask yelp to look there by means of the "ghelp:xyz" construct, 
> but yelp dropped support for that construct in version 42).
> 
> I don't know what the Ubuntu packager for our documentation has decided on. But if 
> Ubuntu only ships the html version of the gnucash documentation, I consider that a bug in 
> that distribution. There are a few possible ways the Ubuntu packager could solve this:
> * either also patch the gnucash package to look for the html version of the documentation
> * revert the change in yelp that drops support for the "ghelp" search qualifier. Considering 
> gnucash is probably the last application in the Gnome ecosystem to still depend on this, it's 
> unlikely Ubuntu would go that route.
> * backport the patchset from the master branch in the gnucash and gnucash-docs 
> repositories that rearrange our documentation output to work with yelp's "help" search 
> qualifier. That way gnucash will be able to present the documentation again as you were 
> used to in Ubuntu 20.04.
> 
> I think the last option would be the most future proof one.
> 
> Regards,
> 
> Geert
> 
> 
> Op maandag 5 september 2022 17:01:22 CEST schreef Phil Wolff via gnucash-user:
>> Geert ~
>> 
>> Thanks for responding!
>> That may be true for a Flatpak installation, but mine is what GNC calls
>> "pristine," and I've found the documents at
>> - file:///usr/share/doc/gnucash-docs/gnucash-guide-en/index.html
>> - file:///usr/share/doc/gnucash-docs/gnucash-help-en/help.html
>> 
>> ~ Phil
>> 
>> On 9/5/22 00:46, Geert Janssens wrote:
>>> Hi Phil,
>>> 
>>> Regarding the documentation, it seems like Ubuntu 22.04.1 ships a newer
>>> help viewer that's not compatible with where GnuCash stores its guide and
>>> manual on disk. This has been fixed for the future GnuCash 5.0 but not
>>> for the current 4.x series.
>>> 
>>> As temporary workarounds you could either
>>> - browse the documentation online (via the gnucash website) or
>>> - load the documentation from the command line using one of these commands
>>> 
>>>   yelp /usr/share/gnome/help/C/gnucash-guide/gnucash-guide.xml
>>>   yelp /usr/share/gnome/help/C/gnucash-help/gnucash-help.xml
>>> 
>>> Regards,
>>> 
>>> Geert
>>> 
>>> Op zondag 4 september 2022 00:14:09 CEST schreef David Cousens:
>>>> Phil,
>>>> 
>>>> The installation of the GnuCash help and Tutorial and concepts guide is a
>>>> separate download and installation from the installation of the program
>>>> and
>>>> is available under a separate link in the panels on the left on the
>>>> GNuCash
>>>> webpage i.e. https://gnucash.org/docs.phtml .  They should also be able
>>>> to
> _______________________________________________
> gnucash-user mailing list
> gnucash-user at gnucash.org
> To update your subscription preferences or to unsubscribe:
> https://lists.gnucash.org/mailman/listinfo/gnucash-user
> -----
> Please remember to CC this list on all your replies.
> You can do this by using Reply-To-List or Reply-All.