[GNC] [Bug 798864] Budget Revalues for the Income are positive numbers.porting on select reports are wrong

[David T.]

Richard,

Just a note that if you reply to Christopher's bug messages by email, the discussion at the bug website is incomplete. You and the community would be better served by your replying in the bug itself.

David T.​

On Apr 17, 2023, 11:02, at 11:02, Richard Lindgren <rlindgren1 at outlook.com> wrote:
>Sounds like you understand my problem. However, since I'm not a
>programmer, I hesitate to tackle this patch. Maybe it is easier than it
>looks and is probably the best fix? I'm just nervous here.
>
>Let me ask this basic question. When I am creating my Budget, I have
>assumed this:
>        1. All Income values are positive numbers.
>        2. All Expense values are negative numbers.
>
>With that being said and used, my reports work for; a) Profit and Loss
>Report and b) my Budget Report.
>
>Now the question is, where do I go from here?
>
>Richard
>
>-----Original Message-----
>From: bugs-admin at bugs.gnucash.org <bugs-admin at bugs.gnucash.org>
>Sent: Monday, April 17, 2023 12:19 AM
>To: rlindgren1 at outlook.com
>Subject: [Bug 798864] Budget Reporting on select reports are wrong
>
>https://bugs.gnucash.org/show_bug.cgi?id=798864
>
>--- Comment #7 from Christopher Lam <christopher.lck at gmail.com> ---
>Created attachment 374682
>  --> https://bugs.gnucash.org/attachment.cgi?id=374682&action=edit
>candidate patch
>
>Here's a candidate replacement for budget-income-statement.scm, or the
>patch pasted below. You can overwrite the budget-income-statement.scm
>somewhere into the Program Files\gnucash\etc...\ (you'll need admin
>access).
>
>It changes the definition of net-income from simple summation to a
>recalculation of balances of both income and expense budget amounts. I
>think this is the correct fix.
>
>modified   gnucash/report/reports/standard/budget-income-statement.scm
>@@ -428,7 +428,11 @@
>       (gnc:get-assoc-account-balances-total expense-account-balances))
>
>              (net-income
>-              (gnc:collector- revenue-total expense-total))
>+              (gnc:collector-
>+               (gnc:get-assoc-account-balances-total
>+                (get-assoc-account-balances-budget
>+                 budget (append revenue-accounts expense-accounts)
>+                 period-start period-end
>gnc:budget-account-get-net))))
>
>              (table-env
>               (list
>
>--
>You are receiving this mail because:
>You are on the CC list for the bug.
>You reported the bug.
>_______________________________________________
>gnucash-user mailing list
>gnucash-user at gnucash.org
>To update your subscription preferences or to unsubscribe:
>https://lists.gnucash.org/mailman/listinfo/gnucash-user
>-----
>Please remember to CC this list on all your replies.
>You can do this by using Reply-To-List or Reply-All.