[GNC] Upgrading to 5.3 from 2.6.15

[Christopher Lam]

On Wed, 26 Jul 2023 at 11:32, john <jralls at ceridwen.us> wrote:

> Yeah, it's gotten a lot faster since Chris Lam figured out it was checking
> every transaction for every split in the transaction and fixed it to only
> traverse the transactions once.
>

This was only 1 part of the speedup: each typical (2 or more splits)
transaction was being scrubbed as many times as they have splits. This was
PR 1651.
The more significant speedup was to eliminate the xaccTransBegin/CommitEdit
before the scrub, and only call them if the transaction needed to be
scrubbed. PR 1654.
Benchmarks:
https://github.com/Gnucash/gnucash/pull/1654#issuecomment-1573876944